From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33416) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c1r6a-0002kW-Nm for qemu-devel@nongnu.org; Wed, 02 Nov 2016 04:41:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c1r6W-0004hw-QI for qemu-devel@nongnu.org; Wed, 02 Nov 2016 04:41:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52964) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c1r6W-0004hD-LS for qemu-devel@nongnu.org; Wed, 02 Nov 2016 04:41:04 -0400 Message-ID: <1478076061.1578.17.camel@redhat.com> From: Gerd Hoffmann Date: Wed, 02 Nov 2016 09:41:01 +0100 In-Reply-To: References: <20161102070352.GA547@aepfle.de> <8d6f75ed-1091-43d0-dcb7-e58ab210469c@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 Subject: Re: [Qemu-devel] build failures in master List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth Cc: Olaf Hering , qemu-devel@nongnu.org, Quan Xu , Stefano Stabellini , Quan Xu , Emil Condrea On Mi, 2016-11-02 at 09:26 +0100, Thomas Huth wrote: > On 02.11.2016 09:14, Thomas Huth wrote: > > On 02.11.2016 08:03, Olaf Hering wrote: > >> Not sure if there are automated build tests to catch such mistakes, > >> these errors appeared after qemu-20161028T142950.fd209e4: > >> > >> [ 337s] ../hw/xen/xen_pvdev.o: In function `xen_pv_printf': > >> [ 337s] /home/abuild/rpmbuild/BUILD/qemu-20161101T165305.4eb28ab/hw/x= en/xen_pvdev.c:220: undefined reference to `qemu_log_vprintf' > >=20 > > Does it work if you add an explicit #include "qemu/log.h" at the > > beginning of that file (after osdep.h)? > >=20 > >> [ 220s] ui/gtk.c: In function 'gd_text_key_down': > >> [ 220s] ui/gtk.c:1073: error: 'GDK_KEY_Delete' undeclared (first use = in this function) > >=20 > > That one is strange ... it should get defined by > > which we include from include/ui/gtk.h (and that file is included in > > ui/gtk.c), so I fail to see how that could not be defined on your > > system. Which version of GTK are you using? >=20 > OK, looks like the name changed with gtk version 2.22: >=20 > https://git.gnome.org/browse/gtk+/commit/gdk/gdkkeysyms.h?id=3D913cdf3be7= 50a1e74c09b20edf55a57f9a919fcc >=20 > I'll try to come up with a patch for this issue (since we still seem to > support gtk 2.18 in QEMU) ... Ah, right, that one. Top of gtk.c file already has a bunch of #defines for that where we can simply add the delete key. And as you've tracked down it's changed in 2.22 + newer if would be nice to change the #ifdef to use GTK_CHECK_VERSION so we record this fact in the source file. thanks, Gerd