All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Graf <agraf@suse.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 2/3] bcm2835 video: Map frame buffer as 32bpp
Date: Wed,  2 Nov 2016 10:36:19 +0100	[thread overview]
Message-ID: <1478079380-176304-3-git-send-email-agraf@suse.de> (raw)
In-Reply-To: <1478079380-176304-1-git-send-email-agraf@suse.de>

To enable working efifb support, let's map the frame buffer as 32bpp
instead of 16bpp.

Signed-off-by: Alexander Graf <agraf@suse.de>
---
 drivers/video/bcm2835.c | 6 +++---
 include/configs/rpi.h   | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/video/bcm2835.c b/drivers/video/bcm2835.c
index cd605e6..cc6454f 100644
--- a/drivers/video/bcm2835.c
+++ b/drivers/video/bcm2835.c
@@ -71,9 +71,9 @@ void lcd_ctrl_init(void *lcdbase)
 	msg_setup->virtual_w_h.body.req.width = w;
 	msg_setup->virtual_w_h.body.req.height = h;
 	BCM2835_MBOX_INIT_TAG(&msg_setup->depth, SET_DEPTH);
-	msg_setup->depth.body.req.bpp = 16;
+	msg_setup->depth.body.req.bpp = 32;
 	BCM2835_MBOX_INIT_TAG(&msg_setup->pixel_order, SET_PIXEL_ORDER);
-	msg_setup->pixel_order.body.req.order = BCM2835_MBOX_PIXEL_ORDER_BGR;
+	msg_setup->pixel_order.body.req.order = BCM2835_MBOX_PIXEL_ORDER_RGB;
 	BCM2835_MBOX_INIT_TAG(&msg_setup->alpha_mode, SET_ALPHA_MODE);
 	msg_setup->alpha_mode.body.req.alpha = BCM2835_MBOX_ALPHA_MODE_IGNORED;
 	BCM2835_MBOX_INIT_TAG(&msg_setup->virtual_offset, SET_VIRTUAL_OFFSET);
@@ -103,7 +103,7 @@ void lcd_ctrl_init(void *lcdbase)
 
 	panel_info.vl_col = w;
 	panel_info.vl_row = h;
-	panel_info.vl_bpix = LCD_COLOR16;
+	panel_info.vl_bpix = LCD_COLOR32;
 
 	gd->fb_base = bus_to_phys(
 		msg_setup->allocate_buffer.body.resp.fb_address);
diff --git a/include/configs/rpi.h b/include/configs/rpi.h
index 45c8234..19e0212 100644
--- a/include/configs/rpi.h
+++ b/include/configs/rpi.h
@@ -72,7 +72,7 @@
 #define CONFIG_BCM2835_GPIO
 /* LCD */
 #define CONFIG_LCD_DT_SIMPLEFB
-#define LCD_BPP				LCD_COLOR16
+#define LCD_BPP				LCD_COLOR32
 /*
  * Prevent allocation of RAM for FB; the real FB address is queried
  * dynamically from the VideoCore co-processor, and comes from RAM
-- 
1.8.5.6

  parent reply	other threads:[~2016-11-02  9:36 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-02  9:36 [U-Boot] [PATCH v3 0/3] Raspberry Pi EFI enablement Alexander Graf
2016-11-02  9:36 ` [U-Boot] [PATCH v3 1/3] ARM: bcm283x: Implement EFI RTS reset_system Alexander Graf
2016-11-06  3:01   ` Stephen Warren
2016-11-06 10:24     ` Alexander Graf
2016-11-08  3:26       ` Stephen Warren
2016-11-09 11:43         ` Alexander Graf
2016-11-09 15:50           ` Stephen Warren
2016-11-09 18:09             ` Alexander Graf
2016-11-06 10:32     ` Alexander Graf
2016-11-29 17:38   ` [U-Boot] [U-Boot, v3, " Tom Rini
2016-11-02  9:36 ` Alexander Graf [this message]
2016-11-06  3:04   ` [U-Boot] [PATCH v3 2/3] bcm2835 video: Map frame buffer as 32bpp Stephen Warren
2016-11-29 17:39   ` [U-Boot] [U-Boot, v3, " Tom Rini
2016-11-02  9:36 ` [U-Boot] [PATCH v3 3/3] bcm2835: Reserve the spin table in efi memory map Alexander Graf
2016-11-06  3:07   ` Stephen Warren
2016-11-06 10:27     ` Alexander Graf
2016-11-29 18:01   ` [U-Boot] [U-Boot, v3, " Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1478079380-176304-3-git-send-email-agraf@suse.de \
    --to=agraf@suse.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.