From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexey.Brodkin@synopsys.com (Alexey Brodkin) Date: Wed, 2 Nov 2016 12:23:43 +0000 Subject: [PATCH v2] drm/arcpgu: Accommodate adv7511 switch to DRM bridge In-Reply-To: <4881796E12491D4BB15146FE0209CE646784BA6F@DE02WEMBXB.internal.synopsys.com> References: <1476863178-15237-1-git-send-email-Eugeniy.Paltsev@synopsys.com> <26a8cad6-118f-146f-f6ea-e9d539fc40a1@codeaurora.org> <1476869529.3348.27.camel@synopsys.com> <4881796E12491D4BB15146FE0209CE646784BA6F@DE02WEMBXB.internal.synopsys.com> List-ID: Message-ID: <1478089382.2710.20.camel@synopsys.com> To: linux-snps-arc@lists.infradead.org Hi Daniel, David, On Mon, 2016-10-24@18:33 +0000, Alexey Brodkin wrote: > Hi Daniel, > > > > > -----Original Message----- > > From: linux-snps-arc [mailto:linux-snps-arc-bounces at lists.infradead.org] On Behalf Of Alexey Brodkin > > Sent: 19 ??????? 2016 ?. 12:33 > > To: dri-devel at lists.freedesktop.org; architt at codeaurora.org; Eugeniy.Paltsev at synopsys.com > > Cc: linux-snps-arc at lists.infradead.org; linux-kernel at vger.kernel.org > > Subject: Re: [PATCH v2] drm/arcpgu: Accommodate adv7511 switch to DRM bridge > > > > Hi Archit, all, > > > > On Wed, 2016-10-19@14:43 +0530, Archit Taneja wrote: > > > > > > > > > On 10/19/2016 01:16 PM, Eugeniy Paltsev wrote: > > > > > > > > > > > > ARC PGU driver starts crashing on initialization after > > > > 'commit e12c2f645557 ("drm/i2c: adv7511: Convert to drm_bridge")' > > > > This happenes because in "arcpgu_drm_hdmi_init" function we get pointer > > > > of "drm_i2c_encoder_driver" structure, which doesn't exist after > > > > adv7511 hdmi encoder interface changed from slave encoder to drm bridge. > > > > So, when we call "encoder_init" function from this structure driver > > > > crashes. > > > > [snip] > > > > > > > > Looks good now. > > > > > > Reviewed-by: Archit Taneja > > > > And IMHO it would be really good to get this one back-ported to 4.8 > > because it really fixes kernel crash if ARC PGU driver is used. > > > > It might be a bit of a problem because patch itself a little-bit larger > > than formal requirement for stable backports but let's see if it gets accepted. > > Could you please pick this one up? > I may alternatively send a pull-request to David but not sure if 1 patch worth it. > > Also if that's not really too late it would be good to get this one in 4.9 since the patch > In question fixes a real driver crash on its instantiation. > Actually driver crash happens since 4.8 but I failed to notice it earlier and given amount > of changes I think there's barely a chance for it it to be accepted in stable branches... > which in its turn makes at least 4.9 very desirable. Any chance this one gets accepted anytime soon? Regards, Alexey From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexey Brodkin Subject: Re: [PATCH v2] drm/arcpgu: Accommodate adv7511 switch to DRM bridge Date: Wed, 2 Nov 2016 12:23:43 +0000 Message-ID: <1478089382.2710.20.camel@synopsys.com> References: <1476863178-15237-1-git-send-email-Eugeniy.Paltsev@synopsys.com> <26a8cad6-118f-146f-f6ea-e9d539fc40a1@codeaurora.org> <1476869529.3348.27.camel@synopsys.com> <4881796E12491D4BB15146FE0209CE646784BA6F@DE02WEMBXB.internal.synopsys.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <4881796E12491D4BB15146FE0209CE646784BA6F@DE02WEMBXB.internal.synopsys.com> Content-Language: en-US Content-ID: <10A44C17F0DAE843A9F5CAD3624163E4@internal.synopsys.com> Sender: linux-kernel-owner@vger.kernel.org To: "daniel.vetter@ffwll.ch" , "airlied@linux.ie" Cc: Eugeniy Paltsev , "linux-kernel@vger.kernel.org" , "architt@codeaurora.org" , "dri-devel@lists.freedesktop.org" , Ramiro Oliveira , "linux-snps-arc@lists.infradead.org" List-Id: dri-devel@lists.freedesktop.org SGkgRGFuaWVsLCBEYXZpZCwNCg0KT24gTW9uLCAyMDE2LTEwLTI0IGF0IDE4OjMzICswMDAwLCBB bGV4ZXkgQnJvZGtpbiB3cm90ZToNCj4gSGkgRGFuaWVsLA0KPiANCj4gPiANCj4gPiAtLS0tLU9y aWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiA+IEZyb206IGxpbnV4LXNucHMtYXJjIFttYWlsdG86bGlu dXgtc25wcy1hcmMtYm91bmNlc0BsaXN0cy5pbmZyYWRlYWQub3JnXSBPbiBCZWhhbGYgT2YgQWxl eGV5IEJyb2RraW4NCj4gPiBTZW50OiAxOSDQvtC60YLRj9Cx0YDRjyAyMDE2INCzLiAxMjozMw0K PiA+IFRvOiBkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnOyBhcmNoaXR0QGNvZGVhdXJv cmEub3JnOyBFdWdlbml5LlBhbHRzZXZAc3lub3BzeXMuY29tDQo+ID4gQ2M6IGxpbnV4LXNucHMt YXJjQGxpc3RzLmluZnJhZGVhZC5vcmc7IGxpbnV4LWtlcm5lbEB2Z2VyLmtlcm5lbC5vcmcNCj4g PiBTdWJqZWN0OiBSZTogW1BBVENIIHYyXSBkcm0vYXJjcGd1OiBBY2NvbW1vZGF0ZSBhZHY3NTEx IHN3aXRjaCB0byBEUk0gYnJpZGdlDQo+ID4gDQo+ID4gSGkgQXJjaGl0LCBhbGwsDQo+ID4gDQo+ ID4gT24gV2VkLCAyMDE2LTEwLTE5IGF0IDE0OjQzICswNTMwLCBBcmNoaXQgVGFuZWphIHdyb3Rl Og0KPiA+ID4gDQo+ID4gPiANCj4gPiA+IE9uIDEwLzE5LzIwMTYgMDE6MTYgUE0sIEV1Z2VuaXkg UGFsdHNldiB3cm90ZToNCj4gPiA+ID4gDQo+ID4gPiA+IA0KPiA+ID4gPiBBUkMgUEdVIGRyaXZl ciBzdGFydHMgY3Jhc2hpbmcgb24gaW5pdGlhbGl6YXRpb24gYWZ0ZXINCj4gPiA+ID4gJ2NvbW1p dCBlMTJjMmY2NDU1NTcgKCJkcm0vaTJjOiBhZHY3NTExOiBDb252ZXJ0IHRvIGRybV9icmlkZ2Ui KScNCj4gPiA+ID4gVGhpcyBoYXBwZW5lcyBiZWNhdXNlIGluICJhcmNwZ3VfZHJtX2hkbWlfaW5p dCIgZnVuY3Rpb24gd2UgZ2V0IHBvaW50ZXINCj4gPiA+ID4gb2YgImRybV9pMmNfZW5jb2Rlcl9k cml2ZXIiIHN0cnVjdHVyZSwgd2hpY2ggZG9lc24ndCBleGlzdCBhZnRlcg0KPiA+ID4gPiBhZHY3 NTExIGhkbWkgZW5jb2RlciBpbnRlcmZhY2UgY2hhbmdlZCBmcm9tIHNsYXZlIGVuY29kZXIgdG8g ZHJtIGJyaWRnZS4NCj4gPiA+ID4gU28sIHdoZW4gd2UgY2FsbCAiZW5jb2Rlcl9pbml0IiBmdW5j dGlvbiBmcm9tIHRoaXMgc3RydWN0dXJlIGRyaXZlcg0KPiA+ID4gPiBjcmFzaGVzLg0KPiA+IA0K PiA+IFtzbmlwXQ0KPiA+IA0KPiA+ID4gDQo+ID4gPiBMb29rcyBnb29kIG5vdy4NCj4gPiA+IA0K PiA+ID4gUmV2aWV3ZWQtYnk6IEFyY2hpdCBUYW5lamEgPGFyY2hpdHRAY29kZWF1cm9yYS5vcmc+ DQo+ID4gDQo+ID4gQW5kIElNSE8gaXQgd291bGQgYmUgcmVhbGx5IGdvb2QgdG8gZ2V0IHRoaXMg b25lIGJhY2stcG9ydGVkIHRvIDQuOA0KPiA+IGJlY2F1c2UgaXQgcmVhbGx5IGZpeGVzIGtlcm5l bCBjcmFzaCBpZiBBUkMgUEdVIGRyaXZlciBpcyB1c2VkLg0KPiA+IA0KPiA+IEl0IG1pZ2h0IGJl IGEgYml0IG9mIGEgcHJvYmxlbSBiZWNhdXNlIHBhdGNoIGl0c2VsZiBhIGxpdHRsZS1iaXQgbGFy Z2VyDQo+ID4gdGhhbiBmb3JtYWwgcmVxdWlyZW1lbnQgZm9yIHN0YWJsZSBiYWNrcG9ydHMgYnV0 IGxldCdzIHNlZSBpZiBpdCBnZXRzIGFjY2VwdGVkLg0KPiANCj4gQ291bGQgeW91IHBsZWFzZSBw aWNrIHRoaXMgb25lIHVwPw0KPiBJIG1heSBhbHRlcm5hdGl2ZWx5IHNlbmQgYSBwdWxsLXJlcXVl c3QgdG8gRGF2aWQgYnV0IG5vdCBzdXJlIGlmIDEgcGF0Y2ggd29ydGggaXQuDQo+IA0KPiBBbHNv IGlmIHRoYXQncyBub3QgcmVhbGx5IHRvbyBsYXRlIGl0IHdvdWxkIGJlIGdvb2QgdG8gZ2V0IHRo aXMgb25lIGluIDQuOSBzaW5jZSB0aGUgcGF0Y2gNCj4gSW4gcXVlc3Rpb24gZml4ZXMgYSByZWFs IGRyaXZlciBjcmFzaCBvbiBpdHMgaW5zdGFudGlhdGlvbi4NCj4gQWN0dWFsbHkgZHJpdmVyIGNy YXNoIGhhcHBlbnMgc2luY2UgNC44IGJ1dCBJIGZhaWxlZCB0byBub3RpY2UgaXQgZWFybGllciBh bmQgZ2l2ZW4gYW1vdW50DQo+IG9mIGNoYW5nZXMgSSB0aGluayB0aGVyZSdzIGJhcmVseSBhIGNo YW5jZSBmb3IgaXQgaXQgdG8gYmUgYWNjZXB0ZWQgaW4gc3RhYmxlIGJyYW5jaGVzLi4uDQo+IHdo aWNoIGluIGl0cyB0dXJuIG1ha2VzIGF0IGxlYXN0IDQuOSB2ZXJ5IGRlc2lyYWJsZS4NCg0KQW55 IGNoYW5jZSB0aGlzIG9uZSBnZXRzIGFjY2VwdGVkIGFueXRpbWUgc29vbj8NCg0KUmVnYXJkcywN CkFsZXhleQ==