All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Dalessandro, Dennis" <dennis.dalessandro-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: "foraker1-i2BcT+NCU+M@public.gmane.org"
	<foraker1-i2BcT+NCU+M@public.gmane.org>,
	"linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] IB/rdmavt: Only put mmap_info ref if it exists
Date: Wed, 2 Nov 2016 15:17:54 +0000	[thread overview]
Message-ID: <1478099871.17398.22.camel@intel.com> (raw)
In-Reply-To: <1478033052-147252-1-git-send-email-foraker1-i2BcT+NCU+M@public.gmane.org>

On Tue, 2016-11-01 at 13:44 -0700, Jim Foraker wrote:
> rvt_create_qp() creates qp->ip only when a qp creation request comes
> from
> userspace (udata is not NULL).  If we exceed the number of available
> queue pairs however, the error path always attempts to put a kref to
> this
> structure.  If the requestor is inside the kernel, this leads to a 

requestor -> requester

> crash.
> 
> We fix this by checking that qp->ip is not NULL before caling 

caling -> calling

> kref_put().
> 
> Signed-off-by: Jim Foraker <foraker1@llnl.gov>

Thanks Jim!

Cc: Stable <stable@vger.kernel.org> # 4.7+
Acked-by: Dennis Dalessandro <dennis.dalessandro@intel.com>


  parent reply	other threads:[~2016-11-02 15:17 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-01 20:44 [PATCH] IB/rdmavt: Only put mmap_info ref if it exists Jim Foraker
     [not found] ` <1478033052-147252-1-git-send-email-foraker1-i2BcT+NCU+M@public.gmane.org>
2016-11-02 15:17   ` Dalessandro, Dennis [this message]
2016-11-02 15:40   ` Leon Romanovsky
2016-11-04 17:33   ` Jonathan Toppins
     [not found]     ` <b67230ae-baf0-c932-4acd-b414a33c158f-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-12-01 13:29       ` Estrin, Alex
2016-12-14 16:51   ` Doug Ledford

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1478099871.17398.22.camel@intel.com \
    --to=dennis.dalessandro-ral2jqcrhueavxtiumwx3w@public.gmane.org \
    --cc=foraker1-i2BcT+NCU+M@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.