All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Senyk <thomas.senyk@pelagicore.com>
To: Otavio Salvador <otavio@ossystems.com.br>
Cc: "meta-freescale@yoctoproject.org" <meta-freescale@yoctoproject.org>
Subject: Re: [meta-fsl-arm][PATCH] Adding -lEGL and -lGAL to glesv2.pc
Date: Fri, 21 Jun 2013 13:52:03 +0200	[thread overview]
Message-ID: <1478326.AWSm3pbtDQ@rudolf> (raw)
In-Reply-To: <4463487.qfruEhnmJE@rudolf>

On Friday, 21 June, 2013 11:08:19 Thomas Senyk wrote:
> On Thursday, 20 June, 2013 17:33:00 Otavio Salvador wrote:
> > On Thu, Jun 20, 2013 at 5:00 PM, Otavio Salvador
> > 
> > <otavio@ossystems.com.br> wrote:
> > > On Thu, Jun 20, 2013 at 11:31 AM, Thomas Senyk
> > > 
> > > <thomas.senyk@pelagicore.com> wrote:
> > >> From: Thomas Senyk <thomas.senyk@pelagicore.com>
> > >> 
> > >> libGLESv2 has undefined symbols, which get provided by libEGL and
> > >> libGAL,
> > >> but libGLESv2 has no implicit 'link' to those libs.
> > >> So if you link against libGLESv2 but not against libEGL and libGAL,
> > >> you'll get 'undefined symbol'-errors.
> > >> 
> > >> Signed-off-by: Thomas Senyk <thomas.senyk@pelagicore.com>
> > > 
> > > Please change your short description to include the recipe name:
> > > 
> > > gpu-viv-bin-mx6q: Add ...
> > > <empty line>
> > > libGLESv2 ...
> > > 
> > > Signed-off-by: ...
> 
> ah, right! sorry
> 
> > I did this locally and pushed to master-next. Please follow these
> > guidelines when doing the commit log so it easy finding which changes
> > might affect each recipe.
> 
> Thanks and I keep in mind for next time!
> 
> > Regards,
> > 
> > --
> > Otavio Salvador                             O.S. Systems
> > http://www.ossystems.com.br        http://projetos.ossystems.com.br
> > Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750


I've just spotted two other things:

a: I skipped glesv1_cm.pc because I've not used it so far, but I looks like it 
has the same gco* and eglWaitClient symbols as "*UND*" as libGLESv2, so maybe 
it should be linked the same way

and more importantly (at least for me):
b: egl.pc (and glesv1_cm.pc) has:
 "Requires.private: libdrm x11 xext xdamage xfixes xcb"
this must be removed as it's wrong and harmful for non-x11 builds.
If this is a 'must-have' for x11 builds, we need to have two files.
Any thought from somebody who has done a x11 build on 4.0.0 drivers?


Greets
Thomas




   


  reply	other threads:[~2013-06-21 11:52 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-20 14:31 [meta-fsl-arm][PATCH] Adding -lEGL and -lGAL to glesv2.pc Thomas Senyk
2013-06-20 20:00 ` Otavio Salvador
2013-06-20 20:33   ` Otavio Salvador
2013-06-21  9:08     ` Thomas Senyk
2013-06-21 11:52       ` Thomas Senyk [this message]
2013-06-21 12:35         ` Otavio Salvador
2013-06-21 13:02           ` Thomas Senyk
2013-06-21 13:43             ` Otavio Salvador
2013-06-21 14:24               ` Thomas Senyk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1478326.AWSm3pbtDQ@rudolf \
    --to=thomas.senyk@pelagicore.com \
    --cc=meta-freescale@yoctoproject.org \
    --cc=otavio@ossystems.com.br \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.