From: "Jérôme de Bretagne" <jerome.debretagne@gmail.com>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
"Rafael J. Wysocki" <rafael@kernel.org>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Kefeng Wang <wangkefeng.wang@huawei.com>, Feng Kan <fkan@apm.com>,
linux-serial@vger.kernel.org, linux-acpi@vger.kernel.org,
linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] ACPI / platform: Add support for build-in properties
Date: Sun, 06 Nov 2016 17:09:34 +0100 [thread overview]
Message-ID: <1478448574.1591.2.camel@gmail.com> (raw)
In-Reply-To: <20161103142126.87413-1-heikki.krogerus@linux.intel.com>
Le jeudi 03 novembre 2016 à 16:21 +0200, Heikki Krogerus a écrit :
> We have a couple of drivers, acpi_apd.c and acpi_lpss.c,
> that need to pass extra build-in properties to the devices
> they create. Previously the drivers added those properties
> to the struct device which is member of the struct
> acpi_device, but that does not work. Those properties need
> to be assigned to the struct device of the platform device
> instead in order for them to become available to the
> drivers.
>
> To fix this, this patch changes acpi_create_platform_device
> function to take struct property_entry pointer as parameter.
>
> Fixes: 20a875e2e86e ("serial: 8250_dw: Add quirk for APM X-Gene SoC")
> Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
>
> Hi,
>
> Found the problem, and this is my proposal for a fix.
>
> Jérôme, please test it when you have time.
>
Hi Heikki,
I can confirm that this patch fixes the issue I've reported on the Lenovo
ThinkPad 8 tablet. You were fast to find the root cause, impressive, really
appreciated.
Feel free to add:
Tested-by: Jérôme de Bretagne <jerome.debretagne@gmail.com>
Let's hope it can still make it during the remaining 4.9 rc timing.
Cheers,
Jérôme
next prev parent reply other threads:[~2016-11-06 16:09 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-18 18:34 BT / serial regression introduced during the recent 4.9-rc1 merge? Jérôme de Bretagne
2016-10-20 19:31 ` Jérôme de Bretagne
[not found] ` <1476815643.1658.3.camel-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-11-01 16:58 ` [PATCHv2 3/3] serial: 8250_dw: Add quirk for APM X-Gene SoC (was: BT / serial regression introduced during the recent 4.9-rc1 merge?) Jérôme de Bretagne
2016-11-01 16:58 ` Jérôme de Bretagne
[not found] ` <1478019507.1676.23.camel-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-11-02 3:49 ` Rafael J. Wysocki
2016-11-02 3:49 ` Rafael J. Wysocki
2016-11-02 8:37 ` Heikki Krogerus
[not found] ` <20161102083702.GC11523-FZxXFokcWpatqXYlAKuG4QC/G2K4zDHf@public.gmane.org>
2016-11-02 13:52 ` Jérôme de Bretagne
2016-11-02 13:52 ` Jérôme de Bretagne
[not found] ` <1478094732.1606.1.camel-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-11-02 15:41 ` Heikki Krogerus
2016-11-02 15:41 ` Heikki Krogerus
[not found] ` <20161102154139.GD11523-FZxXFokcWpatqXYlAKuG4QC/G2K4zDHf@public.gmane.org>
2016-11-03 14:21 ` [PATCH] ACPI / platform: Add support for build-in properties Heikki Krogerus
2016-11-03 14:21 ` Heikki Krogerus
2016-11-03 16:12 ` Yazen Ghannam
2016-11-06 16:09 ` Jérôme de Bretagne [this message]
2016-11-09 23:40 ` Rafael J. Wysocki
2016-11-09 23:40 ` Rafael J. Wysocki
2016-11-07 13:34 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1478448574.1591.2.camel@gmail.com \
--to=jerome.debretagne@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=fkan@apm.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=wangkefeng.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.