From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/3] drm/i915: Remove chipset flush after cache flush
Date: Mon, 07 Nov 2016 18:16:00 +0200 [thread overview]
Message-ID: <1478535360.2879.14.camel@linux.intel.com> (raw)
In-Reply-To: <20161107121002.GK30925@nuc-i3427.alporthouse.com>
On ma, 2016-11-07 at 12:10 +0000, Chris Wilson wrote:
> On Mon, Nov 07, 2016 at 02:01:46PM +0200, Joonas Lahtinen wrote:
> >
> > On su, 2016-11-06 at 12:59 +0000, Chris Wilson wrote:
> > >
> > > We always flush the chipset prior to executing with the GPU, so we can
> > > skip the flush during ordinary domain management.
> > >
> > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> >
> > Maybe even add?
> >
> > Fixes: dcd79934b0dd ("drm/i915: Unconditionally flush any chipset buffers before execbuf")
>
> It is just an optimisation - I don't want to imply that we should be
Well, it's an optimization that fixes a commit which duplicated the
call. That might be a regression in some micro-benchmark.
But fine without the tag too, if you're sure it's not a big one.
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-11-07 16:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-06 12:59 [PATCH 1/3] drm/i915: Remove chipset flush after cache flush Chris Wilson
2016-11-06 13:00 ` [PATCH 2/3] drm/i915: Always flush the dirty CPU cache when pinning the scanout Chris Wilson
2016-11-08 11:33 ` Ville Syrjälä
2016-11-08 11:42 ` Chris Wilson
2016-11-08 13:45 ` Ville Syrjälä
2016-11-06 13:00 ` [PATCH 3/3] drm/i915: Mark all skipped clflushes as leaving the CPU cache dirty Chris Wilson
2016-11-06 13:45 ` ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915: Remove chipset flush after cache flush Patchwork
2016-11-07 12:01 ` [PATCH 1/3] " Joonas Lahtinen
2016-11-07 12:10 ` Chris Wilson
2016-11-07 16:16 ` Joonas Lahtinen [this message]
2016-11-08 11:08 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1478535360.2879.14.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.