From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:43006 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752814AbcKGQfZ (ORCPT ); Mon, 7 Nov 2016 11:35:25 -0500 Subject: Patch "gpio: GPIO_GET_LINEEVENT_IOCTL: Validate line offset" has been added to the 4.8-stable tree To: lars@metafoo.de, gregkh@linuxfoundation.org, linus.walleij@linaro.org Cc: , From: Date: Mon, 07 Nov 2016 17:24:15 +0100 Message-ID: <14785358556227@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org List-ID: This is a note to let you know that I've just added the patch titled gpio: GPIO_GET_LINEEVENT_IOCTL: Validate line offset to the 4.8-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: gpio-gpio_get_lineevent_ioctl-validate-line-offset.patch and it can be found in the queue-4.8 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let know about it. >>From b8b0e3d303654b3bb7b31b0266c513fd6f4132ce Mon Sep 17 00:00:00 2001 From: Lars-Peter Clausen Date: Tue, 18 Oct 2016 16:54:03 +0200 Subject: gpio: GPIO_GET_LINEEVENT_IOCTL: Validate line offset From: Lars-Peter Clausen commit b8b0e3d303654b3bb7b31b0266c513fd6f4132ce upstream. The line offset that is used as an index into the descs array is provided by userspace and might go beyond the bounds of the array. If that happens undefined behavior will occur. Make sure that the offset is within the bounds of the desc array and reject any requests that specify a value outside of it. Fixes: 61f922db7221 ("gpio: userspace ABI for reading GPIO line events") Signed-off-by: Lars-Peter Clausen Signed-off-by: Linus Walleij Signed-off-by: Greg Kroah-Hartman --- drivers/gpio/gpiolib.c | 5 +++++ 1 file changed, 5 insertions(+) --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c @@ -731,6 +731,11 @@ static int lineevent_create(struct gpio_ lflags = eventreq.handleflags; eflags = eventreq.eventflags; + if (offset >= gdev->ngpio) { + ret = -EINVAL; + goto out_free_label; + } + /* This is just wrong: we don't look for events on output lines */ if (lflags & GPIOHANDLE_REQUEST_OUTPUT) { ret = -EINVAL; Patches currently in stable-queue which might be from lars@metafoo.de are queue-4.8/gpio-gpio_get_chipinfo_ioctl-fix-line-offset-validation.patch queue-4.8/gpio-gpio_get_line-handle-event-_ioctl-fix-file-descriptor-leak.patch queue-4.8/gpio-gpio_get_chipinfo_ioctl-fix-information-leak.patch queue-4.8/gpio-gpio_get_lineevent_ioctl-reject-invalid-line-and-event-flags.patch queue-4.8/gpio-gpiohandle_get_line_values_ioctl-fix-another-information-leak.patch queue-4.8/gpio-gpio_get_linehandle_ioctl-reject-invalid-line-flags.patch queue-4.8/gpio-gpio_get_lineevent_ioctl-validate-line-offset.patch queue-4.8/gpio-gpiohandle_get_line_values_ioctl-fix-information-leak.patch queue-4.8/gpio-gpio_get_linehandle_ioctl-validate-line-offset.patch