From: james_p_freyensee@linux.intel.com (J Freyensee)
Subject: [PATCH v1] nvmet: Don't queue fatal error work if csts.cfs is set
Date: Mon, 07 Nov 2016 10:07:39 -0800 [thread overview]
Message-ID: <1478542059.3350.3.camel@linux.intel.com> (raw)
In-Reply-To: <20161106164140.GG15675@lst.de>
On Sun, 2016-11-06@17:41 +0100, Christoph Hellwig wrote:
> On Sun, Nov 06, 2016@11:16:18AM +0200, Sagi Grimberg wrote:
> >
> > In the transport, in case of an interal queue error like
> > error completion in rdma we trigger a fatal error. However,
> > multiple queues in the same controller can serr error completions
> > and we don't want to trigger fatal error work more than once.
> >
> > Signed-off-by: Sagi Grimberg <sagi at grimberg.me>
>
> Looks fine, although I'd avoid the goto and just use a if blocks
> for the rest of the action..
I agree, this is such a short function, I would think the goto could be
removed and still have an obvious yet easy to maintain error return
path using basic if()/else().
But looks good otherwise.
Reviewed-by: Jay Freyensee <james_p_freyensee at linux.intel.com>
>
> Reviewed-by: Christoph Hellwig <hch at lst.de>
prev parent reply other threads:[~2016-11-07 18:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-06 9:16 [PATCH v1] nvmet: Don't queue fatal error work if csts.cfs is set Sagi Grimberg
2016-11-06 16:41 ` Christoph Hellwig
2016-11-07 18:07 ` J Freyensee [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1478542059.3350.3.camel@linux.intel.com \
--to=james_p_freyensee@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.