From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de ([195.135.220.15]:42906 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751100AbcKHOEh (ORCPT ); Tue, 8 Nov 2016 09:04:37 -0500 Message-ID: <1478613875.2168.1.camel@suse.com> Subject: Re: [PATCH] USB: cdc-acm: fix TIOCMIWAIT From: Oliver Neukum To: Johan Hovold Cc: Greg Kroah-Hartman , linux-usb@vger.kernel.org, stable Date: Tue, 08 Nov 2016 15:04:35 +0100 In-Reply-To: <1478607057-21181-1-git-send-email-johan@kernel.org> References: <1478607057-21181-1-git-send-email-johan@kernel.org> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: stable-owner@vger.kernel.org List-ID: On Tue, 2016-11-08 at 13:10 +0100, Johan Hovold wrote: > The TIOCMIWAIT implementation would return -EINVAL if any of the three > supported signals were included in the mask. > > Instead of returning an error in case TIOCM_CTS is included, simply > drop the mask check completely, which is in accordance with how other > drivers implement this ioctl. > > Fixes: 5a6a62bdb925 ("cdc-acm: add TIOCMIWAIT") > Cc: stable > Signed-off-by: Johan Hovold Acked-by: Oliver Neukum Regards Oliver