From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752861AbcKHVk7 (ORCPT ); Tue, 8 Nov 2016 16:40:59 -0500 Received: from mga01.intel.com ([192.55.52.88]:44129 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751662AbcKHVk5 (ORCPT ); Tue, 8 Nov 2016 16:40:57 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,611,1473145200"; d="asc'?scan'208";a="899228232" Message-ID: <1478641235.2341.29.camel@intel.com> Subject: Re: [PATCH] checkpatch: Fix warnings when --no-tree is used From: Jeff Kirsher To: apw@canonical.com, joe@perches.com Cc: linux-kernel@vger.kernel.org Date: Tue, 08 Nov 2016 13:40:35 -0800 In-Reply-To: <1477081625-47881-1-git-send-email-jeffrey.t.kirsher@intel.com> References: <1477081625-47881-1-git-send-email-jeffrey.t.kirsher@intel.com> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-AqLi2ROj/+t4g/33Dfo0" X-Mailer: Evolution 3.20.5 (3.20.5-1.fc24) Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-AqLi2ROj/+t4g/33Dfo0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 2016-10-21 at 13:27 -0700, Jeff Kirsher wrote: > When users run checkpatch.pl with --no-tree option, $root is not > defined, which causes an ugly warning that it is not initialized at > line 764.=C2=A0=C2=A0The test for whether or not a file is maintained sho= uld > only be run when a kernel tree is defined (i.e. not when --no-tree > option is being used) >=20 > Signed-off-by: Jeff Kirsher > --- > =C2=A0scripts/checkpatch.pl | 2 +- > =C2=A01 file changed, 1 insertion(+), 1 deletion(-) Ping? Joe? Andy? =C2=A0Where are we at with this patch? > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > index a8368d1..7a54978 100755 > --- a/scripts/checkpatch.pl > +++ b/scripts/checkpatch.pl > @@ -2352,7 +2352,7 @@ sub process { > =C2=A0 } > =C2=A0 } > =C2=A0 > - if ($found_file) { > + if ($found_file && $tree) { > =C2=A0 if (is_maintained_obsolete($realfile)) { > =C2=A0 WARN("OBSOLETE", > =C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0"$realfile is marked as 'obsolete= ' > in the MAINTAINERS hierarchy.=C2=A0=C2=A0No unnecessary modifications ple= ase.\n"); --=-AqLi2ROj/+t4g/33Dfo0 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCgAGBQJYIkZTAAoJEOVv75VaS+3O6HcP/RpOtWkaoKqxvUGP4THZnWlE q9EcGRk63EajP2tz8l9hP0SFPwt+I6zJiTQsRNkPrR2yrBDUW/WFVixb0LuAkEac LPR2Zf2ozgj5wb0usqHEAb3CSeZAghZ0/JYe4ImuxxG7JqQR2oHH8l43ZBtNcBBd dJzBg6kV2aOFqcXSfP4UBWh/9urgZOHFJGnF0DWywpvDypswdV8o9UTESkDen/qK 73GXJRb0LPVqZV2wLZ/TEheyKnABfbHso19Rvv9MAJ7xUwKdFJig/SN7G42NPXN/ Jyx2sIv+9EZRjZK1dZmK3N0NxhV6tNiF8N46hyu09xkdnGnnhnbzD891r7cl1Hef +LktjxfbfAwTeSLugLkEsp5XgShJV6Fif6nUiY0Pcxg6DVgW9CXkCRQxw6p/dzgj jpvQmnHRxzQYaOX15Hi5y7naaZF24XfhGJK25wvWynxTO5b7dvZAv9P+SDLGOQ2R bLZDkaxXnru4NJpDSagfJrElhHmIGXUqXq5B+baRZtdEe+acRAbM7Ooil8AGZcQj TEklY6eHjFHYEhgNQk24ZVA9aJ4sYvsPtgpD05QuNMbc96Ri9IOYLQ5r2j5UxOUn pUg0lM0+MLJvjfqWrYt61z3ysUDK2yvoS1CYF+Q8J+Wd+AzpCZfeiFYfjFj1IAfp vqWCSKiSTXS2LrUnj8Ht =D5aH -----END PGP SIGNATURE----- --=-AqLi2ROj/+t4g/33Dfo0--