From mboxrd@z Thu Jan 1 00:00:00 1970 From: Caesar Wang Subject: drm/bridge: analogix_dp: clear psr_support when disable_bridge Date: Wed, 9 Nov 2016 11:53:34 +0800 Message-ID: <1478663614-9914-1-git-send-email-wxt@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: seanpaul@chromium.org Cc: zain wang , tomeu.vizoso@collabora.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, marcheu@chromium.org, Caesar Wang List-Id: linux-rockchip.vger.kernel.org RnJvbTogemFpbiB3YW5nIDx3enpAcm9jay1jaGlwcy5jb20+CgpEb24ndCBydW4gcHNyIHdvcmsg ZHVyaW5nIGVuYWJsaW5nIGJyaWRnZSB3aGVuIHlvdSByZXN0YXJ0IHVpLCBpdCBtYXkgbWFrZQps aW5rIHRyYWluaW5nIGZhaWwgc2luY2UgdGhlcmUgaXMgYSByYWNlIGJldHdlZW4gdGhlbSBpbiBB VVggQ0ggcmVzb3VyY2UuCgpTaWduZWQtb2ZmLWJ5OiB6YWluIHdhbmcgPHd6ekByb2NrLWNoaXBz LmNvbT4KU2lnbmVkLW9mZi1ieTogQ2Flc2FyIFdhbmcgPHd4dEByb2NrLWNoaXBzLmNvbT4KQ2M6 IFRvbWV1IFZpem9zbyA8dG9tZXUudml6b3NvQGNvbGxhYm9yYS5jb20+CkNjOiBkcmktZGV2ZWxA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCkNjOiBTZWFuIFBhdWwgPHNlYW5wYXVsQGNocm9taXVtLm9y Zz4KCi0tLQpCVFc6Ci0gVGhlIHRyYWluaW5nIGlzc3VlIGlzIGdvbmUgd2l0aCB0aGlzIHBhdGNo LAogIHRoZXJlIGFyZSBmb3VyIG1hY2hpbmVzIGhhdmUgcGFzc2VkIHRoZSAxMDAwMCBjeWNsZXMg d2l0aCBTMlIgdGVzdHMuCi0gVmVyaWZpZWQgb24gQ2hyb21lT1Mga2VybmVsdjQuNC4KCiBkcml2 ZXJzL2dwdS9kcm0vYnJpZGdlL2FuYWxvZ2l4L2FuYWxvZ2l4X2RwX2NvcmUuYyB8IDEgKwogMSBm aWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspCgpkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJt L2JyaWRnZS9hbmFsb2dpeC9hbmFsb2dpeF9kcF9jb3JlLmMgYi9kcml2ZXJzL2dwdS9kcm0vYnJp ZGdlL2FuYWxvZ2l4L2FuYWxvZ2l4X2RwX2NvcmUuYwppbmRleCA2ZTA0NDdmLi40NDMxZjYyIDEw MDY0NAotLS0gYS9kcml2ZXJzL2dwdS9kcm0vYnJpZGdlL2FuYWxvZ2l4L2FuYWxvZ2l4X2RwX2Nv cmUuYworKysgYi9kcml2ZXJzL2dwdS9kcm0vYnJpZGdlL2FuYWxvZ2l4L2FuYWxvZ2l4X2RwX2Nv cmUuYwpAQCAtMTExNyw2ICsxMTE3LDcgQEAgc3RhdGljIHZvaWQgYW5hbG9naXhfZHBfYnJpZGdl X2Rpc2FibGUoc3RydWN0IGRybV9icmlkZ2UgKmJyaWRnZSkKIAlpZiAocmV0KQogCQlEUk1fRVJS T1IoImZhaWxlZCB0byBzZXR1cCB0aGUgcGFuZWwgcmV0ID0gJWRcbiIsIHJldCk7CiAKKwlkcC0+ cHNyX3N1cHBvcnQgPSBmYWxzZTsKIAlkcC0+ZHBtc19tb2RlID0gRFJNX01PREVfRFBNU19PRkY7 CiB9CiAKLS0gCjIuNy40CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3Rv cC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmkt ZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752126AbcKIDxx (ORCPT ); Tue, 8 Nov 2016 22:53:53 -0500 Received: from mail-pf0-f194.google.com ([209.85.192.194]:36480 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751091AbcKIDxw (ORCPT ); Tue, 8 Nov 2016 22:53:52 -0500 From: Caesar Wang To: seanpaul@chromium.org Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, tomeu.vizoso@collabora.com, linux-rockchip@lists.infradead.org, marcheu@chromium.org, zain wang , Caesar Wang Subject: drm/bridge: analogix_dp: clear psr_support when disable_bridge Date: Wed, 9 Nov 2016 11:53:34 +0800 Message-Id: <1478663614-9914-1-git-send-email-wxt@rock-chips.com> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: zain wang Don't run psr work during enabling bridge when you restart ui, it may make link training fail since there is a race between them in AUX CH resource. Signed-off-by: zain wang Signed-off-by: Caesar Wang Cc: Tomeu Vizoso Cc: dri-devel@lists.freedesktop.org Cc: Sean Paul --- BTW: - The training issue is gone with this patch, there are four machines have passed the 10000 cycles with S2R tests. - Verified on ChromeOS kernelv4.4. drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c index 6e0447f..4431f62 100644 --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c @@ -1117,6 +1117,7 @@ static void analogix_dp_bridge_disable(struct drm_bridge *bridge) if (ret) DRM_ERROR("failed to setup the panel ret = %d\n", ret); + dp->psr_support = false; dp->dpms_mode = DRM_MODE_DPMS_OFF; } -- 2.7.4