From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cao =?gb2312?Q?Shufeng/=B2=DC=CA=F7=B7=E9?= Subject: Re: [PATCH v4 0/3] Make core_pattern support namespace Date: Wed, 9 Nov 2016 12:06:13 +0800 Message-ID: <1478664373.27686.8.camel@cn.fujitsu.com> References: <1477380536-3307-1-git-send-email-caosf.fnst@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1477380536-3307-1-git-send-email-caosf.fnst-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, mashimiao.fnst-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org, ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org List-Id: containers.vger.kernel.org cGluZwrlnKggMjAxNi0xMC0yNeS6jOeahCAxNToyOCArMDgwMO+8jENhbyBTaHVmZW5n5YaZ6YGT 77yaCj4gVGhpcyBwYXRjaHNldCBpbmNsdWRlcyBmb2xsb3dpbmcgZnVuY3Rpb24gcG9pbnRzOgo+ IDE6IExldCB1c2VybW9kZWhlbHBlciBmdW5jdGlvbiBwb3NzaWJsZSB0byBzZXQgcGlkIG5hbWVz cGFjZQo+ICAgIGRvbmUgYnk6IFtQQVRDSCB2NCAxLzNdIE1ha2UgY2FsbF91c2VybW9kZWhlbHBl cl9leGVjIHBvc3NpYmxlCj4gICAgdG8gc2V0IHBpZCBuYW1lc3BhY2UuCj4gMjogTGV0IHBpcGVf dHlwZSBjb3JlX3BhdHRlcm4gd3JpdGUgZHVtcCBpbnRvIGNvbnRhaW5lcidzIHJvb3Rmcwo+ICAg IGRvbmUgYnk6IFtQQVRDSCB2NCAyLzNdIExpbWl0IGR1bXBfcGlwZSBwcm9ncmFtJ3MgcGVybWlz c2lvbiB0bwo+ICAgIGluaXQgZm9yIGNvbnRhaW5lci4KPiAyOiBNYWtlIHNlcGFyYXRlIGNvcmVf cGF0dGVybiBzZXR0aW5nIGZvciBlYWNoIGNvbnRhaW5lcgo+ICAgIGRvbmUgYnk6IFtQQVRDSCB2 NCAzLzNdIE1ha2UgY29yZV9wYXR0ZXJuIHN1cHBvcnQgbmFtZXNwYWNlCj4gMzogQ29tcGF0aWJp bGl0eSB3aXRoIGN1cnJlbnQgc3lzdGVtCj4gICAgYWxzbyBpbmNsdWRlZCBpbjogW1BBVENIIHY0 IDMvM10gTWFrZSBjb3JlX3BhdHRlcm4gc3VwcG9ydCBuYW1lc3BhY2UKPiAgICBJZiBjb250YWlu ZXIgaGFkbid0IGNoYW5nZSBjb3JlX3BhdHRlcm4gc2V0dGluZywgaXQgd2lsbCBrZWVwCj4gICAg c2FtZSBzZXR0aW5nIHdpdGggaG9zdC4KPiAKPiBUZXN0Ogo+IDE6IFBhc3MgYSB0ZXN0IHNjcmlw dCBmb3IgZWFjaCBmdW5jdGlvbiBvZiB0aGlzIHBhdGNoc2V0Cj4gICAgIyMgVEVTVCBJTiBIT1NU ICMjCj4gICAgW3Jvb3RAa2VybmVsZGV2IGR1bXB0ZXN0XSMgLi90ZXN0X2hvc3QKPiAgICBTZXQg ZmlsZSBjb3JlX3BhdHRlcm46IE9LCj4gICAgLi90ZXN0X2hvc3Q6IGxpbmUgNDE6ICAyMzY2IFNl Z21lbnRhdGlvbiBmYXVsdCAgICAgIChjb3JlIGR1bXBlZCkgIiRTQ1JJPQo+IFBUX0JBU0VfRElS Ii9tYWtlX2R1bXAKPiAgICBDaGVja2luZyBkdW1wZmlsZTogT0sKPiAgICBTZXQgZmlsZSBjb3Jl X3BhdHRlcm46IE9LCj4gICAgLi90ZXN0X2hvc3Q6IGxpbmUgNDE6ICAyMzY5IFNlZ21lbnRhdGlv biBmYXVsdCAgICAgIChjb3JlIGR1bXBlZCkgIiRTQ1JJPQo+IFBUX0JBU0VfRElSIi9tYWtlX2R1 bXAKPiAgICBDaGVja2luZyBkdW1wX3BpcGUgdHJpZ2dlcmVkOiBPSwo+ICAgIENoZWNraW5nIHJv b3RmczogT0sKPiAgICBDaGVja2luZyBkdW1wZmlsZTogT0sKPiAgICBDaGVja2luZyBuYW1lc3Bh Y2U6IE9LCj4gICAgQ2hlY2tpbmcgcHJvY2VzcyBsaXN0OiBPSwo+ICAgIENoZWNraW5nIGNhcGFi aWxpdGllczogT0sKPiAKPiAgICAjIyBURVNUIElOIEdVRVNUICMjCj4gICAgIyAuL3Rlc3QKPiAg ICBTZWdtZW50YXRpb24gZmF1bHQgKGNvcmUgZHVtcGVkKQo+ICAgIENoZWNraW5nIGR1bXBfcGlw ZSB0cmlnZ2VyZWQ6IE9LCj4gICAgQ2hlY2tpbmcgcm9vdGZzOiBPSwo+ICAgIENoZWNraW5nIGR1 bXBmaWxlOiBPSwo+ICAgIENoZWNraW5nIG5hbWVzcGFjZTogT0sKPiAgICBDaGVja2luZyBwcm9j ZXNzIGxpc3Q6IE9LCj4gICAgQ2hlY2tpbmcgY2cgcGlkczogT0sKPiAgICBDaGVja2luZyBjYXBh YmlsaXRpZXM6IE9LCj4gICAgWyAgIDY0Ljk0MDczNF0gbWFrZV9kdW1wWzI0MzJdOiBzZWdmYXVs dCBhdCAwIGlwIDAwMDAwMDAwMDA0MDA0OWQgc3AgMDAwPQo+IDA3ZmZjNGFmMDI1ZjAgZXJyb3Ig NiBpbiBtYWtlX2R1bXBbNDAwMDAwK2E2MDAwXQo+ICAgICMKPiAyOiBQYXNzIG90aGVyIHRlc3Qo d2hpY2ggaXMgbm90IGVhc3kgdG8gZG8gaW4gc2NyaXB0KSBieSBoYW5kLgo+IAo+IENoYW5nZWxv ZyB2My4xLXY0Ogo+IDEuIHJlbW92ZSBleHRyYSBmb3JrIHBvaW50ZWQgb3V0IGJ5Ogo+ICAgIEFu ZHJlaSBWYWdpbiA8YXZhZ2luQGdtYWlsLmNvbT4KPiAKPiBDaGFuZ2Vsb2cgdjMtdjMuMToKPiAx LiBTd2l0Y2ggInB3ZCIgb2YgcGlwZSBwcm9ncmFtIHRvIGNvbnRhaW5lcidzIHJvb3QgZnMuCj4g Mi4gUmViYXNlIG9uIHRvcCBvZiB2NC45LXJjMQo+IAo+IENoYW5nZWxvZyB2Mi0+djM6Cj4gMTog Rml4IHByb2JsZW0gb2Ygc2V0dGluZyBwaWQgbmFtZXNwYWNlLCBwb2ludGVkIG91dCBieToKPiAg ICBBbmRyZWkgVmFnaW4gPGF2YWdpbkBnbWFpbC5jb20+Cj4gCj4gQ2hhbmdlbG9nIHYxKFJGQykt PnYyOgo+IDE6IEFkZCBbUEFUQ0ggMi8yXSB3aGljaCB3YXMgdG9kbyBpbiBbUkZDIHYxXS4KPiAy OiBQYXNzIGEgdGVzdCBzY3JpcHQgZm9yIGVhY2ggZnVuY3Rpb24uCj4gMzogUmViYXNlIG9uIHRv cCBvZiB2NC43Lgo+IAo+IFN1Z2dlc3RlZC1ieTogRXJpYyBXLiBCaWVkZXJtYW4gPGViaWVkZXJt QHhtaXNzaW9uLmNvbT4KPiBTdWdnZXN0ZWQtYnk6IEtPU0FLSSBNb3RvaGlybyA8a29zYWtpLm1v dG9oaXJvQGpwLmZ1aml0c3UuY29tPgo+IFNpZ25lZC1vZmYtYnk6IFpoYW8gTGVpIDx6aGFvbGVp QGNuLmZ1aml0c3UuY29tPgo+IFNpZ25lZC1vZmYtYnk6IENhbyBTaHVmZW5nIDxjYW9zZi5mbnN0 QGNuLmZ1aml0c3UuY29tPgo+IAo+IENhbyBTaHVmZW5nICgyKToKPiAgIE1ha2UgY2FsbF91c2Vy bW9kZWhlbHBlcl9leGVjIHBvc3NpYmxlIHRvIHNldCBuYW1lc3BhY2VzCj4gICBMaW1pdCBkdW1w X3BpcGUgcHJvZ3JhbSdzIHBlcm1pc3Npb24gdG8gaW5pdCBmb3IgY29udGFpbmVyCj4gCj4gWmhh byBMZWkgKDEpOgo+ICAgTWFrZSBjb3JlX3BhdHRlcm4gc3VwcG9ydCBuYW1lc3BhY2UKPiAKPiAg ZnMvY29yZWR1bXAuYyAgICAgICAgICAgICAgICAgfCAxNTAgKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrLS0tCj4gIGluY2x1ZGUvbGludXgvYmluZm10cy5oICAgICAgIHwg ICAyICsKPiAgaW5jbHVkZS9saW51eC9rbW9kLmggICAgICAgICAgfCAgIDQgKysKPiAgaW5jbHVk ZS9saW51eC9waWRfbmFtZXNwYWNlLmggfCAgIDMgKwo+ICBpbml0L2RvX21vdW50c19pbml0cmQu YyAgICAgICB8ICAgMyArLQo+ICBrZXJuZWwva21vZC5jICAgICAgICAgICAgICAgICB8ICA0MyAr KysrKysrKystLS0KPiAga2VybmVsL3BpZC5jICAgICAgICAgICAgICAgICAgfCAgIDIgKwo+ICBr ZXJuZWwvcGlkX25hbWVzcGFjZS5jICAgICAgICB8ICAgMiArCj4gIGtlcm5lbC9zeXNjdGwuYyAg ICAgICAgICAgICAgIHwgIDUwICsrKysrKysrKysrKy0tCj4gIGxpYi9rb2JqZWN0X3VldmVudC5j ICAgICAgICAgIHwgICAzICstCj4gIHNlY3VyaXR5L2tleXMvcmVxdWVzdF9rZXkuYyAgIHwgICA0 ICstCj4gIDExIGZpbGVzIGNoYW5nZWQsIDI0MSBpbnNlcnRpb25zKCspLCAyNSBkZWxldGlvbnMo LSkKPiAKCi0tIApCZXN0IFJlZ2FyZHMsCkNhbyBTaHVmZW5nCi0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCkNhbyBTaHVmZW5nCkRldmVsb3BtZW50IERl cHQuSQpOYW5qaW5nIEZ1aml0c3UgTmFuZGEgU29mdHdhcmUgVGVjaC4gQ28uLCBMdGQuKEZOU1Qp Ck5vLjYgV2Vuemh1IFJvYWQsIE5hbmppbmcsIDIxMDAxMiwgQ2hpbmEgClRFTDogKzg2KzI1LTg2 NjMwNTY2LTg1NTIKRlVKSVRTVSBJTlRFUk5BTDogNzk5OC04NTUyCkVNYWlsOiBjYW9zZi5mbnN0 QGNuLmZ1aml0c3UuY29tCgoKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpDb250YWluZXJzIG1haWxpbmcgbGlzdApDb250YWluZXJzQGxpc3RzLmxpbnV4 LWZvdW5kYXRpb24ub3JnCmh0dHBzOi8vbGlzdHMubGludXhmb3VuZGF0aW9uLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2NvbnRhaW5lcnM= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752144AbcKIEF7 (ORCPT ); Tue, 8 Nov 2016 23:05:59 -0500 Received: from cn.fujitsu.com ([59.151.112.132]:27559 "EHLO heian.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1750967AbcKIEF4 (ORCPT ); Tue, 8 Nov 2016 23:05:56 -0500 X-IronPort-AV: E=Sophos;i="5.22,518,1449504000"; d="scan'208";a="12801843" Message-ID: <1478664373.27686.8.camel@cn.fujitsu.com> Subject: Re: [PATCH v4 0/3] Make core_pattern support namespace From: Cao =?gb2312?Q?Shufeng/=B2=DC=CA=F7=B7=E9?= To: CC: , , , , , , , Date: Wed, 9 Nov 2016 12:06:13 +0800 In-Reply-To: <1477380536-3307-1-git-send-email-caosf.fnst@cn.fujitsu.com> References: <1477380536-3307-1-git-send-email-caosf.fnst@cn.fujitsu.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.11 (3.12.11-1.fc21) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-yoursite-MailScanner-ID: C3C464670071.A7793 X-yoursite-MailScanner: Found to be clean X-yoursite-MailScanner-From: caosf.fnst@cn.fujitsu.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ping 在 2016-10-25二的 15:28 +0800，Cao Shufeng写道： > This patchset includes following function points: > 1: Let usermodehelper function possible to set pid namespace > done by: [PATCH v4 1/3] Make call_usermodehelper_exec possible > to set pid namespace. > 2: Let pipe_type core_pattern write dump into container's rootfs > done by: [PATCH v4 2/3] Limit dump_pipe program's permission to > init for container. > 2: Make separate core_pattern setting for each container > done by: [PATCH v4 3/3] Make core_pattern support namespace > 3: Compatibility with current system > also included in: [PATCH v4 3/3] Make core_pattern support namespace > If container hadn't change core_pattern setting, it will keep > same setting with host. > > Test: > 1: Pass a test script for each function of this patchset > ## TEST IN HOST ## > [root@kerneldev dumptest]# ./test_host > Set file core_pattern: OK > ./test_host: line 41: 2366 Segmentation fault (core dumped) "$SCRI= > PT_BASE_DIR"/make_dump > Checking dumpfile: OK > Set file core_pattern: OK > ./test_host: line 41: 2369 Segmentation fault (core dumped) "$SCRI= > PT_BASE_DIR"/make_dump > Checking dump_pipe triggered: OK > Checking rootfs: OK > Checking dumpfile: OK > Checking namespace: OK > Checking process list: OK > Checking capabilities: OK > > ## TEST IN GUEST ## > # ./test > Segmentation fault (core dumped) > Checking dump_pipe triggered: OK > Checking rootfs: OK > Checking dumpfile: OK > Checking namespace: OK > Checking process list: OK > Checking cg pids: OK > Checking capabilities: OK > [ 64.940734] make_dump[2432]: segfault at 0 ip 000000000040049d sp 000= > 07ffc4af025f0 error 6 in make_dump[400000+a6000] > # > 2: Pass other test(which is not easy to do in script) by hand. > > Changelog v3.1-v4: > 1. remove extra fork pointed out by: > Andrei Vagin > > Changelog v3-v3.1: > 1. Switch "pwd" of pipe program to container's root fs. > 2. Rebase on top of v4.9-rc1 > > Changelog v2->v3: > 1: Fix problem of setting pid namespace, pointed out by: > Andrei Vagin > > Changelog v1(RFC)->v2: > 1: Add [PATCH 2/2] which was todo in [RFC v1]. > 2: Pass a test script for each function. > 3: Rebase on top of v4.7. > > Suggested-by: Eric W. Biederman > Suggested-by: KOSAKI Motohiro > Signed-off-by: Zhao Lei > Signed-off-by: Cao Shufeng > > Cao Shufeng (2): > Make call_usermodehelper_exec possible to set namespaces > Limit dump_pipe program's permission to init for container > > Zhao Lei (1): > Make core_pattern support namespace > > fs/coredump.c | 150 +++++++++++++++++++++++++++++++++++++++--- > include/linux/binfmts.h | 2 + > include/linux/kmod.h | 4 ++ > include/linux/pid_namespace.h | 3 + > init/do_mounts_initrd.c | 3 +- > kernel/kmod.c | 43 +++++++++--- > kernel/pid.c | 2 + > kernel/pid_namespace.c | 2 + > kernel/sysctl.c | 50 ++++++++++++-- > lib/kobject_uevent.c | 3 +- > security/keys/request_key.c | 4 +- > 11 files changed, 241 insertions(+), 25 deletions(-) > -- Best Regards, Cao Shufeng -------------------------------------------------- Cao Shufeng Development Dept.I Nanjing Fujitsu Nanda Software Tech. Co., Ltd.(FNST) No.6 Wenzhu Road, Nanjing, 210012, China TEL: +86+25-86630566-8552 FUJITSU INTERNAL: 7998-8552 EMail: caosf.fnst@cn.fujitsu.com