From: "Cédric Le Goater" <clg@kaod.org>
To: openbmc@lists.ozlabs.org
Subject: [PATCH v2 linux dev-4.7 5/7] mtd: spi-nor: aspeed: use smc_read mode when doing DMAs
Date: Wed, 9 Nov 2016 09:15:41 +0100 [thread overview]
Message-ID: <1478679343-25354-6-git-send-email-clg@kaod.org> (raw)
In-Reply-To: <1478679343-25354-1-git-send-email-clg@kaod.org>
smc_base is to send commands. smc_read is for flash content accesses.
Signed-off-by: Cédric Le Goater <clg@kaod.org>
Reviewed-by: Joel Stanley <joel@jms.id.au>
---
drivers/mtd/spi-nor/aspeed-smc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mtd/spi-nor/aspeed-smc.c b/drivers/mtd/spi-nor/aspeed-smc.c
index 4839a26b387f..bbe505d5d8a3 100644
--- a/drivers/mtd/spi-nor/aspeed-smc.c
+++ b/drivers/mtd/spi-nor/aspeed-smc.c
@@ -405,7 +405,7 @@ static int aspeed_smc_dma_start(struct aspeed_smc_chip *chip,
int ret;
aspeed_smc_chip_configure(chip, is_write ? chip->ctl_val[smc_write] :
- chip->ctl_val[smc_base]);
+ chip->ctl_val[smc_read]);
dev_dbg(chip->nor.dev, "DMA %s to=0x%08x len=0x%08x\n",
is_write ? "write" : "read", offset, length);
@@ -446,7 +446,7 @@ static int aspeed_smc_dma_start(struct aspeed_smc_chip *chip,
controller->dma_addr, controller->dma_length,
(is_write ? DMA_TO_DEVICE : DMA_FROM_DEVICE));
out:
- aspeed_smc_chip_configure(chip, chip->ctl_val[smc_base]);
+ aspeed_smc_chip_configure(chip, chip->ctl_val[smc_read]);
return ret;
}
--
2.7.4
next prev parent reply other threads:[~2016-11-09 8:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-09 8:15 [PATCH v2 linux dev-4.7 0/7] Aspeed SMC improvements Cédric Le Goater
2016-11-09 8:15 ` [PATCH v2 linux dev-4.7 1/7] mtd: spi-nor: aspeed: fix setting of the register control value for writes Cédric Le Goater
2016-11-09 23:05 ` Joel Stanley
2016-11-09 8:15 ` [PATCH v2 linux dev-4.7 2/7] mtd: spi-nor: aspeed: improve 4 bytes mode Cédric Le Goater
2016-11-09 23:07 ` Joel Stanley
2016-11-09 8:15 ` [PATCH v2 linux dev-4.7 3/7] mtd: spi-nor: aspeed: extend the bits definitions Cédric Le Goater
2016-11-09 8:15 ` [PATCH v2 linux dev-4.7 4/7] mtd: spi-nor: aspeed: add some logging Cédric Le Goater
2016-11-09 8:15 ` Cédric Le Goater [this message]
2016-11-09 8:15 ` [PATCH v2 linux dev-4.7 6/7] mtd: spi-nor: aspeed: prepare for fast read Cédric Le Goater
2016-11-09 8:15 ` [PATCH v2 linux dev-4.7 7/7] mtd: spi-nor: aspeed: rework io routines Cédric Le Goater
2016-11-10 0:37 ` [PATCH v2 linux dev-4.7 0/7] Aspeed SMC improvements Joel Stanley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1478679343-25354-6-git-send-email-clg@kaod.org \
--to=clg@kaod.org \
--cc=openbmc@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.