All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oliver Neukum <oneukum@suse.com>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: bjorn@mork.no, Kai-Heng Feng <kai.heng.feng@canonical.com>,
	linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
	netdev@vger.kernel.org
Subject: Re: [PATCH] usbnet: prevent device rpm suspend in usbnet_probe function
Date: Wed, 09 Nov 2016 12:58:55 +0100	[thread overview]
Message-ID: <1478692735.2428.10.camel@suse.com> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1611081339060.1499-100000@iolanthe.rowland.org>

On Tue, 2016-11-08 at 13:44 -0500, Alan Stern wrote:

> These problems could very well be caused by running at SuperSpeed
> (USB-3) instead of high speed (USB-2).
> 
> Is there any way to test what happens when the device is attached to 
> the computer by a USB-2 cable?  That would prevent it from operating at 
> SuperSpeed.
> 
> The main point, however, is that the proposed patch doesn't seem to
> address the true problem, which is that the device gets suspended
> between probes.  The patch only tries to prevent it from being
> suspended during a probe -- which is already prevented by the USB core.

But why doesn't it fail during normal operation?

I suspect that its firmware requires the altsetting

        /* should we change control altsetting on a NCM/MBIM function? */
        if (cdc_ncm_select_altsetting(intf) == CDC_NCM_COMM_ALTSETTING_MBIM) {
                data_altsetting = CDC_NCM_DATA_ALTSETTING_MBIM;
                ret = cdc_mbim_set_ctrlalt(dev, intf, CDC_NCM_COMM_ALTSETTING_MBIM);

to be set before it accepts a suspension.

	Regards
		Oliver

  reply	other threads:[~2016-11-09 12:04 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-04  9:57 [PATCH] usbnet: prevent device rpm suspend in usbnet_probe function Kai-Heng Feng
2016-11-04  9:57 ` Kai-Heng Feng
2016-11-04 13:26 ` Alan Stern
2016-11-07 10:32   ` Oliver Neukum
2016-11-07 11:02 ` Oliver Neukum
2016-11-08  7:46   ` Kai-Heng Feng
2016-11-08 15:25     ` Alan Stern
2016-11-08 16:49       ` Bjørn Mork
2016-11-08 18:44         ` Alan Stern
2016-11-09 11:58           ` Oliver Neukum [this message]
2016-11-09 12:32             ` Bjørn Mork
2016-11-10  4:06               ` Kai-Heng Feng
2016-11-10 11:09                 ` Bjørn Mork
2016-11-10 11:22                   ` Oliver Neukum
2016-11-11 14:44                     ` Mathias Nyman
2016-11-14  7:34                       ` Kai-Heng Feng
2016-11-14  7:34                         ` Kai-Heng Feng
2016-11-16 10:29                         ` Kai-Heng Feng
2016-11-10 15:36                 ` Alan Stern
2016-11-10 20:38                   ` Bjørn Mork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1478692735.2428.10.camel@suse.com \
    --to=oneukum@suse.com \
    --cc=bjorn@mork.no \
    --cc=kai.heng.feng@canonical.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.