From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53210) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c4TFt-0001Lm-Cn for qemu-devel@nongnu.org; Wed, 09 Nov 2016 08:49:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c4TFo-0004W6-Iv for qemu-devel@nongnu.org; Wed, 09 Nov 2016 08:49:33 -0500 Received: from mx1.redhat.com ([209.132.183.28]:59446) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c4TFo-0004Vs-D9 for qemu-devel@nongnu.org; Wed, 09 Nov 2016 08:49:28 -0500 Message-ID: <1478699362.2078.73.camel@redhat.com> From: Gerd Hoffmann Date: Wed, 09 Nov 2016 14:49:22 +0100 In-Reply-To: <20161028145132.1702-1-peter@korsgaard.com> References: <20161028145132.1702-1-peter@korsgaard.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] hw/input/hid: support alternative sysrq/break scancodes for gtk-vnc List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Korsgaard Cc: berrange@redhat.com, qemu-devel@nongnu.org Hi, > Now, it isn't obvious to me which sequence is really "right", but as the > 0x54/0xc6 keycodes are currently unused in hid.c, supporting both seems l= ike > the pragmatic solution to me. The USB HID keyboard boot protocol used by > hid.c doesn't have any other mapping applicable to these keys. >=20 > The other guest keyboard interfaces (ps/2, virtio, ..) are not affected, > because they handle these keys differently. A better fix would be to switch hid.c to use Q_KEY_CODE_* too. Patches doing that are welcome. It's a big change though and not reasonable to do during the freeze, so I'll go pick up this two-line fix for 2.8 nevertheless. thanks, Gerd