diff for duplicates of <1478704129.15658.1.camel@primarydata.com> diff --git a/a/1.txt b/N1/1.txt index 5dd0233..f38a4ec 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,35 +1,71 @@ -T24gV2VkLCAyMDE2LTExLTA5IGF0IDA4OjE4IC0wNTAwLCBKZWZmIExheXRvbiB3cm90ZToNCj4g -T24gVHVlLCAyMDE2LTExLTA4IGF0IDIwOjI3IC0wNTAwLCBKLiBCcnVjZSBGaWVsZHMgd3JvdGU6 -DQo+ID4gDQo+ID4gT24gVHVlLCBOb3YgMDgsIDIwMTYgYXQgMDU6NTI6MjFQTSAtMDUwMCwgVGVq -dW4gSGVvIHdyb3RlOg0KPiA+ID4gDQo+ID4gPiANCj4gPiA+IEhlbGxvLCBCcnVjZS4NCj4gPiA+ -IA0KPiA+ID4gT24gVHVlLCBOb3YgMDgsIDIwMTYgYXQgMDQ6Mzk6MTFQTSAtMDUwMCwgSi4gQnJ1 -Y2UgRmllbGRzIHdyb3RlOg0KPiA+ID4gPiANCj4gPiA+ID4gDQo+ID4gPiA+IEFwb2xvZ2llcywg -anVzdCBjbGVhbmluZyBvdXQgb2xkIG1haWwgYW5kIGZpbmRpbmcgc29tZSBJIHNob3VsZA0KPiA+ -ID4gPiBoYXZlDQo+ID4gPiA+IHJlc3BvbmRlZCB0byBsb25nIGFnbzoNCj4gPiA+ID4gDQo+ID4g -PiA+IE9uIFdlZCwgQXVnIDMxLCAyMDE2IGF0IDAyOjIzOjQ4QU0gKzA1MzAsIEJoYWt0aXByaXlh -IFNocmlkaGFyDQo+ID4gPiA+IHdyb3RlOg0KPiA+ID4gPiA+IA0KPiA+ID4gPiA+IA0KPiA+ID4g -PiA+IFRoZSB3b3JrcXVldWUgImNhbGxiYWNrX3dxIiBxdWV1ZXMgYSBzaW5nbGUgd29yayBpdGVt -ICZjYi0NCj4gPiA+ID4gPiA+Y2Jfd29yayBwZXINCj4gPiA+ID4gPiBuZnNkNF9jYWxsYmFjayBp -bnN0YW5jZSBhbmQgdGh1cywgaXQgZG9lc24ndCByZXF1aXJlDQo+ID4gPiA+ID4gZXhlY3V0aW9u -IG9yZGVyaW5nLg0KPiA+ID4gPiANCj4gPiA+ID4gV2hhdCdzICJleGVjdXRpb24gb3JkZXJpbmci -Pw0KPiA+ID4gPiANCj4gDQo+IEFJVUksIGl0IG1lYW5zIHRoYXQgam9icyBhcmUgYWx3YXlzIHJ1 -biBpbiB0aGUgb3JkZXIgcXVldWVkIGFuZCBhcmUNCj4gc2VyaWFsaXplZC4NCj4gDQo+ID4gDQo+ -ID4gPiANCj4gPiA+ID4gDQo+ID4gPiA+IFdlIGRlZmluaXRlbHkgZG8gZGVwZW5kIG9uIHRoZSBm -YWN0IHRoYXQgYXQgbW9zdCBvbmUgb2YgdGhlc2UNCj4gPiA+ID4gaXMgcnVubmluZw0KPiA+ID4g -PiBhdCBhIHRpbWUuDQo+ID4gPiANCj4gDQo+IFdlIGRvPw0KPiANCj4gPiANCj4gPiA+IA0KPiA+ -ID4gSWYgdGhlcmUgY2FuIGJlIG11bHRpcGxlIGNiJ3MgYW5kIHRodXMgY2ItPmNiX3dvcmsncyBw -ZXINCj4gPiA+IGNhbGxiYWNrX3dxLA0KPiA+ID4gaXQnZCBuZWVkIGV4cGxpY2l0IG9yZGVyaW5n -LsKgwqBJcyB0aGF0IHRoZSBjYXNlPw0KPiA+IA0KPiANCj4gVGhlc2UgYXJlIGJhc2ljYWxseSBj -bGllbnQgUlBDIHRhc2tzLCBhbmQgdGhlIGNiX3dvcmsganVzdCBoYW5kbGVzDQo+IHRoZQ0KPiBz -dWJtaXNzaW9uIGludG8gdGhlIGNsaWVudCBSUEMgc3RhdGUgbWFjaGluZS4gSnVzdCBiZWNhdXNl -IHdlJ3JlDQo+IHJ1bm5pbmcNCj4gc2V2ZXJhbCBjYWxsYmFja3MgYXQgdGhlIHNhbWUgdGltZSBk -b2Vzbid0IG1lYW4gdGhhdCB0aGV5IG5lZWQgdG8gYmUNCj4gc3RyaWN0bHkgb3JkZXJlZC4gVGhl -IGNsaWVudCBzdGF0ZSBtYWNoaW5lIGNhbiBjZXJ0YWlubHkgaGFuZGxlDQo+IHJ1bm5pbmcNCj4g -dGhlc2UgaW4gcGFyYWxsZWwuDQo+IA0KPiA+IA0KPiA+IFllcywgdGhlcmUgY2FuIGJlIG11bHRp -cGxlIGNiX3dvcmsncy4NCj4gPiANCj4gDQo+IFllcywgYnV0IGVhY2ggaXMgZWZmZWN0aXZlbHkg -YSBzZXBhcmF0ZSB3b3JrIHVuaXQuIEkgc2VlIG5vIHJlYXNvbg0KPiB3aHkNCj4gd2UnZCBuZWVk -IHRvIG9yZGVyIHRoZW0gYXQgYWxsLg0KPiANCg0KVGhlcmUgbmVlZHMgdG8gYmUgc2VyaWFsaXNh -dGlvbiBhdCB0aGUgc2Vzc2lvbiBsZXZlbCAoaS5lLiB0aGUNCmNhbGxiYWNrcyBoYXZlIHRvIHJl -c3BlY3QgdGhlIHNsb3QgbGltaXRzIHNldCBieSB0aGUgY2xpZW50KSBob3dldmVyDQp0aGVyZSBz -aG91bGRu4oCZdCBiZSBhIG5lZWQgZm9yIHNlcmlhbGlzYXRpb24gYXQgdGhlIFJQQyBsZXZlbC4N -Cg0KQ2hlZXJzDQrCoCBUcm9uZA== +On Wed, 2016-11-09 at 08:18 -0500, Jeff Layton wrote: +> On Tue, 2016-11-08 at 20:27 -0500, J. Bruce Fields wrote: +> > +> > On Tue, Nov 08, 2016 at 05:52:21PM -0500, Tejun Heo wrote: +> > > +> > > +> > > Hello, Bruce. +> > > +> > > On Tue, Nov 08, 2016 at 04:39:11PM -0500, J. Bruce Fields wrote: +> > > > +> > > > +> > > > Apologies, just cleaning out old mail and finding some I should +> > > > have +> > > > responded to long ago: +> > > > +> > > > On Wed, Aug 31, 2016 at 02:23:48AM +0530, Bhaktipriya Shridhar +> > > > wrote: +> > > > > +> > > > > +> > > > > The workqueue "callback_wq" queues a single work item &cb- +> > > > > >cb_work per +> > > > > nfsd4_callback instance and thus, it doesn't require +> > > > > execution ordering. +> > > > +> > > > What's "execution ordering"? +> > > > +> +> AIUI, it means that jobs are always run in the order queued and are +> serialized. +> +> > +> > > +> > > > +> > > > We definitely do depend on the fact that at most one of these +> > > > is running +> > > > at a time. +> > > +> +> We do? +> +> > +> > > +> > > If there can be multiple cb's and thus cb->cb_work's per +> > > callback_wq, +> > > it'd need explicit ordering. Is that the case? +> > +> +> These are basically client RPC tasks, and the cb_work just handles +> the +> submission into the client RPC state machine. Just because we're +> running +> several callbacks at the same time doesn't mean that they need to be +> strictly ordered. The client state machine can certainly handle +> running +> these in parallel. +> +> > +> > Yes, there can be multiple cb_work's. +> > +> +> Yes, but each is effectively a separate work unit. I see no reason +> why +> we'd need to order them at all. +> + +There needs to be serialisation at the session level (i.e. the +callbacks have to respect the slot limits set by the client) however +there shouldn’t be a need for serialisation at the RPC level. + +Cheers + Trond diff --git a/a/content_digest b/N1/content_digest index ae097ec..ed57cd9 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -14,40 +14,76 @@ " linux-nfs@vger.kernel.org <linux-nfs@vger.kernel.org>\0" "\00:1\0" "b\0" - "T24gV2VkLCAyMDE2LTExLTA5IGF0IDA4OjE4IC0wNTAwLCBKZWZmIExheXRvbiB3cm90ZToNCj4g\n" - "T24gVHVlLCAyMDE2LTExLTA4IGF0IDIwOjI3IC0wNTAwLCBKLiBCcnVjZSBGaWVsZHMgd3JvdGU6\n" - "DQo+ID4gDQo+ID4gT24gVHVlLCBOb3YgMDgsIDIwMTYgYXQgMDU6NTI6MjFQTSAtMDUwMCwgVGVq\n" - "dW4gSGVvIHdyb3RlOg0KPiA+ID4gDQo+ID4gPiANCj4gPiA+IEhlbGxvLCBCcnVjZS4NCj4gPiA+\n" - "IA0KPiA+ID4gT24gVHVlLCBOb3YgMDgsIDIwMTYgYXQgMDQ6Mzk6MTFQTSAtMDUwMCwgSi4gQnJ1\n" - "Y2UgRmllbGRzIHdyb3RlOg0KPiA+ID4gPiANCj4gPiA+ID4gDQo+ID4gPiA+IEFwb2xvZ2llcywg\n" - "anVzdCBjbGVhbmluZyBvdXQgb2xkIG1haWwgYW5kIGZpbmRpbmcgc29tZSBJIHNob3VsZA0KPiA+\n" - "ID4gPiBoYXZlDQo+ID4gPiA+IHJlc3BvbmRlZCB0byBsb25nIGFnbzoNCj4gPiA+ID4gDQo+ID4g\n" - "PiA+IE9uIFdlZCwgQXVnIDMxLCAyMDE2IGF0IDAyOjIzOjQ4QU0gKzA1MzAsIEJoYWt0aXByaXlh\n" - "IFNocmlkaGFyDQo+ID4gPiA+IHdyb3RlOg0KPiA+ID4gPiA+IA0KPiA+ID4gPiA+IA0KPiA+ID4g\n" - "PiA+IFRoZSB3b3JrcXVldWUgImNhbGxiYWNrX3dxIiBxdWV1ZXMgYSBzaW5nbGUgd29yayBpdGVt\n" - "ICZjYi0NCj4gPiA+ID4gPiA+Y2Jfd29yayBwZXINCj4gPiA+ID4gPiBuZnNkNF9jYWxsYmFjayBp\n" - "bnN0YW5jZSBhbmQgdGh1cywgaXQgZG9lc24ndCByZXF1aXJlDQo+ID4gPiA+ID4gZXhlY3V0aW9u\n" - "IG9yZGVyaW5nLg0KPiA+ID4gPiANCj4gPiA+ID4gV2hhdCdzICJleGVjdXRpb24gb3JkZXJpbmci\n" - "Pw0KPiA+ID4gPiANCj4gDQo+IEFJVUksIGl0IG1lYW5zIHRoYXQgam9icyBhcmUgYWx3YXlzIHJ1\n" - "biBpbiB0aGUgb3JkZXIgcXVldWVkIGFuZCBhcmUNCj4gc2VyaWFsaXplZC4NCj4gDQo+ID4gDQo+\n" - "ID4gPiANCj4gPiA+ID4gDQo+ID4gPiA+IFdlIGRlZmluaXRlbHkgZG8gZGVwZW5kIG9uIHRoZSBm\n" - "YWN0IHRoYXQgYXQgbW9zdCBvbmUgb2YgdGhlc2UNCj4gPiA+ID4gaXMgcnVubmluZw0KPiA+ID4g\n" - "PiBhdCBhIHRpbWUuDQo+ID4gPiANCj4gDQo+IFdlIGRvPw0KPiANCj4gPiANCj4gPiA+IA0KPiA+\n" - "ID4gSWYgdGhlcmUgY2FuIGJlIG11bHRpcGxlIGNiJ3MgYW5kIHRodXMgY2ItPmNiX3dvcmsncyBw\n" - "ZXINCj4gPiA+IGNhbGxiYWNrX3dxLA0KPiA+ID4gaXQnZCBuZWVkIGV4cGxpY2l0IG9yZGVyaW5n\n" - "LsKgwqBJcyB0aGF0IHRoZSBjYXNlPw0KPiA+IA0KPiANCj4gVGhlc2UgYXJlIGJhc2ljYWxseSBj\n" - "bGllbnQgUlBDIHRhc2tzLCBhbmQgdGhlIGNiX3dvcmsganVzdCBoYW5kbGVzDQo+IHRoZQ0KPiBz\n" - "dWJtaXNzaW9uIGludG8gdGhlIGNsaWVudCBSUEMgc3RhdGUgbWFjaGluZS4gSnVzdCBiZWNhdXNl\n" - "IHdlJ3JlDQo+IHJ1bm5pbmcNCj4gc2V2ZXJhbCBjYWxsYmFja3MgYXQgdGhlIHNhbWUgdGltZSBk\n" - "b2Vzbid0IG1lYW4gdGhhdCB0aGV5IG5lZWQgdG8gYmUNCj4gc3RyaWN0bHkgb3JkZXJlZC4gVGhl\n" - "IGNsaWVudCBzdGF0ZSBtYWNoaW5lIGNhbiBjZXJ0YWlubHkgaGFuZGxlDQo+IHJ1bm5pbmcNCj4g\n" - "dGhlc2UgaW4gcGFyYWxsZWwuDQo+IA0KPiA+IA0KPiA+IFllcywgdGhlcmUgY2FuIGJlIG11bHRp\n" - "cGxlIGNiX3dvcmsncy4NCj4gPiANCj4gDQo+IFllcywgYnV0IGVhY2ggaXMgZWZmZWN0aXZlbHkg\n" - "YSBzZXBhcmF0ZSB3b3JrIHVuaXQuIEkgc2VlIG5vIHJlYXNvbg0KPiB3aHkNCj4gd2UnZCBuZWVk\n" - "IHRvIG9yZGVyIHRoZW0gYXQgYWxsLg0KPiANCg0KVGhlcmUgbmVlZHMgdG8gYmUgc2VyaWFsaXNh\n" - "dGlvbiBhdCB0aGUgc2Vzc2lvbiBsZXZlbCAoaS5lLiB0aGUNCmNhbGxiYWNrcyBoYXZlIHRvIHJl\n" - "c3BlY3QgdGhlIHNsb3QgbGltaXRzIHNldCBieSB0aGUgY2xpZW50KSBob3dldmVyDQp0aGVyZSBz\n" - "aG91bGRu4oCZdCBiZSBhIG5lZWQgZm9yIHNlcmlhbGlzYXRpb24gYXQgdGhlIFJQQyBsZXZlbC4N\n" - Cg0KQ2hlZXJzDQrCoCBUcm9uZA== + "On Wed, 2016-11-09 at 08:18 -0500, Jeff Layton wrote:\n" + "> On Tue, 2016-11-08 at 20:27 -0500, J. Bruce Fields wrote:\n" + "> > \n" + "> > On Tue, Nov 08, 2016 at 05:52:21PM -0500, Tejun Heo wrote:\n" + "> > > \n" + "> > > \n" + "> > > Hello, Bruce.\n" + "> > > \n" + "> > > On Tue, Nov 08, 2016 at 04:39:11PM -0500, J. Bruce Fields wrote:\n" + "> > > > \n" + "> > > > \n" + "> > > > Apologies, just cleaning out old mail and finding some I should\n" + "> > > > have\n" + "> > > > responded to long ago:\n" + "> > > > \n" + "> > > > On Wed, Aug 31, 2016 at 02:23:48AM +0530, Bhaktipriya Shridhar\n" + "> > > > wrote:\n" + "> > > > > \n" + "> > > > > \n" + "> > > > > The workqueue \"callback_wq\" queues a single work item &cb-\n" + "> > > > > >cb_work per\n" + "> > > > > nfsd4_callback instance and thus, it doesn't require\n" + "> > > > > execution ordering.\n" + "> > > > \n" + "> > > > What's \"execution ordering\"?\n" + "> > > > \n" + "> \n" + "> AIUI, it means that jobs are always run in the order queued and are\n" + "> serialized.\n" + "> \n" + "> > \n" + "> > > \n" + "> > > > \n" + "> > > > We definitely do depend on the fact that at most one of these\n" + "> > > > is running\n" + "> > > > at a time.\n" + "> > > \n" + "> \n" + "> We do?\n" + "> \n" + "> > \n" + "> > > \n" + "> > > If there can be multiple cb's and thus cb->cb_work's per\n" + "> > > callback_wq,\n" + "> > > it'd need explicit ordering.\302\240\302\240Is that the case?\n" + "> > \n" + "> \n" + "> These are basically client RPC tasks, and the cb_work just handles\n" + "> the\n" + "> submission into the client RPC state machine. Just because we're\n" + "> running\n" + "> several callbacks at the same time doesn't mean that they need to be\n" + "> strictly ordered. The client state machine can certainly handle\n" + "> running\n" + "> these in parallel.\n" + "> \n" + "> > \n" + "> > Yes, there can be multiple cb_work's.\n" + "> > \n" + "> \n" + "> Yes, but each is effectively a separate work unit. I see no reason\n" + "> why\n" + "> we'd need to order them at all.\n" + "> \n" + "\n" + "There needs to be serialisation at the session level (i.e. the\n" + "callbacks have to respect the slot limits set by the client) however\n" + "there shouldn\342\200\231t be a need for serialisation at the RPC level.\n" + "\n" + "Cheers\n" + "\302\240 Trond" -0301d3d34751690b74fcb9150b2bc1f18e2a1e975fdd1410e1b03e016644c41a +bed231aadcf80e90b7447625926c82d99d7907bae35a1c2038e1cb6dbd207e2d
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.