All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cedric Bosdonnat <cbosdonnat@suse.com>
To: Juergen Gross <jgross@suse.com>, xen-devel@lists.xen.org
Cc: Samuel Thibault <samuel.thibault@ens-lyon.org>,
	Wei Liu <wei.liu2@citrix.com>
Subject: Re: [PATCH] Fix misleading indentation warnings
Date: Thu, 10 Nov 2016 10:25:05 +0100	[thread overview]
Message-ID: <1478769905.3120.2.camel@suse.com> (raw)
In-Reply-To: <73bc12cc-b50d-c045-7767-da5070b42747@suse.com>

Hi Juergen,

Just resent the patch with the missing Signed-off-By and --cc-cmd './scripts/get_maintainers.pl'

--
Cedric

On Thu, 2016-11-10 at 09:42 +0100, Juergen Gross wrote:
> On 10/11/16 09:37, Cédric Bosdonnat wrote:
> > Gcc6 build reports misleading indentation as warnings. Fix a few
> > warnings in stubdom.
> 
> You should CC: the maintainers. Calling
> 
> ./scripts/get_maintainer.pl <patchfile>
> 
> will show them. Added them for now.
> 
> 
> Juergen
> 
> > ---
> >  stubdom/vtpmmgr/disk_read.c | 8 ++++----
> >  stubdom/vtpmmgr/log.c       | 2 +-
> >  2 files changed, 5 insertions(+), 5 deletions(-)
> > 
> > diff --git a/stubdom/vtpmmgr/disk_read.c b/stubdom/vtpmmgr/disk_read.c
> > index 944d3ff..48cfbfe 100644
> > --- a/stubdom/vtpmmgr/disk_read.c
> > +++ b/stubdom/vtpmmgr/disk_read.c
> > @@ -123,10 +123,10 @@ static int parse_root_key(struct mem_tpm_mgr *dst, struct disk_seal_entry *src)
> >  	struct disk_root_sealed_data sealed;
> >  
> >      /*TPM 2.0 unbind | TPM 1.x unseal*/
> > -    if (hw_is_tpm2())
> > -        rc = TPM2_disk_unbind(&sealed, &olen, src);
> > -    else
> > -        rc = TPM_disk_unseal(&sealed, sizeof(sealed), src);
> > +	if (hw_is_tpm2())
> > +		rc = TPM2_disk_unbind(&sealed, &olen, src);
> > +	else
> > +		rc = TPM_disk_unseal(&sealed, sizeof(sealed), src);
> >  
> >  	if (rc)
> >  		return rc;
> > diff --git a/stubdom/vtpmmgr/log.c b/stubdom/vtpmmgr/log.c
> > index a82c913..c1bc8f3 100644
> > --- a/stubdom/vtpmmgr/log.c
> > +++ b/stubdom/vtpmmgr/log.c
> > @@ -147,5 +147,5 @@ const char* tpm_get_error_name (TPM_RESULT code) {
> >      if (code == error_msgs[i].code)
> >        return error_msgs[i].code_name;
> >  
> > -    return("Unknown Error Code");
> > +  return("Unknown Error Code");
> >  }
> > 
> 
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  reply	other threads:[~2016-11-10  9:25 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-10  8:37 [PATCH] Fix misleading indentation warnings Cédric Bosdonnat
2016-11-10  8:42 ` Juergen Gross
2016-11-10  9:25   ` Cedric Bosdonnat [this message]
  -- strict thread matches above, loose matches on Subject: below --
2016-11-10  9:23 Cédric Bosdonnat
2016-11-10 15:25 ` Daniel De Graaf
2016-11-11  0:16   ` Xuquan (Quan Xu)
2016-11-11  2:05 ` Wei Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1478769905.3120.2.camel@suse.com \
    --to=cbosdonnat@suse.com \
    --cc=jgross@suse.com \
    --cc=samuel.thibault@ens-lyon.org \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.