From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexey.Brodkin@synopsys.com (Alexey Brodkin) Date: Thu, 10 Nov 2016 11:06:40 +0000 Subject: [PATCH v2] drm/arcpgu: Accommodate adv7511 switch to DRM bridge In-Reply-To: <1478089382.2710.20.camel@synopsys.com> References: <1476863178-15237-1-git-send-email-Eugeniy.Paltsev@synopsys.com> <26a8cad6-118f-146f-f6ea-e9d539fc40a1@codeaurora.org> <1476869529.3348.27.camel@synopsys.com> <4881796E12491D4BB15146FE0209CE646784BA6F@DE02WEMBXB.internal.synopsys.com> <1478089382.2710.20.camel@synopsys.com> List-ID: Message-ID: <1478775952.2536.27.camel@synopsys.com> To: linux-snps-arc@lists.infradead.org Hi Daniel, David, On Wed, 2016-11-02@12:23 +0000, Alexey Brodkin wrote: > Hi Daniel, David, > > On Mon, 2016-10-24@18:33 +0000, Alexey Brodkin wrote: > > > > Hi Daniel, > > > > > > > > > > > -----Original Message----- > > > From: linux-snps-arc [mailto:linux-snps-arc-bounces at lists.infradead.org] On Behalf Of Alexey Brodkin > > > Sent: 19 ??????? 2016 ?. 12:33 > > > To: dri-devel at lists.freedesktop.org; architt at codeaurora.org; Eugeniy.Paltsev at synopsys.com > > > Cc: linux-snps-arc at lists.infradead.org; linux-kernel at vger.kernel.org > > > Subject: Re: [PATCH v2] drm/arcpgu: Accommodate adv7511 switch to DRM bridge > > > > > > Hi Archit, all, > > > > > > On Wed, 2016-10-19@14:43 +0530, Archit Taneja wrote: > > > > > > > > > > > > > > > > On 10/19/2016 01:16 PM, Eugeniy Paltsev wrote: > > > > > > > > > > > > > > > > > > > > ARC PGU driver starts crashing on initialization after > > > > > 'commit e12c2f645557 ("drm/i2c: adv7511: Convert to drm_bridge")' > > > > > This happenes because in "arcpgu_drm_hdmi_init" function we get pointer > > > > > of "drm_i2c_encoder_driver" structure, which doesn't exist after > > > > > adv7511 hdmi encoder interface changed from slave encoder to drm bridge. > > > > > So, when we call "encoder_init" function from this structure driver > > > > > crashes. > > > > > > [snip] > > > > > > > > > > > > > > > Looks good now. > > > > > > > > Reviewed-by: Archit Taneja > > > > > > And IMHO it would be really good to get this one back-ported to 4.8 > > > because it really fixes kernel crash if ARC PGU driver is used. > > > > > > It might be a bit of a problem because patch itself a little-bit larger > > > than formal requirement for stable backports but let's see if it gets accepted. > > > > Could you please pick this one up? > > I may alternatively send a pull-request to David but not sure if 1 patch worth it. > > > > Also if that's not really too late it would be good to get this one in 4.9 since the patch > > In question fixes a real driver crash on its instantiation. > > Actually driver crash happens since 4.8 but I failed to notice it earlier and given amount > > of changes I think there's barely a chance for it it to be accepted in stable branches... > > which in its turn makes at least 4.9 very desirable. > > Any chance this one gets accepted anytime soon? Please treat this as another polite reminder to apply this patch. If you prefer I may send a pull-request otherwise. Regards, Alexey From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexey Brodkin Subject: Re: [PATCH v2] drm/arcpgu: Accommodate adv7511 switch to DRM bridge Date: Thu, 10 Nov 2016 11:06:40 +0000 Message-ID: <1478775952.2536.27.camel@synopsys.com> References: <1476863178-15237-1-git-send-email-Eugeniy.Paltsev@synopsys.com> <26a8cad6-118f-146f-f6ea-e9d539fc40a1@codeaurora.org> <1476869529.3348.27.camel@synopsys.com> <4881796E12491D4BB15146FE0209CE646784BA6F@DE02WEMBXB.internal.synopsys.com> <1478089382.2710.20.camel@synopsys.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1478089382.2710.20.camel@synopsys.com> Content-Language: en-US Content-ID: Sender: linux-kernel-owner@vger.kernel.org To: "airlied@redhat.com" , "daniel.vetter@ffwll.ch" Cc: "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , "architt@codeaurora.org" , "Ramiro.Oliveira@synopsys.com" , "Eugeniy.Paltsev@synopsys.com" , "airlied@linux.ie" , "linux-snps-arc@lists.infradead.org" List-Id: dri-devel@lists.freedesktop.org SGkgRGFuaWVsLCBEYXZpZCwNCg0KT24gV2VkLCAyMDE2LTExLTAyIGF0IDEyOjIzICswMDAwLCBB bGV4ZXkgQnJvZGtpbiB3cm90ZToNCj4gSGkgRGFuaWVsLCBEYXZpZCwNCj4gDQo+IE9uIE1vbiwg MjAxNi0xMC0yNCBhdCAxODozMyArMDAwMCwgQWxleGV5IEJyb2RraW4gd3JvdGU6DQo+ID4gDQo+ ID4gSGkgRGFuaWVsLA0KPiA+IA0KPiA+ID4gDQo+ID4gPiANCj4gPiA+IC0tLS0tT3JpZ2luYWwg TWVzc2FnZS0tLS0tDQo+ID4gPiBGcm9tOiBsaW51eC1zbnBzLWFyYyBbbWFpbHRvOmxpbnV4LXNu cHMtYXJjLWJvdW5jZXNAbGlzdHMuaW5mcmFkZWFkLm9yZ10gT24gQmVoYWxmIE9mIEFsZXhleSBC cm9ka2luDQo+ID4gPiBTZW50OiAxOSDQvtC60YLRj9Cx0YDRjyAyMDE2INCzLiAxMjozMw0KPiA+ ID4gVG86IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmc7IGFyY2hpdHRAY29kZWF1cm9y YS5vcmc7IEV1Z2VuaXkuUGFsdHNldkBzeW5vcHN5cy5jb20NCj4gPiA+IENjOiBsaW51eC1zbnBz LWFyY0BsaXN0cy5pbmZyYWRlYWQub3JnOyBsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnDQo+ ID4gPiBTdWJqZWN0OiBSZTogW1BBVENIIHYyXSBkcm0vYXJjcGd1OiBBY2NvbW1vZGF0ZSBhZHY3 NTExIHN3aXRjaCB0byBEUk0gYnJpZGdlDQo+ID4gPiANCj4gPiA+IEhpIEFyY2hpdCwgYWxsLA0K PiA+ID4gDQo+ID4gPiBPbiBXZWQsIDIwMTYtMTAtMTkgYXQgMTQ6NDMgKzA1MzAsIEFyY2hpdCBU YW5lamEgd3JvdGU6DQo+ID4gPiA+IA0KPiA+ID4gPiANCj4gPiA+ID4gDQo+ID4gPiA+IE9uIDEw LzE5LzIwMTYgMDE6MTYgUE0sIEV1Z2VuaXkgUGFsdHNldiB3cm90ZToNCj4gPiA+ID4gPiANCj4g PiA+ID4gPiANCj4gPiA+ID4gPiANCj4gPiA+ID4gPiBBUkMgUEdVIGRyaXZlciBzdGFydHMgY3Jh c2hpbmcgb24gaW5pdGlhbGl6YXRpb24gYWZ0ZXINCj4gPiA+ID4gPiAnY29tbWl0IGUxMmMyZjY0 NTU1NyAoImRybS9pMmM6IGFkdjc1MTE6IENvbnZlcnQgdG8gZHJtX2JyaWRnZSIpJw0KPiA+ID4g PiA+IFRoaXMgaGFwcGVuZXMgYmVjYXVzZSBpbiAiYXJjcGd1X2RybV9oZG1pX2luaXQiIGZ1bmN0 aW9uIHdlIGdldCBwb2ludGVyDQo+ID4gPiA+ID4gb2YgImRybV9pMmNfZW5jb2Rlcl9kcml2ZXIi IHN0cnVjdHVyZSwgd2hpY2ggZG9lc24ndCBleGlzdCBhZnRlcg0KPiA+ID4gPiA+IGFkdjc1MTEg aGRtaSBlbmNvZGVyIGludGVyZmFjZSBjaGFuZ2VkIGZyb20gc2xhdmUgZW5jb2RlciB0byBkcm0g YnJpZGdlLg0KPiA+ID4gPiA+IFNvLCB3aGVuIHdlIGNhbGwgImVuY29kZXJfaW5pdCIgZnVuY3Rp b24gZnJvbSB0aGlzIHN0cnVjdHVyZSBkcml2ZXINCj4gPiA+ID4gPiBjcmFzaGVzLg0KPiA+ID4g DQo+ID4gPiBbc25pcF0NCj4gPiA+IA0KPiA+ID4gPiANCj4gPiA+ID4gDQo+ID4gPiA+IExvb2tz IGdvb2Qgbm93Lg0KPiA+ID4gPiANCj4gPiA+ID4gUmV2aWV3ZWQtYnk6IEFyY2hpdCBUYW5lamEg PGFyY2hpdHRAY29kZWF1cm9yYS5vcmc+DQo+ID4gPiANCj4gPiA+IEFuZCBJTUhPIGl0IHdvdWxk IGJlIHJlYWxseSBnb29kIHRvIGdldCB0aGlzIG9uZSBiYWNrLXBvcnRlZCB0byA0LjgNCj4gPiA+ IGJlY2F1c2UgaXQgcmVhbGx5IGZpeGVzIGtlcm5lbCBjcmFzaCBpZiBBUkMgUEdVIGRyaXZlciBp cyB1c2VkLg0KPiA+ID4gDQo+ID4gPiBJdCBtaWdodCBiZSBhIGJpdCBvZiBhIHByb2JsZW0gYmVj YXVzZSBwYXRjaCBpdHNlbGYgYSBsaXR0bGUtYml0IGxhcmdlcg0KPiA+ID4gdGhhbiBmb3JtYWwg cmVxdWlyZW1lbnQgZm9yIHN0YWJsZSBiYWNrcG9ydHMgYnV0IGxldCdzIHNlZSBpZiBpdCBnZXRz IGFjY2VwdGVkLg0KPiA+IA0KPiA+IENvdWxkIHlvdSBwbGVhc2UgcGljayB0aGlzIG9uZSB1cD8N Cj4gPiBJIG1heSBhbHRlcm5hdGl2ZWx5IHNlbmQgYSBwdWxsLXJlcXVlc3QgdG8gRGF2aWQgYnV0 IG5vdCBzdXJlIGlmIDEgcGF0Y2ggd29ydGggaXQuDQo+ID4gDQo+ID4gQWxzbyBpZiB0aGF0J3Mg bm90IHJlYWxseSB0b28gbGF0ZSBpdCB3b3VsZCBiZSBnb29kIHRvIGdldCB0aGlzIG9uZSBpbiA0 Ljkgc2luY2UgdGhlIHBhdGNoDQo+ID4gSW4gcXVlc3Rpb24gZml4ZXMgYSByZWFsIGRyaXZlciBj cmFzaCBvbiBpdHMgaW5zdGFudGlhdGlvbi4NCj4gPiBBY3R1YWxseSBkcml2ZXIgY3Jhc2ggaGFw cGVucyBzaW5jZSA0LjggYnV0IEkgZmFpbGVkIHRvIG5vdGljZSBpdCBlYXJsaWVyIGFuZCBnaXZl biBhbW91bnQNCj4gPiBvZiBjaGFuZ2VzIEkgdGhpbmsgdGhlcmUncyBiYXJlbHkgYSBjaGFuY2Ug Zm9yIGl0IGl0IHRvIGJlIGFjY2VwdGVkIGluIHN0YWJsZSBicmFuY2hlcy4uLg0KPiA+IHdoaWNo IGluIGl0cyB0dXJuIG1ha2VzIGF0IGxlYXN0IDQuOSB2ZXJ5IGRlc2lyYWJsZS4NCj4gDQo+IEFu eSBjaGFuY2UgdGhpcyBvbmUgZ2V0cyBhY2NlcHRlZCBhbnl0aW1lIHNvb24/DQoNClBsZWFzZSB0 cmVhdCB0aGlzIGFzIGFub3RoZXIgcG9saXRlIHJlbWluZGVyIHRvIGFwcGx5IHRoaXMgcGF0Y2gu DQpJZiB5b3UgcHJlZmVyIEkgbWF5IHNlbmQgYSBwdWxsLXJlcXVlc3Qgb3RoZXJ3aXNlLg0KDQpS ZWdhcmRzLA0KQWxleGV5