All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@au1.ibm.com>
To: Mark Rutland <mark.rutland@arm.com>
Cc: devicetree@vger.kernel.org,
	"Guilherme G. Piccoli" <gpiccoli@linux.vnet.ibm.com>,
	marc.zyngier@arm.com, linux-pci@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org, robh+dt@kernel.org,
	frowand.list@gmail.com
Subject: Re: [PATCH] of/irq: improve error message on irq discovery process failure
Date: Sat, 12 Nov 2016 06:12:27 +1100	[thread overview]
Message-ID: <1478891547.2592.13.camel@au1.ibm.com> (raw)
In-Reply-To: <20161111163241.GL11945@leverpostej>

On Fri, 2016-11-11 at 16:32 +0000, Mark Rutland wrote:
> On Fri, Nov 11, 2016 at 08:30:43AM +1100, Benjamin Herrenschmidt
> wrote:
> > 
> > On Wed, 2016-11-09 at 19:04 +0000, Mark Rutland wrote:
> > > 
> > > 
> > > If we don't have an interrupt-map on a PCI controller, why don't
> > > we
> > > instead log a message regarding that being missing, and give up
> > > early?
> > 
> > Why ? It's legit to not support LSIs.
> 
> Sure; I had envisioned a message like:
> 
> 	pr_info("%s: no interrupt-map, INTx interrupts not possible\n",
> 		pci_controller_name);
> 
> ... Which tells the user exaclty what we know, and doesn't imply
> either
> an error or the actual absence of HW support.

Works for me.

Cheers,
Ben.


  reply	other threads:[~2016-11-11 19:12 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-09 14:05 [PATCH] of/irq: improve error message on irq discovery process failure Guilherme G. Piccoli
2016-11-09 18:05 ` Rob Herring
2016-11-09 19:05   ` Guilherme G. Piccoli
2016-11-09 19:05     ` Guilherme G. Piccoli
2016-11-09 19:04 ` Mark Rutland
2016-11-09 19:04   ` Mark Rutland
2016-11-10 21:30   ` Benjamin Herrenschmidt
2016-11-11 16:32     ` Mark Rutland
2016-11-11 19:12       ` Benjamin Herrenschmidt [this message]
2016-11-11 22:27         ` Guilherme G. Piccoli
2016-11-11 22:27           ` Guilherme G. Piccoli
2016-11-10 21:28 ` Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1478891547.2592.13.camel@au1.ibm.com \
    --to=benh@au1.ibm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=frowand.list@gmail.com \
    --cc=gpiccoli@linux.vnet.ibm.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=marc.zyngier@arm.com \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.