Re: [PATCH] tools/power turbostat: Disable HWP OOB status

[Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>]

On Fri, 2016-11-11 at 23:18 +0100, Rafael J. Wysocki wrote:
> On Fri, Nov 11, 2016 at 11:14 PM, Srinivas Pandruvada
> <srinivas.pandruvada@linux.intel.com> wrote:
> > 
> > Display if the HWP is enabled in OOB (Out of band) mode.
> 
> Hmm.  Should the subject be "tools/power turbostat: Display HWP OOB
> status"?
yikes. I don't know how I wrote this. This should be "Display" instead
of "Disable"

Thanks,
Srinivas

> 
> > 
> > Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel
> > .com>
> > ---
> >  tools/power/x86/turbostat/turbostat.c | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> > 
> > diff --git a/tools/power/x86/turbostat/turbostat.c
> > b/tools/power/x86/turbostat/turbostat.c
> > index 3e199b5..27fb0f0 100644
> > --- a/tools/power/x86/turbostat/turbostat.c
> > +++ b/tools/power/x86/turbostat/turbostat.c
> > @@ -3174,10 +3174,11 @@ void decode_misc_pwr_mgmt_msr(void)
> >                 return;
> > 
> >         if (!get_msr(base_cpu, MSR_MISC_PWR_MGMT, &msr))
> > -               fprintf(outf, "cpu%d: MSR_MISC_PWR_MGMT: 0x%08llx
> > (%sable-EIST_Coordination %sable-EPB)\n",
> > +               fprintf(outf, "cpu%d: MSR_MISC_PWR_MGMT: 0x%08llx
> > (%sable-EIST_Coordination %sable-EPB %sable-OOB)\n",
> >                         base_cpu, msr,
> >                         msr & (1 << 0) ? "DIS" : "EN",
> > -                       msr & (1 << 1) ? "EN" : "DIS");
> > +                       msr & (1 << 1) ? "EN" : "DIS",
> > +                       msr & (1 << 8) ? "EN" : "DIS");
> >  }
> > 
> >  void process_cpuid()
> > --
> 
> Thanks,
> Rafael
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pm"
> in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html