All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Victor Kaplansky <victork@redhat.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH v2] vhost-user: fix enabling of queue pair
Date: Tue, 24 Nov 2015 21:29:04 +0100	[thread overview]
Message-ID: <14789443.hoUPLFMsZ2@xps13> (raw)
In-Reply-To: <20151124094106-mutt-send-email-victork@redhat.com>

2015-11-24 09:43, Victor Kaplansky:
> Yuanhan, looks fine. Thanks for handling this.
> -- Victor
> 
> On Tue, Nov 24, 2015 at 03:25:35PM +0800, Yuanhan Liu wrote:
> > From: Victor Kaplansky <victork@redhat.com>
> > 
> > The VHOST_USER_SET_VRING_ENABLE request was sent for each queue-pair.
> > However, it's changed to be sent per queue in the queue-pair by QEMU
> > commit dc3db6ad ("vhost-user: start/stop all rings"). The change
> > is reasonable, as we send all other request per queue, instead of
> > queue-pair.
> > 
> > Hence we should do proper changes to adapt to the QEMU change here.
> > Otherwise, a segfault will be triggered when last TX queue was enabled.
> > 
> > [ commit log reword --  Yuanhan Liu ]
> > 
> > Signed-off-by: Victor Kaplansky <victork@redhat.com>
> > Acked-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
> > ---
> > 
> > v2: invoke vring_state_changed() callback per-vring as well
> > 
> > This fixes a fatal issue, without that MQ will not work properly.
> > Seems that Victor is busy at something else (or out of office so
> > far), hence I sent v2 on behalf of him.

Applied, thanks

      reply	other threads:[~2015-11-24 20:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-20 13:45 [PATCH] vhost-user: fix enabling of queue pair Victor Kaplansky
2015-11-20 15:17 ` Victor Kaplansky
2015-11-23  3:22 ` Yuanhan Liu
2015-11-24  7:25 ` [PATCH v2] " Yuanhan Liu
2015-11-24  7:43   ` Victor Kaplansky
2015-11-24 20:29     ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=14789443.hoUPLFMsZ2@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=dev@dpdk.org \
    --cc=victork@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.