From: Johannes Berg <johannes@sipsolutions.net>
To: Benjamin Beichler <Benjamin.Beichler@uni-rostock.de>,
linux-wireless@vger.kernel.org
Subject: Re: [RFC] change mac80211_hwsim tx_rates to ieee80211_tx_rate
Date: Sat, 12 Nov 2016 22:08:49 +0100 [thread overview]
Message-ID: <1478984929.4226.3.camel@sipsolutions.net> (raw)
In-Reply-To: <dcc2ec52-abe0-3182-e7f5-d1df40fd492b@uni-rostock.de> (sfid-20161111_182223_315895_6A05EDD8)
> So I would propose to put the whole struct into the netlink messages,
This is a terrible idea, since internal changes to this struct would
break the userland API/ABI. hwsim seems perhaps less important than
most APIs, but there is wmediumd etc. already.
> but I think that will break up the communication to e.g. bob
> copelands
> wmediumd and similar simulations. I would like to have our
> Implementation working with mainline kernels and therefore ask how we
> could achieve this easily.
>
> Obviously, we could define another field in the hwsim messages, but
> as bob copeland already stated, significantly more information within
> the netlink messages could intensify the timing overhead of hwsim.
I don't think we have any other choice but add the relevant fields as
proper attributes.
johannes
next prev parent reply other threads:[~2016-11-12 21:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-11 17:22 [RFC] change mac80211_hwsim tx_rates to ieee80211_tx_rate Benjamin Beichler
2016-11-12 21:08 ` Johannes Berg [this message]
2016-11-14 10:20 ` Benjamin Beichler
2016-11-14 14:09 ` Johannes Berg
2016-11-14 14:48 ` Benjamin Beichler
2016-11-14 14:56 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1478984929.4226.3.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=Benjamin.Beichler@uni-rostock.de \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.