From: James Bottomley <jejb@linux.vnet.ibm.com>
To: Bart Van Assche <bart.vanassche@sandisk.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Mike Snitzer <snitzer@redhat.com>, Hannes Reinecke <hare@suse.de>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH 0/2] sd: Fix a deadlock between event checking and device removal
Date: Sat, 12 Nov 2016 21:47:08 -0800 [thread overview]
Message-ID: <1479016028.17624.16.camel@linux.vnet.ibm.com> (raw)
In-Reply-To: <a8f0ee8f-7b40-2375-47a4-52f78af29d8d@sandisk.com>
On Fri, 2016-11-11 at 16:38 -0800, Bart Van Assche wrote:
> Hello James and Martin,
>
> This short patch series fixes a deadlock that I ran into for the
> first time several months ago but for which I had not yet had the
> time to post a fix. As usual, feedback is appreciated.
First question would be why do we need to push highly dm specific
knowledge into block, like REQ_FAIL_IF_NO_PATH. Can't we just use
REQ_FAILFAST_X for this?
Also, I don't quite understand how you've configured multipath
underneath SCSI. I thought dm-mp always went on top?
James
next prev parent reply other threads:[~2016-11-13 5:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-12 0:38 [PATCH 0/2] sd: Fix a deadlock between event checking and device removal Bart Van Assche
2016-11-12 0:39 ` [PATCH 1/2] block, dm-mpath: Introduce request flag REQ_FAIL_IF_NO_PATH Bart Van Assche
2016-11-12 0:40 ` [PATCH 2/2] sd: Fix a deadlock between event checking and device removal Bart Van Assche
2016-11-13 5:47 ` James Bottomley [this message]
2016-11-14 18:35 ` [PATCH 0/2] " Bart Van Assche
2017-11-14 17:01 ` Jack Wang
2017-11-14 17:33 ` Bart Van Assche
2017-11-17 15:14 ` Jack Wang
2017-11-17 17:01 ` Bart Van Assche
2017-11-17 17:10 ` Jack Wang
2017-11-17 17:28 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1479016028.17624.16.camel@linux.vnet.ibm.com \
--to=jejb@linux.vnet.ibm.com \
--cc=bart.vanassche@sandisk.com \
--cc=hare@suse.de \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.