All of lore.kernel.org
 help / color / mirror / Atom feed
From: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
To: Arnd Bergmann <arnd@arndb.de>, "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Len Brown <lenb@kernel.org>,
	Viresh Kumar <viresh.kumar@linaro.org>,
	Philippe Longepe <philippe.longepe@linux.intel.com>,
	Stephane Gasparini <stephane.gasparini@intel.com>,
	linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cpufreq: intel_pstate: fix intel_pstate_use_acpi_profile helper
Date: Mon, 14 Nov 2016 09:14:23 -0800	[thread overview]
Message-ID: <1479143663.6544.11.camel@linux.intel.com> (raw)
In-Reply-To: <20161114164216.2657919-1-arnd@arndb.de>

On Mon, 2016-11-14 at 17:41 +0100, Arnd Bergmann wrote:
> The newly added function uses two different prototypes depending
> on configuration, and one of them does not match the caller:
> 
> drivers/cpufreq/intel_pstate.c: In function ‘copy_cpu_funcs’:
> drivers/cpufreq/intel_pstate.c:1798:2: error: too few arguments to
> function ‘intel_pstate_use_acpi_profile’
> 
> This changes it to look like the other one.
Sorry about that.

> 
> Fixes: 3bea6a285476 ("cpufreq: intel_pstate: Use cpu load based
> algorithm for mobile class devices")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>

> ---
>  drivers/cpufreq/intel_pstate.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/cpufreq/intel_pstate.c
> b/drivers/cpufreq/intel_pstate.c
> index 65832f8eacdc..7153cf2d8e11 100644
> --- a/drivers/cpufreq/intel_pstate.c
> +++ b/drivers/cpufreq/intel_pstate.c
> @@ -1779,7 +1779,7 @@ static void intel_pstate_use_acpi_profile(void)
>  				get_target_pstate_use_cpu_load;
>  }
>  #else
> -static inline void intel_pstate_use_acpi_profile(struct pstate_funcs
> *funcs)
> +static inline void intel_pstate_use_acpi_profile(void)
>  {
>  }
>  #endif

  reply	other threads:[~2016-11-14 17:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-14 16:41 [PATCH] cpufreq: intel_pstate: fix intel_pstate_use_acpi_profile helper Arnd Bergmann
2016-11-14 17:14 ` Srinivas Pandruvada [this message]
2016-11-14 17:53   ` Pandruvada, Srinivas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1479143663.6544.11.camel@linux.intel.com \
    --to=srinivas.pandruvada@linux.intel.com \
    --cc=arnd@arndb.de \
    --cc=lenb@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=philippe.longepe@linux.intel.com \
    --cc=rjw@rjwysocki.net \
    --cc=stephane.gasparini@intel.com \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.