diff for duplicates of <1479150175.6544.25.camel@intel.com> diff --git a/a/1.txt b/N1/1.txt index fb48c87..dbd6d76 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,43 +1,28 @@ -On Mon, 2016-11-14 at 02:09 +0000, Song Hongyan wrote: -> When user tried to read some fields like hysteresis from IIO sysfs on -> some -> systems, it fails. The reason is that this field is a byte field and -> caller -> of sensor_hub_get_feature() passes a buffer of 4 bytes. Here the -> function -> sensor_hub_get_feature() copies the single byte from the report to -> the -> caller buffer and returns "1" as the number of bytes copied. - -Is the following sentence accurate? -> So caller -> can use the return value, which is actually not right. -Caller could have used a single byte from the result buffer as this is -valid data ignoring other bytes. - - -> Since this is done by multiple callers, if we change the -> sensor_hub_get_feature() can make sure the caller buffer is -> initialized -> with 0s then we don't need to change all functions. -> -> Signed-off-by: Song Hongyan <hongyan.song@intel.com> -> --- -> drivers/hid/hid-sensor-hub.c | 1 + -> 1 file changed, 1 insertion(+) -> -> diff --git a/drivers/hid/hid-sensor-hub.c b/drivers/hid/hid-sensor- -> hub.c -> index 658a607..b74d954 100644 -> --- a/drivers/hid/hid-sensor-hub.c -> +++ b/drivers/hid/hid-sensor-hub.c -> @@ -252,6 +252,7 @@ int sensor_hub_get_feature(struct -> hid_sensor_hub_device *hsdev, u32 report_id, -> int report_size; -> int ret = 0; -> -> + memset(buffer, 0, buffer_size); -> mutex_lock(&data->mutex); -> report = sensor_hub_report(report_id, hsdev->hdev, -> HID_FEATURE_REPORT); -> if (!report || (field_index >= report->maxfield) || +T24gTW9uLCAyMDE2LTExLTE0IGF0IDAyOjA5ICswMDAwLCBTb25nIEhvbmd5YW4gd3JvdGU6DQo+ +IFdoZW4gdXNlciB0cmllZCB0byByZWFkIHNvbWUgZmllbGRzIGxpa2UgaHlzdGVyZXNpcyBmcm9t +IElJTyBzeXNmcyBvbg0KPiBzb21lDQo+IHN5c3RlbXMsIGl0IGZhaWxzLiBUaGUgcmVhc29uIGlz +IHRoYXQgdGhpcyBmaWVsZCBpcyBhIGJ5dGUgZmllbGQgYW5kDQo+IGNhbGxlcg0KPiBvZiBzZW5z +b3JfaHViX2dldF9mZWF0dXJlKCkgcGFzc2VzIGEgYnVmZmVyIG9mIDQgYnl0ZXMuIEhlcmUgdGhl +DQo+IGZ1bmN0aW9uDQo+IHNlbnNvcl9odWJfZ2V0X2ZlYXR1cmUoKSBjb3BpZXMgdGhlIHNpbmds +ZSBieXRlIGZyb20gdGhlIHJlcG9ydCB0bw0KPiB0aGUNCj4gY2FsbGVyIGJ1ZmZlciBhbmQgcmV0 +dXJucyAiMSIgYXMgdGhlIG51bWJlciBvZiBieXRlcyBjb3BpZWQuDQoNCklzIHRoZSBmb2xsb3dp +bmcgc2VudGVuY2UgYWNjdXJhdGU/DQo+ICBTbyBjYWxsZXINCj4gY2FuIHVzZSB0aGUgcmV0dXJu +IHZhbHVlLCB3aGljaCBpcyBhY3R1YWxseSBub3QgcmlnaHQuDQpDYWxsZXIgY291bGQgaGF2ZSB1 +c2VkIGEgc2luZ2xlIGJ5dGUgZnJvbSB0aGUgcmVzdWx0IGJ1ZmZlciBhcyB0aGlzIGlzDQp2YWxp +ZCBkYXRhIGlnbm9yaW5nIG90aGVyIGJ5dGVzLg0KDQoNCj4gU2luY2UgdGhpcyBpcyBkb25lIGJ5 +IG11bHRpcGxlIGNhbGxlcnMsIGlmIHdlIGNoYW5nZSB0aGUNCj4gc2Vuc29yX2h1Yl9nZXRfZmVh +dHVyZSgpIGNhbiBtYWtlIHN1cmUgdGhlIGNhbGxlciBidWZmZXIgaXMNCj4gaW5pdGlhbGl6ZWQN +Cj4gd2l0aCAwcyB0aGVuIHdlIGRvbid0IG5lZWQgdG8gY2hhbmdlIGFsbCBmdW5jdGlvbnMuDQo+ +IA0KPiBTaWduZWQtb2ZmLWJ5OiBTb25nIEhvbmd5YW4gPGhvbmd5YW4uc29uZ0BpbnRlbC5jb20+ +DQo+IC0tLQ0KPiDCoGRyaXZlcnMvaGlkL2hpZC1zZW5zb3ItaHViLmMgfCAxICsNCj4gwqAxIGZp +bGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKykNCj4gDQo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2hp +ZC9oaWQtc2Vuc29yLWh1Yi5jIGIvZHJpdmVycy9oaWQvaGlkLXNlbnNvci0NCj4gaHViLmMNCj4g +aW5kZXggNjU4YTYwNy4uYjc0ZDk1NCAxMDA2NDQNCj4gLS0tIGEvZHJpdmVycy9oaWQvaGlkLXNl +bnNvci1odWIuYw0KPiArKysgYi9kcml2ZXJzL2hpZC9oaWQtc2Vuc29yLWh1Yi5jDQo+IEBAIC0y +NTIsNiArMjUyLDcgQEAgaW50IHNlbnNvcl9odWJfZ2V0X2ZlYXR1cmUoc3RydWN0DQo+IGhpZF9z +ZW5zb3JfaHViX2RldmljZSAqaHNkZXYsIHUzMiByZXBvcnRfaWQsDQo+IMKgCWludCByZXBvcnRf +c2l6ZTsNCj4gwqAJaW50IHJldCA9IDA7DQo+IMKgDQo+ICsJbWVtc2V0KGJ1ZmZlciwgMCwgYnVm +ZmVyX3NpemUpOw0KPiDCoAltdXRleF9sb2NrKCZkYXRhLT5tdXRleCk7DQo+IMKgCXJlcG9ydCA9 +IHNlbnNvcl9odWJfcmVwb3J0KHJlcG9ydF9pZCwgaHNkZXYtPmhkZXYsDQo+IEhJRF9GRUFUVVJF +X1JFUE9SVCk7DQo+IMKgCWlmICghcmVwb3J0IHx8IChmaWVsZF9pbmRleCA+PSByZXBvcnQtPm1h +eGZpZWxkKSB8fA== diff --git a/a/content_digest b/N1/content_digest index 98feccb..641e05c 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,58 +1,42 @@ "ref\01479089394-30765-1-git-send-email-hongyan.song@intel.com\0" - "ref\01479089394-30765-1-git-send-email-hongyan.song-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org\0" - "From\0Pandruvada, Srinivas <srinivas.pandruvada-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>\0" + "From\0Pandruvada, Srinivas <srinivas.pandruvada@intel.com>\0" "Subject\0Re: [PATCH v3] hid: hid-sensor-hub: clear memory to avoid random data\0" "Date\0Mon, 14 Nov 2016 19:02:57 +0000\0" - "To\0linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org <linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>" + "To\0linux-input@vger.kernel.org <linux-input@vger.kernel.org>" Song - Hongyan <hongyan.song-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> - " linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org <linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>\0" - "Cc\0jikos-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org <jikos-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>" - " jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org <jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>\0" + Hongyan <hongyan.song@intel.com> + " linux-iio@vger.kernel.org <linux-iio@vger.kernel.org>\0" + "Cc\0jikos@kernel.org <jikos@kernel.org>" + " jic23@kernel.org <jic23@kernel.org>\0" "\00:1\0" "b\0" - "On Mon, 2016-11-14 at 02:09 +0000, Song Hongyan wrote:\n" - "> When user tried to read some fields like hysteresis from IIO sysfs on\n" - "> some\n" - "> systems, it fails. The reason is that this field is a byte field and\n" - "> caller\n" - "> of sensor_hub_get_feature() passes a buffer of 4 bytes. Here the\n" - "> function\n" - "> sensor_hub_get_feature() copies the single byte from the report to\n" - "> the\n" - "> caller buffer and returns \"1\" as the number of bytes copied.\n" - "\n" - "Is the following sentence accurate?\n" - "> So caller\n" - "> can use the return value, which is actually not right.\n" - "Caller could have used a single byte from the result buffer as this is\n" - "valid data ignoring other bytes.\n" - "\n" - "\n" - "> Since this is done by multiple callers, if we change the\n" - "> sensor_hub_get_feature() can make sure the caller buffer is\n" - "> initialized\n" - "> with 0s then we don't need to change all functions.\n" - "> \n" - "> Signed-off-by: Song Hongyan <hongyan.song@intel.com>\n" - "> ---\n" - "> \302\240drivers/hid/hid-sensor-hub.c | 1 +\n" - "> \302\2401 file changed, 1 insertion(+)\n" - "> \n" - "> diff --git a/drivers/hid/hid-sensor-hub.c b/drivers/hid/hid-sensor-\n" - "> hub.c\n" - "> index 658a607..b74d954 100644\n" - "> --- a/drivers/hid/hid-sensor-hub.c\n" - "> +++ b/drivers/hid/hid-sensor-hub.c\n" - "> @@ -252,6 +252,7 @@ int sensor_hub_get_feature(struct\n" - "> hid_sensor_hub_device *hsdev, u32 report_id,\n" - "> \302\240\tint report_size;\n" - "> \302\240\tint ret = 0;\n" - "> \302\240\n" - "> +\tmemset(buffer, 0, buffer_size);\n" - "> \302\240\tmutex_lock(&data->mutex);\n" - "> \302\240\treport = sensor_hub_report(report_id, hsdev->hdev,\n" - "> HID_FEATURE_REPORT);\n" - "> \302\240\tif (!report || (field_index >= report->maxfield) ||" + "T24gTW9uLCAyMDE2LTExLTE0IGF0IDAyOjA5ICswMDAwLCBTb25nIEhvbmd5YW4gd3JvdGU6DQo+\n" + "IFdoZW4gdXNlciB0cmllZCB0byByZWFkIHNvbWUgZmllbGRzIGxpa2UgaHlzdGVyZXNpcyBmcm9t\n" + "IElJTyBzeXNmcyBvbg0KPiBzb21lDQo+IHN5c3RlbXMsIGl0IGZhaWxzLiBUaGUgcmVhc29uIGlz\n" + "IHRoYXQgdGhpcyBmaWVsZCBpcyBhIGJ5dGUgZmllbGQgYW5kDQo+IGNhbGxlcg0KPiBvZiBzZW5z\n" + "b3JfaHViX2dldF9mZWF0dXJlKCkgcGFzc2VzIGEgYnVmZmVyIG9mIDQgYnl0ZXMuIEhlcmUgdGhl\n" + "DQo+IGZ1bmN0aW9uDQo+IHNlbnNvcl9odWJfZ2V0X2ZlYXR1cmUoKSBjb3BpZXMgdGhlIHNpbmds\n" + "ZSBieXRlIGZyb20gdGhlIHJlcG9ydCB0bw0KPiB0aGUNCj4gY2FsbGVyIGJ1ZmZlciBhbmQgcmV0\n" + "dXJucyAiMSIgYXMgdGhlIG51bWJlciBvZiBieXRlcyBjb3BpZWQuDQoNCklzIHRoZSBmb2xsb3dp\n" + "bmcgc2VudGVuY2UgYWNjdXJhdGU/DQo+ICBTbyBjYWxsZXINCj4gY2FuIHVzZSB0aGUgcmV0dXJu\n" + "IHZhbHVlLCB3aGljaCBpcyBhY3R1YWxseSBub3QgcmlnaHQuDQpDYWxsZXIgY291bGQgaGF2ZSB1\n" + "c2VkIGEgc2luZ2xlIGJ5dGUgZnJvbSB0aGUgcmVzdWx0IGJ1ZmZlciBhcyB0aGlzIGlzDQp2YWxp\n" + "ZCBkYXRhIGlnbm9yaW5nIG90aGVyIGJ5dGVzLg0KDQoNCj4gU2luY2UgdGhpcyBpcyBkb25lIGJ5\n" + "IG11bHRpcGxlIGNhbGxlcnMsIGlmIHdlIGNoYW5nZSB0aGUNCj4gc2Vuc29yX2h1Yl9nZXRfZmVh\n" + "dHVyZSgpIGNhbiBtYWtlIHN1cmUgdGhlIGNhbGxlciBidWZmZXIgaXMNCj4gaW5pdGlhbGl6ZWQN\n" + "Cj4gd2l0aCAwcyB0aGVuIHdlIGRvbid0IG5lZWQgdG8gY2hhbmdlIGFsbCBmdW5jdGlvbnMuDQo+\n" + "IA0KPiBTaWduZWQtb2ZmLWJ5OiBTb25nIEhvbmd5YW4gPGhvbmd5YW4uc29uZ0BpbnRlbC5jb20+\n" + "DQo+IC0tLQ0KPiDCoGRyaXZlcnMvaGlkL2hpZC1zZW5zb3ItaHViLmMgfCAxICsNCj4gwqAxIGZp\n" + "bGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKykNCj4gDQo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2hp\n" + "ZC9oaWQtc2Vuc29yLWh1Yi5jIGIvZHJpdmVycy9oaWQvaGlkLXNlbnNvci0NCj4gaHViLmMNCj4g\n" + "aW5kZXggNjU4YTYwNy4uYjc0ZDk1NCAxMDA2NDQNCj4gLS0tIGEvZHJpdmVycy9oaWQvaGlkLXNl\n" + "bnNvci1odWIuYw0KPiArKysgYi9kcml2ZXJzL2hpZC9oaWQtc2Vuc29yLWh1Yi5jDQo+IEBAIC0y\n" + "NTIsNiArMjUyLDcgQEAgaW50IHNlbnNvcl9odWJfZ2V0X2ZlYXR1cmUoc3RydWN0DQo+IGhpZF9z\n" + "ZW5zb3JfaHViX2RldmljZSAqaHNkZXYsIHUzMiByZXBvcnRfaWQsDQo+IMKgCWludCByZXBvcnRf\n" + "c2l6ZTsNCj4gwqAJaW50IHJldCA9IDA7DQo+IMKgDQo+ICsJbWVtc2V0KGJ1ZmZlciwgMCwgYnVm\n" + "ZmVyX3NpemUpOw0KPiDCoAltdXRleF9sb2NrKCZkYXRhLT5tdXRleCk7DQo+IMKgCXJlcG9ydCA9\n" + "IHNlbnNvcl9odWJfcmVwb3J0KHJlcG9ydF9pZCwgaHNkZXYtPmhkZXYsDQo+IEhJRF9GRUFUVVJF\n" + "X1JFUE9SVCk7DQo+IMKgCWlmICghcmVwb3J0IHx8IChmaWVsZF9pbmRleCA+PSByZXBvcnQtPm1h\n" + eGZpZWxkKSB8fA== -371c9b774b70b5b97543fbb423891719a10a8a5cf7bf734bc55adf5cd719c160 +cfd51d0d0269b3948a21999b7c14571d947495062969db308d16b6f142b23065
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.