All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bimmy Pujari <bimmy.pujari@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [next PATCH S53-V2 1/5] i40e: use unsigned printf format specifier for active_filters count
Date: Mon, 14 Nov 2016 13:06:45 -0800	[thread overview]
Message-ID: <1479157609-30812-1-git-send-email-bimmy.pujari@intel.com> (raw)

From: Jacob Keller <jacob.e.keller@intel.com>

Replace the %d specifier used for printing vsi->active_filters and
vsi->promisc_threshold with an unsigned %u format specifier. While it is
unlikely in practice that these values will ever reach such a large
number they are unsigned values and thus should not be interpreted as
negative numbers.

Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Change-ID: Iff050fad5a1c8537c4c57fcd527441cd95cfc0d4
---
Testing-hints:
  This should go upstream, even though it is in debugfs code. We're not
  adding features but simply correcting output of existing features.

 drivers/net/ethernet/intel/i40e/i40e_debugfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/intel/i40e/i40e_debugfs.c b/drivers/net/ethernet/intel/i40e/i40e_debugfs.c
index b8a03a0..f1f41f1 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_debugfs.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_debugfs.c
@@ -172,7 +172,7 @@ static void i40e_dbg_dump_vsi_seid(struct i40e_pf *pf, int seid)
 			 f->macaddr, f->vlan,
 			 i40e_filter_state_string[f->state]);
 	}
-	dev_info(&pf->pdev->dev, "    active_filters %d, promisc_threshold %d, overflow promisc %s\n",
+	dev_info(&pf->pdev->dev, "    active_filters %u, promisc_threshold %u, overflow promisc %s\n",
 		 vsi->active_filters, vsi->promisc_threshold,
 		 (test_bit(__I40E_FILTER_OVERFLOW_PROMISC, &vsi->state) ?
 		  "ON" : "OFF"));
-- 
2.4.11


             reply	other threads:[~2016-11-14 21:06 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-14 21:06 Bimmy Pujari [this message]
2016-11-14 21:06 ` [Intel-wired-lan] [next PATCH S53-V2 2/5] i40e: Add support for 25G devices Bimmy Pujari
2016-11-17 21:23   ` Bowers, AndrewX
2016-11-14 21:06 ` [Intel-wired-lan] [next PATCH S53-V2 3/5] i40e: Add FEC for 25g Bimmy Pujari
2016-11-17 21:35   ` Bowers, AndrewX
2016-11-17 21:55   ` Bowers, AndrewX
2016-11-14 21:06 ` [Intel-wired-lan] [next PATCH S53-V2 4/5] i40e: Add functions which apply correct PHY access method for read and write operation Bimmy Pujari
2016-11-17 21:55   ` Bowers, AndrewX
2016-11-14 21:06 ` [Intel-wired-lan] [next PATCH S53-V2 5/5] i40e: lock service task correctly Bimmy Pujari
2016-11-18 17:51   ` Bowers, AndrewX
2016-11-17 20:41 ` [Intel-wired-lan] [next PATCH S53-V2 1/5] i40e: use unsigned printf format specifier for active_filters count Bowers, AndrewX

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1479157609-30812-1-git-send-email-bimmy.pujari@intel.com \
    --to=bimmy.pujari@intel.com \
    --cc=intel-wired-lan@osuosl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.