All of lore.kernel.org
 help / color / mirror / Atom feed
From: Scott Wood <oss@buserror.net>
To: Florian Larysch <fl@n621.de>
Cc: linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] T4240RBD: add device tree entry for W83793
Date: Mon, 14 Nov 2016 22:59:55 -0600	[thread overview]
Message-ID: <1479185995.21746.10.camel@buserror.net> (raw)
In-Reply-To: <20161114122805.11376-1-fl@n621.de>

On Mon, 2016-11-14 at 13:28 +0100, Florian Larysch wrote:
> The T4240RDB contains a W83793 hardware monitoring chip. Add a device
> tree entry to make the driver attach to it, as the i2c-mpc bus driver
> dropped support for class-based instantiation of devices a long time
> ago.
> 
> Signed-off-by: Florian Larysch <fl@n621.de>
> ---
>  arch/powerpc/boot/dts/fsl/t4240rdb.dts | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/powerpc/boot/dts/fsl/t4240rdb.dts
> b/arch/powerpc/boot/dts/fsl/t4240rdb.dts
> index cc0a264..b35eea1 100644
> --- a/arch/powerpc/boot/dts/fsl/t4240rdb.dts
> +++ b/arch/powerpc/boot/dts/fsl/t4240rdb.dts
> @@ -142,6 +142,10 @@
>  				reg = <0x68>;
>  				interrupts = <0x1 0x1 0 0>;
>  			};
> +			hwmon@2f {
> +				compatible = "winbond,w83793";
> +				reg = <0x2f>;
> +			};
>  		};
>  
>  		sdhc@114000 {

Please (in a separate patch) add this to
Documentation/devicetree/bindings/i2c/trivial-devices.txt and CC\
devicetree@vger.kernel.org

Also, please keep the i2c nodes sorted by address.

-Scott

      reply	other threads:[~2016-11-15  5:00 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-14 12:28 [PATCH] T4240RBD: add device tree entry for W83793 Florian Larysch
2016-11-15  4:59 ` Scott Wood [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1479185995.21746.10.camel@buserror.net \
    --to=oss@buserror.net \
    --cc=fl@n621.de \
    --cc=linuxppc-dev@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.