diff for duplicates of <1479234278.2456.49.camel@pengutronix.de> diff --git a/a/1.txt b/N1/1.txt index f6ae045..ac1cb78 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -80,7 +80,7 @@ This struct is not used, can be removed. > + > + mutex_lock(&hdmi_notifiers_lock); > + list_for_each_entry(n, &hdmi_notifiers, head) { -> + if (n->dev = dev) { +> + if (n->dev == dev) { > + mutex_unlock(&hdmi_notifiers_lock); > + kref_get(&n->kref); > + return n; @@ -107,7 +107,8 @@ own hdmi_notifier. > + > +static void hdmi_notifier_release(struct kref *kref) > +{ -> + struct hdmi_notifier *n > + container_of(kref, struct hdmi_notifier, kref); +> + struct hdmi_notifier *n = +> + container_of(kref, struct hdmi_notifier, kref); > + > + kfree(n->edid); > + kfree(n); @@ -143,7 +144,7 @@ own hdmi_notifier. > +{ > + int ret = blocking_notifier_chain_unregister(&n->notifiers, nb); > + -> + if (ret = 0) +> + if (ret == 0) > + hdmi_notifier_put(n); > + return ret; > +} @@ -175,7 +176,7 @@ own hdmi_notifier. > + if (n->edid_allocated_size < size) { > + void *p = kmalloc(size, GFP_KERNEL); > + -> + if (p = NULL) { +> + if (p == NULL) { > + mutex_unlock(&n->lock); > + return -ENOMEM; > + } diff --git a/a/content_digest b/N1/content_digest index 4286207..9fc812d 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,15 +1,9 @@ "ref\01479136968-24477-1-git-send-email-hverkuil@xs4all.nl\0" "ref\01479136968-24477-2-git-send-email-hverkuil@xs4all.nl\0" - "From\0Philipp Zabel <p.zabel@pengutronix.de>\0" - "Subject\0Re: [RFCv2 PATCH 1/5] video: add HDMI state notifier support\0" - "Date\0Tue, 15 Nov 2016 18:24:38 +0000\0" - "To\0Hans Verkuil <hverkuil@xs4all.nl>\0" - "Cc\0linux-media@vger.kernel.org" - Russell King - ARM Linux <linux@armlinux.org.uk> - linux-fbdev@vger.kernel.org - dri-devel@lists.freedesktop.org - linux-arm-kernel@lists.infradead.org - " Hans Verkuil <hans.verkuil@cisco.com>\0" + "From\0p.zabel@pengutronix.de (Philipp Zabel)\0" + "Subject\0[RFCv2 PATCH 1/5] video: add HDMI state notifier support\0" + "Date\0Tue, 15 Nov 2016 19:24:38 +0100\0" + "To\0linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" "Hi Hans,\n" @@ -94,7 +88,7 @@ "> +\n" "> +\tmutex_lock(&hdmi_notifiers_lock);\n" "> +\tlist_for_each_entry(n, &hdmi_notifiers, head) {\n" - "> +\t\tif (n->dev = dev) {\n" + "> +\t\tif (n->dev == dev) {\n" "> +\t\t\tmutex_unlock(&hdmi_notifiers_lock);\n" "> +\t\t\tkref_get(&n->kref);\n" "> +\t\t\treturn n;\n" @@ -121,7 +115,8 @@ "> +\n" "> +static void hdmi_notifier_release(struct kref *kref)\n" "> +{\n" - "> +\tstruct hdmi_notifier *n > +\t\tcontainer_of(kref, struct hdmi_notifier, kref);\n" + "> +\tstruct hdmi_notifier *n =\n" + "> +\t\tcontainer_of(kref, struct hdmi_notifier, kref);\n" "> +\n" "> +\tkfree(n->edid);\n" "> +\tkfree(n);\n" @@ -157,7 +152,7 @@ "> +{\n" "> +\tint ret = blocking_notifier_chain_unregister(&n->notifiers, nb);\n" "> +\n" - "> +\tif (ret = 0)\n" + "> +\tif (ret == 0)\n" "> +\t\thdmi_notifier_put(n);\n" "> +\treturn ret;\n" "> +}\n" @@ -189,7 +184,7 @@ "> +\tif (n->edid_allocated_size < size) {\n" "> +\t\tvoid *p = kmalloc(size, GFP_KERNEL);\n" "> +\n" - "> +\t\tif (p = NULL) {\n" + "> +\t\tif (p == NULL) {\n" "> +\t\t\tmutex_unlock(&n->lock);\n" "> +\t\t\treturn -ENOMEM;\n" "> +\t\t}\n" @@ -275,4 +270,4 @@ "regards\n" Philipp -956c3081427de403e8fc72408cb0d816123223949c674f075db86f0a5e47ebc1 +d17805edccd6d82960efe7dacd969bb7e1a0b26bd00c0eca0e20a7bb219d9f60
diff --git a/a/1.txt b/N2/1.txt index f6ae045..ac1cb78 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -80,7 +80,7 @@ This struct is not used, can be removed. > + > + mutex_lock(&hdmi_notifiers_lock); > + list_for_each_entry(n, &hdmi_notifiers, head) { -> + if (n->dev = dev) { +> + if (n->dev == dev) { > + mutex_unlock(&hdmi_notifiers_lock); > + kref_get(&n->kref); > + return n; @@ -107,7 +107,8 @@ own hdmi_notifier. > + > +static void hdmi_notifier_release(struct kref *kref) > +{ -> + struct hdmi_notifier *n > + container_of(kref, struct hdmi_notifier, kref); +> + struct hdmi_notifier *n = +> + container_of(kref, struct hdmi_notifier, kref); > + > + kfree(n->edid); > + kfree(n); @@ -143,7 +144,7 @@ own hdmi_notifier. > +{ > + int ret = blocking_notifier_chain_unregister(&n->notifiers, nb); > + -> + if (ret = 0) +> + if (ret == 0) > + hdmi_notifier_put(n); > + return ret; > +} @@ -175,7 +176,7 @@ own hdmi_notifier. > + if (n->edid_allocated_size < size) { > + void *p = kmalloc(size, GFP_KERNEL); > + -> + if (p = NULL) { +> + if (p == NULL) { > + mutex_unlock(&n->lock); > + return -ENOMEM; > + } diff --git a/a/content_digest b/N2/content_digest index 4286207..d2057be 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -2,7 +2,7 @@ "ref\01479136968-24477-2-git-send-email-hverkuil@xs4all.nl\0" "From\0Philipp Zabel <p.zabel@pengutronix.de>\0" "Subject\0Re: [RFCv2 PATCH 1/5] video: add HDMI state notifier support\0" - "Date\0Tue, 15 Nov 2016 18:24:38 +0000\0" + "Date\0Tue, 15 Nov 2016 19:24:38 +0100\0" "To\0Hans Verkuil <hverkuil@xs4all.nl>\0" "Cc\0linux-media@vger.kernel.org" Russell King - ARM Linux <linux@armlinux.org.uk> @@ -94,7 +94,7 @@ "> +\n" "> +\tmutex_lock(&hdmi_notifiers_lock);\n" "> +\tlist_for_each_entry(n, &hdmi_notifiers, head) {\n" - "> +\t\tif (n->dev = dev) {\n" + "> +\t\tif (n->dev == dev) {\n" "> +\t\t\tmutex_unlock(&hdmi_notifiers_lock);\n" "> +\t\t\tkref_get(&n->kref);\n" "> +\t\t\treturn n;\n" @@ -121,7 +121,8 @@ "> +\n" "> +static void hdmi_notifier_release(struct kref *kref)\n" "> +{\n" - "> +\tstruct hdmi_notifier *n > +\t\tcontainer_of(kref, struct hdmi_notifier, kref);\n" + "> +\tstruct hdmi_notifier *n =\n" + "> +\t\tcontainer_of(kref, struct hdmi_notifier, kref);\n" "> +\n" "> +\tkfree(n->edid);\n" "> +\tkfree(n);\n" @@ -157,7 +158,7 @@ "> +{\n" "> +\tint ret = blocking_notifier_chain_unregister(&n->notifiers, nb);\n" "> +\n" - "> +\tif (ret = 0)\n" + "> +\tif (ret == 0)\n" "> +\t\thdmi_notifier_put(n);\n" "> +\treturn ret;\n" "> +}\n" @@ -189,7 +190,7 @@ "> +\tif (n->edid_allocated_size < size) {\n" "> +\t\tvoid *p = kmalloc(size, GFP_KERNEL);\n" "> +\n" - "> +\t\tif (p = NULL) {\n" + "> +\t\tif (p == NULL) {\n" "> +\t\t\tmutex_unlock(&n->lock);\n" "> +\t\t\treturn -ENOMEM;\n" "> +\t\t}\n" @@ -275,4 +276,4 @@ "regards\n" Philipp -956c3081427de403e8fc72408cb0d816123223949c674f075db86f0a5e47ebc1 +07df3f83d16e3db9dfa3356136572a133cecda672facf04e57b2d4e085a5644b
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.