All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Michael Neuling <mikey@neuling.org>, mpe@ellerman.id.au
Cc: aneesh.kumar@linux.vnet.ibm.com, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc/mm/radix: Invalidate ERAT on tlbiel for POWER9 DD1
Date: Wed, 16 Nov 2016 15:35:52 +1100	[thread overview]
Message-ID: <1479270952.2608.82.camel@kernel.crashing.org> (raw)
In-Reply-To: <20161116041820.28433-1-mikey@neuling.org>

On Wed, 2016-11-16 at 15:18 +1100, Michael Neuling wrote:
> +               asm volatile("isync \n"
> +                            PPC_SLBIA(0x7)
> +                            : : :"memory");
>         return;
>  }
> 
We probably don't need the isync's

> @@ -83,6 +87,10 @@ static inline void _tlbiel_va(unsigned long va,
> unsigned long pid,
>         asm volatile(PPC_TLBIEL(%0, %4, %3, %2, %1)
>                      : : "r"(rb), "i"(r), "i"(prs), "i"(ric), "r"(rs)
> : "memory");
>         asm volatile("ptesync": : :"memory");
> +       if (cpu_has_feature(CPU_FTR_POWER9_DD1))
> +               asm volatile("isync \n"
> +                            PPC_SLBIA(0x7)
> +                            : : :"memory");
>  }

  reply	other threads:[~2016-11-16  4:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-16  4:18 [PATCH] powerpc/mm/radix: Invalidate ERAT on tlbiel for POWER9 DD1 Michael Neuling
2016-11-16  4:35 ` Benjamin Herrenschmidt [this message]
2016-11-16  5:14   ` Michael Neuling

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1479270952.2608.82.camel@kernel.crashing.org \
    --to=benh@kernel.crashing.org \
    --cc=aneesh.kumar@linux.vnet.ibm.com \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mikey@neuling.org \
    --cc=mpe@ellerman.id.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.