From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753141AbcKTBOI (ORCPT ); Sat, 19 Nov 2016 20:14:08 -0500 Received: from shadbolt.e.decadent.org.uk ([88.96.1.126]:34706 "EHLO shadbolt.e.decadent.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753014AbcKTBOH (ORCPT ); Sat, 19 Nov 2016 20:14:07 -0500 Message-ID: <1479604438.16599.19.camel@decadent.org.uk> Subject: Re: [PATCH 3.16 327/346] mm: workingset: fix crash in shadow node shrinker caused by replace_page_cache_page() From: Ben Hutchings To: Johannes Weiner Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, akpm@linux-foundation.org, Antonio SJ Musumeci , Linus Torvalds Date: Sun, 20 Nov 2016 01:13:58 +0000 In-Reply-To: <20161114154249.GA3291@cmpxchg.org> References: <20161114154249.GA3291@cmpxchg.org> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-N6Clq49i3KhrJJsUwFvG" X-Mailer: Evolution 3.22.2-1 Mime-Version: 1.0 X-SA-Exim-Connect-IP: 2a02:8011:400e:2:6f00:88c8:c921:d332 X-SA-Exim-Mail-From: ben@decadent.org.uk X-SA-Exim-Scanned: No (on shadbolt.decadent.org.uk); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-N6Clq49i3KhrJJsUwFvG Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, 2016-11-14 at 10:42 -0500, Johannes Weiner wrote: > On Mon, Nov 14, 2016 at 12:14:20AM +0000, Ben Hutchings wrote: > > 3.16.39-rc1 review patch.=C2=A0=C2=A0If anyone has any objections, plea= se let me know. > >=20 > > ------------------ > >=20 > > From: Johannes Weiner > >=20 > > commit 22f2ac51b6d643666f4db093f13144f773ff3f3a upstream. [...] > The added sanity checks in this patch can crash kernels built with > CONFIG_DEBUG_VM. While I doubt many people run 3.16 with that enabled, > please also consider taking the following two changes. The first one > changes the new VM_BUG_ONs to mere warnings, and the second patch > addresses the underlying issue that triggered them in the first place. >=20 > 21f54ddae449 Using BUG_ON() as an assert() is _never_ acceptable > d3798ae8c6f3 mm: filemap: don't plant shadow entries without radix tree n= ode >=20 > Attaching the latter below, since it's drastically different than the > upstream change, but a lot simpler because it predates the DAX stuff. [...] Thanks, I've added these two. Ben. --=20 Ben Hutchings Lowery's Law: =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0If it jams, force it. If it breaks, it needed replacing anyway. --=-N6Clq49i3KhrJJsUwFvG Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEErCspvTSmr92z9o8157/I7JWGEQkFAlgw+NYACgkQ57/I7JWG EQlUhA//WNGXxWavcSDHpHyQS5YOVEBBd1cZVsv2x3nVS95me49/mdLMe7mYHrPn hliG21Fl1K13YXhFvVXk9zYyhrpy4kvdJ11p6h1gXFksTT6jlHFbzT0b84Bc85H8 ETn9PZ5OstAxPO+qC1r3yEaowfcgXAw81bUO6o+DvtJEYt9MknjrQw1aGaFPUt7M 60Zlv3z0L7ftaCInlKZQBw5bzYeONBX9lMn1uW/Y5YHbg4YMu6fyegj7Gqkdu+gi Dw6sU0DW3HXSIHr9/m9wG/6fsX5pMwMThqlYY8qm9Bu3Ozvf5eMW1VOkxhvXz0kT UcfS+K7tFKnCB7W5thoA3jUv+5JzNj+OR9TKkOCpHYu4lcXv3EYnS7aF0FMTdpWf Xf62UlaFTmwJemvjWb6EvxpLXuuW7Qr6zewCAjlhr4xeim4DIIfh40O/ttFlFwEQ XnDgoxziZcVy0D+ZBdHtkyKICkR1xrd+TG6rcAIti/gTZ4gX61udd7ooAIjZ1F2D oi4j8EItIYh8j4NSp4/Ha9y69mcwguIek4obgAakeNjMTNFExNfGCqJdE3vDHFTh IUAmZNifBG/vNN7BqjepXi4ATfN5/ALeDRK5XD7Xg3NpMZ2amiqoNCh207Vi/ECg aNqTGS5pwvtWQ3FYpSoMFGsiUYQX4ncvzR0b39AmMqsT3Q7yjaA= =p7G6 -----END PGP SIGNATURE----- --=-N6Clq49i3KhrJJsUwFvG--