From: Paul Moore <paul@paul-moore.com>
To: "Christopher J. PeBenito" <cpebenito@tresys.com>
Cc: selinux@tycho.nsa.gov
Subject: Re: [PATCH 1/1] Add SELinux policy capability for always checking packet class.
Date: Thu, 31 May 2012 09:58:29 -0400 [thread overview]
Message-ID: <1479620.Ig8PyPEAh1@sifl> (raw)
In-Reply-To: <4FC75C0E.7040709@tresys.com>
On Thursday, May 31, 2012 07:54:54 AM Christopher J. PeBenito wrote:
> On 05/30/12 10:30, Paul Moore wrote:
> > On Wednesday, May 30, 2012 09:22:08 AM Chris PeBenito wrote:
> >> Currently the packet class in SELinux is not checked if there are no
> >> SECMARK rules in the security or mangle netfilter tables. Some systems
> >> prefer that packets are always checked, for example, to protect the
> >> system
> >> should the netfilter rules fail to load or if the nefilter rules
> >> were maliciously flushed.
> >>
> >> Add the always_check_packets policy capability which, when enabled,
> >> treats
> >> SECMARK as enabled, even if there are no netfilter SECMARK rules.
> >
> > I'm against committing this patch without some matching mechanism to
> > incorporate the secmark labeling configuration in the greater SELinux
> > policy. I explained why roughly 87 times in the previous RFC email thread
> > started by Chris so I'll save us all some time and not repeat it here.
> >
> > Ignoring my own objections for a moment and glancing at the patch, I see
> > that it is incomplete/incorrect as it does not include support for the
> > network peer labels. See the original RFC email thread.
>
> The question is if they should be tied to the same policy capability. If
> so, this capability should be renamed. If not, the patch is fine, as I can
> just as easily send a second patch. I'm undecided if they should be tied
> together.
If you're going to do one, do them all.
--
paul moore
www.paul-moore.com
--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.
prev parent reply other threads:[~2012-05-31 13:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-30 13:22 [PATCH 1/1] Add SELinux policy capability for always checking packet class Chris PeBenito
2012-05-30 14:30 ` Paul Moore
2012-05-31 11:54 ` Christopher J. PeBenito
2012-05-31 13:58 ` Paul Moore [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1479620.Ig8PyPEAh1@sifl \
--to=paul@paul-moore.com \
--cc=cpebenito@tresys.com \
--cc=selinux@tycho.nsa.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.