From: Gerd Hoffmann <kraxel@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-stable@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] ui/vnc: Fix problem with sending too many bytes as server name
Date: Mon, 21 Nov 2016 18:51:10 +0100 [thread overview]
Message-ID: <1479750670.9742.47.camel@redhat.com> (raw)
In-Reply-To: <1479749115-21932-1-git-send-email-thuth@redhat.com>
On Mo, 2016-11-21 at 18:25 +0100, Thomas Huth wrote:
> If the buffer is not big enough, snprintf() does not return the number
> of bytes that have been written to the buffer, but the number of bytes
> that would be needed for writing the whole string. By using this value
> for the following vnc_write() calls, we send some junk at the end of
> the name in case the qemu_name is longer than 1017 bytes, which could
> confuse the VNC clients. Fix this by adding an additional size check
> here.
Use g_strdup_printf instead?
cheers,
Gerd
next prev parent reply other threads:[~2016-11-21 17:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-21 17:25 [Qemu-devel] [PATCH] ui/vnc: Fix problem with sending too many bytes as server name Thomas Huth
2016-11-21 17:31 ` [Qemu-devel] [PATCH for-2.8] " Eric Blake
2016-11-21 17:51 ` Gerd Hoffmann [this message]
2016-11-22 7:12 ` [Qemu-devel] [PATCH] " Thomas Huth
2017-01-04 9:08 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1479750670.9742.47.camel@redhat.com \
--to=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.