From: james_p_freyensee@linux.intel.com (J Freyensee)
Subject: [PATCH v3 1/2] nvmet-rdma: align to generic ib_event logging helper
Date: Wed, 23 Nov 2016 10:25:53 -0800 [thread overview]
Message-ID: <1479925553.5486.4.camel@linux.intel.com> (raw)
In-Reply-To: <1479893928-32445-2-git-send-email-maxg@mellanox.com>
On Wed, 2016-11-23@11:38 +0200, Max Gurtovoy wrote:
> Signed-off-by: Max Gurtovoy <maxg at mellanox.com>
> ---
> ?drivers/nvme/target/rdma.c |????3 ++-
> ?1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/nvme/target/rdma.c b/drivers/nvme/target/rdma.c
> index 005ef5d..ddbae24 100644
> --- a/drivers/nvme/target/rdma.c
> +++ b/drivers/nvme/target/rdma.c
> @@ -1129,7 +1129,8 @@ static void nvmet_rdma_qp_event(struct ib_event
> *event, void *priv)
> ? rdma_notify(queue->cm_id, event->event);
> ? break;
> ? default:
> - pr_err("received unrecognized IB QP event %d\n",
> event->event);
> + pr_err("received IB QP event: %s (%d)\n",
> + ???????ib_event_msg(event->event), event->event);
I liked the original print statement mentioning something that it hit
the default case ("received unrecognized IB QP event"). ?But if no one
else has a problem with it, then I'm ok with it.
next prev parent reply other threads:[~2016-11-23 18:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-23 9:38 [PATCH v3 0/2] align to generic ib_event logging helper Max Gurtovoy
2016-11-23 9:38 ` [PATCH v3 1/2] nvmet-rdma: " Max Gurtovoy
2016-11-23 18:25 ` J Freyensee [this message]
2016-11-24 11:19 ` Max Gurtovoy
2016-11-25 7:48 ` Christoph Hellwig
2016-11-27 9:28 ` Max Gurtovoy
2016-11-23 9:38 ` [PATCH v3 2/2] nvme-rdma: " Max Gurtovoy
2016-11-23 18:23 ` J Freyensee
2016-12-02 13:56 ` [PATCH v3 0/2] " Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1479925553.5486.4.camel@linux.intel.com \
--to=james_p_freyensee@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.