From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtprelay4.synopsys.com ([198.182.47.9]:42948 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933908AbcKWTrS (ORCPT ); Wed, 23 Nov 2016 14:47:18 -0500 From: Alexey Brodkin Subject: Re: [PATCH 3/6] arc: Use full path in KBUILD_IMAGE definition Date: Wed, 23 Nov 2016 19:40:15 +0000 Message-ID: <1479929955.3931.28.camel@synopsys.com> References: <20161122213434.14788-1-mmarek@suse.com> <20161122213434.14788-3-mmarek@suse.com> In-Reply-To: <20161122213434.14788-3-mmarek@suse.com> Content-Language: en-US Content-Type: text/plain; charset="utf-8" Content-ID: <20E8BE15EBBEAD4EA13E6FD9256F2B04@internal.synopsys.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 Sender: linux-kbuild-owner@vger.kernel.org List-ID: To: "mmarek@suse.com" Cc: "Vineet.Gupta1@synopsys.com" , "linux-kernel@vger.kernel.org" , "linux-kbuild@vger.kernel.org" , "linux-snps-arc@lists.infradead.org" SGkgTWljaGFsLA0KDQpPbiBUdWUsIDIwMTYtMTEtMjIgYXQgMjI6MzQgKzAxMDAsIE1pY2hhbCBN YXJlayB3cm90ZToNCj4gVGhlIEtCVUlMRF9JTUFHRSB2YXJpYWJsZSBpcyB1c2VkIGJ5IHRoZSBy cG0gYW5kIGRlYi1wa2cgdGFyZ2V0cywgd2hpY2gNCj4gZXhwZWN0IGl0IHRvIHBvaW50IHRvIHRo ZSBpbWFnZSBmaWxlIGluIHRoZSBidWlsZCBkaXJlY3RvcnkuIFRoZQ0KPiBidWlsZGRlYiBzY3Jp cHQgaGFzIGEgd29ya2Fyb3VuZCBmb3IgYXJjaGl0ZWN0dXJlcyB3aGljaCBvbmx5IHByb3ZpZGUN Cj4gdGhlIGJhc2VuYW1lLCBidXQgbGV0J3MgcHJvdmlkZSBhIGNsZWFuIGludGVyZmFjZSBmb3Ig cGFja2FnaW5nIHRvb2xzLg0KPiANCj4gQ2M6IFZpbmVldCBHdXB0YSA8dmd1cHRhQHN5bm9wc3lz LmNvbT4NCj4gQ2M6IGxpbnV4LXNucHMtYXJjQGxpc3RzLmluZnJhZGVhZC5vcmcNCj4gU2lnbmVk LW9mZi1ieTogTWljaGFsIE1hcmVrIDxtbWFyZWtAc3VzZS5jb20+DQo+IC0tLQ0KPiDCoGFyY2gv YXJjL01ha2VmaWxlIHwgNCArKy0tDQo+IMKgMSBmaWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygr KSwgMiBkZWxldGlvbnMoLSkNCj4gDQo+IGRpZmYgLS1naXQgYS9hcmNoL2FyYy9NYWtlZmlsZSBi L2FyY2gvYXJjL01ha2VmaWxlDQo+IGluZGV4IDE5Y2NlMjI2ZDFhOC4uNDRlZjM1ZDMzOTU2IDEw MDY0NA0KPiAtLS0gYS9hcmNoL2FyYy9NYWtlZmlsZQ0KPiArKysgYi9hcmNoL2FyYy9NYWtlZmls ZQ0KPiBAQCAtMTIzLDkgKzEyMyw5IEBAIGxpYnMteQkJKz0gYXJjaC9hcmMvbGliLyAkKExJQkdD QykNCj4gwqBib290CQk6PSBhcmNoL2FyYy9ib290DQo+IMKgDQo+IMKgI2RlZmF1bHQgdGFyZ2V0 IGZvciBtYWtlIHdpdGhvdXQgYW55IGFyZ3VtZW50cy4NCj4gLUtCVUlMRF9JTUFHRQk6PSBib290 cEltYWdlDQo+ICtLQlVJTERfSU1BR0UJOj0gJChib290KS9ib290cEltYWdlDQo+IMKgDQo+IC1h bGw6CSQoS0JVSUxEX0lNQUdFKQ0KPiArYWxsOglib290cEltYWdlDQo+IMKgYm9vdHBJbWFnZTog dm1saW51eA0KPiDCoA0KPiDCoGJvb3RfdGFyZ2V0cyArPSB1SW1hZ2UgdUltYWdlLmJpbiB1SW1h Z2UuZ3oNCg0KSSB0cmllZCB0byBmaW5kIGFueSBleGFtcGxlcyBvbiBob3cgdGhhdMKgS0JVSUxE X0lNQUdFIHRoaW5neSBpcyB1c2VkDQpidXQgdG8gbm8gYXZhaWwuIEl0IGxvb2tzIGxpa2UgZm9y IEFSQyAiYm9vdHBJbWFnZSIgbWFrZXMgbm90IG11Y2gNCnNlbnNlIGFuZCBpZiB5b3UgcmVhbGx5 IHdhbnQgdG8gZ2V0IHNvbWV0aGluZyB1c2VmdWwgaW4gLmRlYi8ucnBtDQptb3N0IHByb2JhYmx5 IHNvbWV0aGluZyBsaWtlIGJlbG93IG1heSB3b3JrIG11Y2ggYmV0dGVyOg0KLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tPjgtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQ0KS0JVSUxEX0lNQUdFCTo9 ICQoYm9vdCkvdUltYWdlDQotLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0+OC0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tDQoNCkFuZCBJIGRvbid0IGtub3cgY29udGV4dCBvZiBLQlVJTERfSU1BR0Ug dXNhZ2UgYnV0IGluDQpjYXNlIG9mIEFSQyBvdXIgZGVmYXVsdCB0YXJnZXQgaXMgInZtbGludXgi IHNvIEknbSBub3Qgc3VyZSB0aGVuIGlmDQpLQlVJTERfSU1BR0UgbWF5IHBvaW50IHRvIG5vbi1k ZWZhdWx0IHRhcmdldC4NCg0KRm9yIGV4YW1wbGUgaW4gImFyY2gvYXZyMzIvTWFrZWZpbGUiIEkg c2VlIG1vcmUgY29tcGxpY2F0ZWQgY29uc3RydWN0aW9uOg0KLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tPjgtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQ0KwqAgwqAgwqAgwqAgwqAgwqAgwqBLQlVJ TERfSU1BR0UgOj0gJChib290KS91SW1hZ2UNCnZtbGludXguZWxmOiBLQlVJTERfSU1BR0UgOj0g JChib290KS92bWxpbnV4LmVsZg0Kdm1saW51eC5jc286IEtCVUlMRF9JTUFHRSA6PSAkKGJvb3Qp L3ZtbGludXguY3NvDQp1SW1hZ2Uuc3JlYzogS0JVSUxEX0lNQUdFIDo9ICQoYm9vdCkvdUltYWdl LnNyZWMNCnVJbWFnZTrCoMKgwqDCoMKgwqBLQlVJTERfSU1BR0UgOj0gJChib290KS91SW1hZ2UN Ci0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLT44LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0NCmFu ZCBtYXkgaW1hZ2luZSB0aGF0IHdlIG5lZWQgc29tZXRoaW5nIHNpbWlsYXIgZm9yIEFSQyBvYnZp b3VzbHkgd2l0aA0KZGVmYXVsdCBiZWluZyAiJChib290KS92bWxpbnV4Ii4NCg0KLUFsZXhleQ== From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexey.Brodkin@synopsys.com (Alexey Brodkin) Date: Wed, 23 Nov 2016 19:40:15 +0000 Subject: [PATCH 3/6] arc: Use full path in KBUILD_IMAGE definition In-Reply-To: <20161122213434.14788-3-mmarek@suse.com> References: <20161122213434.14788-1-mmarek@suse.com> <20161122213434.14788-3-mmarek@suse.com> List-ID: Message-ID: <1479929955.3931.28.camel@synopsys.com> To: linux-snps-arc@lists.infradead.org Hi Michal, On Tue, 2016-11-22@22:34 +0100, Michal Marek wrote: > The KBUILD_IMAGE variable is used by the rpm and deb-pkg targets, which > expect it to point to the image file in the build directory. The > builddeb script has a workaround for architectures which only provide > the basename, but let's provide a clean interface for packaging tools. > > Cc: Vineet Gupta > Cc: linux-snps-arc at lists.infradead.org > Signed-off-by: Michal Marek > --- > ?arch/arc/Makefile | 4 ++-- > ?1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arc/Makefile b/arch/arc/Makefile > index 19cce226d1a8..44ef35d33956 100644 > --- a/arch/arc/Makefile > +++ b/arch/arc/Makefile > @@ -123,9 +123,9 @@ libs-y += arch/arc/lib/ $(LIBGCC) > ?boot := arch/arc/boot > ? > ?#default target for make without any arguments. > -KBUILD_IMAGE := bootpImage > +KBUILD_IMAGE := $(boot)/bootpImage > ? > -all: $(KBUILD_IMAGE) > +all: bootpImage > ?bootpImage: vmlinux > ? > ?boot_targets += uImage uImage.bin uImage.gz I tried to find any examples on how that?KBUILD_IMAGE thingy is used but to no avail. It looks like for ARC "bootpImage" makes not much sense and if you really want to get something useful in .deb/.rpm most probably something like below may work much better: ------------------------>8-------------------------- KBUILD_IMAGE := $(boot)/uImage ------------------------>8-------------------------- And I don't know context of KBUILD_IMAGE usage but in case of ARC our default target is "vmlinux" so I'm not sure then if KBUILD_IMAGE may point to non-default target. For example in "arch/avr32/Makefile" I see more complicated construction: ------------------------>8-------------------------- ? ? ? ? ? ? ?KBUILD_IMAGE := $(boot)/uImage vmlinux.elf: KBUILD_IMAGE := $(boot)/vmlinux.elf vmlinux.cso: KBUILD_IMAGE := $(boot)/vmlinux.cso uImage.srec: KBUILD_IMAGE := $(boot)/uImage.srec uImage:??????KBUILD_IMAGE := $(boot)/uImage ------------------------>8-------------------------- and may imagine that we need something similar for ARC obviously with default being "$(boot)/vmlinux". -Alexey