From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCHv3 0/5] ACL library Date: Sat, 14 Jun 2014 09:55:43 +0200 Message-ID: <1479982.fmX6nuUaYb@xps13> References: <1402658814-21881-1-git-send-email-konstantin.ananyev@intel.com> <1541041.MVudaz1CFn@xps13> <59AF69C657FD0841A61C55336867B5B01AA36227@IRSMSX103.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: "Richardson, Bruce" Return-path: In-Reply-To: <59AF69C657FD0841A61C55336867B5B01AA36227-kPTMFJFq+rELt2AQoY/u9bfspsVTdybXVpNB7YpNyf8@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" 2014-06-14 00:07, Richardson, Bruce: > From: Thomas Monjalon > > I've made the code style changes, move some configuration lines and added > > to BSD build (not tested). > > > I'd be a bit wary about adding it to the BSD build. I'm only running BSD in > a VM here, but there GCC fails to recognise the processor supports SSE4 > instruction sets when using "-march=native", and so fails to compile the > vector code - at least the vectorized PMD functions. That's why I've > explicitly disabled those in the latest version of the vector PMD patch, > and I would suggest doing the same for the ACL code for now. Actually, the configuration option didn't exist for BSD so I added it. It's better to explicitly disable it with an explanation in git history. Thanks -- Thomas