From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 331D2C54E90 for ; Thu, 22 May 2025 17:18:20 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uI9Xp-00080x-6g; Thu, 22 May 2025 13:17:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uI9Xl-00080O-Pu; Thu, 22 May 2025 13:17:22 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uI9Xj-0002ba-DX; Thu, 22 May 2025 13:17:21 -0400 Received: from pps.filterd (m0356517.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 54MDMWHV005432; Thu, 22 May 2025 17:17:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=MQKLnJ 1sgeGo7RgiSbemQCPsg7JK0Z/OOW96pp510RI=; b=fEOSvcG4JQ/lVogl51zwt7 bHj/TyaTwLbAMf6wOyM02i43MM7lFET1C+DT1Th/Y/cdOes+AkA+HpzWKYgYgJuR vSmGNfTwGyQR0ZOBF3OP89CpUPp9TsXmU35k22eP9buClZ3+7uquqaG3V7Rgq7QM KtSwUjfiZPpRHtJTL7zNr9ur+10tIvKIiHl/FRstaulpNLGgg1RFx8+DjE3HnFdZ Wv8ZKic/GursUt8oCqKFvRMgpZkeUkw+a682p3+Y31HQdS/ReYHVgJIQMchSynU6 XNTkczYnkwQBLG06lH3L/8fXp+B6F34EqvHWNFfOx+XbGcutgcWU75bjB6ghio/g == Received: from ppma21.wdc07v.mail.ibm.com (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 46smf9dnu2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 22 May 2025 17:17:16 +0000 (GMT) Received: from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1]) by ppma21.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 54MDiWq1024664; Thu, 22 May 2025 17:17:15 GMT Received: from smtprelay01.wdc07v.mail.ibm.com ([172.16.1.68]) by ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 46rwkraesq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 22 May 2025 17:17:15 +0000 Received: from smtpav01.dal12v.mail.ibm.com (smtpav01.dal12v.mail.ibm.com [10.241.53.100]) by smtprelay01.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 54MHHDIZ30540288 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 22 May 2025 17:17:13 GMT Received: from smtpav01.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 88C035805D; Thu, 22 May 2025 17:17:13 +0000 (GMT) Received: from smtpav01.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E118D58057; Thu, 22 May 2025 17:17:12 +0000 (GMT) Received: from [9.61.242.155] (unknown [9.61.242.155]) by smtpav01.dal12v.mail.ibm.com (Postfix) with ESMTP; Thu, 22 May 2025 17:17:12 +0000 (GMT) Message-ID: <147f3278-bd20-4339-9dff-bf6a43ea0a48@linux.ibm.com> Date: Thu, 22 May 2025 13:17:12 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH v9 3/4] hw/vfio/ap: Storing event information for an AP configuration change event To: =?UTF-8?Q?C=C3=A9dric_Le_Goater?= , qemu-devel@nongnu.org, qemu-s390x@nongnu.org Cc: pbonzini@redhat.com, cohuck@redhat.com, pasic@linux.ibm.com, jjherne@linux.ibm.com, borntraeger@linux.ibm.com, alex.williamson@redhat.com, thuth@redhat.com, akrowiak@linux.ibm.com References: <20250512180230.50129-1-rreyes@linux.ibm.com> <20250512180230.50129-4-rreyes@linux.ibm.com> <7d1699d4-6d7d-4de3-a0bc-6dd345d9c2dd@redhat.com> Content-Language: en-US From: Rorie Reyes In-Reply-To: <7d1699d4-6d7d-4de3-a0bc-6dd345d9c2dd@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: mDtllj6Nvg0loEztgNFm_KSvgi5ubMCJ X-Proofpoint-ORIG-GUID: mDtllj6Nvg0loEztgNFm_KSvgi5ubMCJ X-Authority-Analysis: v=2.4 cv=TbqWtQQh c=1 sm=1 tr=0 ts=682f5c1c cx=c_pps a=GFwsV6G8L6GxiO2Y/PsHdQ==:117 a=GFwsV6G8L6GxiO2Y/PsHdQ==:17 a=IkcTkHD0fZMA:10 a=dt9VzEwgFbYA:10 a=sWKEhP36mHoA:10 a=VnNF1IyMAAAA:8 a=lmh-DfHKxmGLPFDQqs4A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNTIyMDE3NCBTYWx0ZWRfX+Ye2Dh1jSNuO X4SIEX6dy4mx+XgsP35IA1B7tTpHvDfxTHt3ELMbo++wTpEAacwkwFQFYCD3EvIyMH22HDLNae1 HKDDXv/hXugjtCr3v6pWvnzcqud6pE4ejn3uX2S/MknR6Nnmt7Ewk3FUwS0UXI34j5UzSdEGJ4V pVFr8c+5LMiRlAnPTBiQsfvQAp8Ffc/S6fPeUPfln5h6yS27aGGC68nl/y28jUm8OXE3UeAvly6 zhgEP/oCzCs7Pg4/Ggag5doKOYealK8wpZHpOOIw/idqTqUw7mJoN2OSdxYFjyQqAK+jyBTf076 DsE2Cje5V37kwEFAwYFda7CCH+FJRYAjg63ygAc5Pu72ZasVVt+PYovcqmRFvQSjHWowzfqtvVm eK+fAdQv8tTcNNVyg9MVAb81d6KBvO/CMBcJQ1/6FpOLCsxdR0ADgW4YBgxmRq8Wnq7HgaVT X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-05-22_08,2025-05-22_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 bulkscore=0 phishscore=0 adultscore=0 spamscore=0 mlxlogscore=999 malwarescore=0 lowpriorityscore=0 suspectscore=0 priorityscore=1501 clxscore=1015 impostorscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505160000 definitions=main-2505220174 Received-SPF: pass client-ip=148.163.156.1; envelope-from=rreyes@linux.ibm.com; helo=mx0a-001b2d01.pphosted.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 5/22/25 9:30 AM, Cédric Le Goater wrote: > On 5/12/25 20:02, Rorie Reyes wrote: >> These functions can be invoked by the function that handles interception >> of the CHSC SEI instruction for requests indicating the accessibility of >> one or more adjunct processors has changed. >> >> Signed-off-by: Rorie Reyes >> --- >>   hw/vfio/ap.c                 | 39 ++++++++++++++++++++++++++++++++++++ >>   include/hw/s390x/ap-bridge.h | 22 ++++++++++++++++++++ >>   2 files changed, 61 insertions(+) >> >> diff --git a/hw/vfio/ap.c b/hw/vfio/ap.c >> index 5ea5dd9cca..4f88f80c54 100644 >> --- a/hw/vfio/ap.c >> +++ b/hw/vfio/ap.c >> @@ -96,6 +96,45 @@ static void vfio_ap_cfg_chg_notifier_handler(void >> *opaque) >>     } >>   +int ap_chsc_sei_nt0_get_event(void *res) >> +{ >> +    ChscSeiNt0Res *nt0_res  = (ChscSeiNt0Res *)res; >> +    APConfigChgEvent *cfg_chg_event; >> + >> +    if (!ap_chsc_sei_nt0_have_event()) { >> +        return 1; >> +    } >> + >> +    cfg_chg_event = QTAILQ_FIRST(&cfg_chg_events); >> +    memset(nt0_res, 0, sizeof(*nt0_res)); >> + >> +    QTAILQ_REMOVE(&cfg_chg_events, cfg_chg_event, next); > > btw, I don't know if this was discussed. Are we OK to manipulate the > 'cfg_chg_events' construct withou locking ? > I don't think it was discussed. Since I made it static, should we think about locking the construct? If so, would using 'static QemuMutex cfg_chg_events_lock;' to declare it and use 'qemu_mutex_lock()' and 'qemu_mutex_unlock()' to lock and unlock when needed? Tony, do you have any thoughts on this process? >> diff --git a/include/hw/s390x/ap-bridge.h b/include/hw/s390x/ap-bridge.h >> index 470e439a98..f4d838bf99 100644 >> --- a/include/hw/s390x/ap-bridge.h >> +++ b/include/hw/s390x/ap-bridge.h >> @@ -16,4 +16,26 @@ >>     void s390_init_ap(void); >>   +typedef struct ChscSeiNt0Res { >> +    uint16_t length; >> +    uint16_t code; >> +    uint8_t reserved1; >> +    uint16_t reserved2; >> +    uint8_t nt; >> +#define PENDING_EVENT_INFO_BITMASK 0x80; >> +    uint8_t flags; >> +    uint8_t reserved3; >> +    uint8_t rs; >> +    uint8_t cc; >> +} QEMU_PACKED ChscSeiNt0Res; >> + >> +#define NT0_RES_RESPONSE_CODE 1; >> +#define NT0_RES_NT_DEFAULT    0; >> +#define NT0_RES_RS_AP_CHANGE  5; >> +#define NT0_RES_CC_AP_CHANGE  3; > > > > please drop the ending ';' > > > Thanks, > > C. > Will drop in the next version