From: Johannes Berg <johannes@sipsolutions.net>
To: Arend Van Spriel <arend.vanspriel@broadcom.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] nl80211: provide minimum scheduled scan (plan) interval
Date: Fri, 25 Nov 2016 09:25:30 +0100 [thread overview]
Message-ID: <1480062330.4317.2.camel@sipsolutions.net> (raw)
In-Reply-To: <5c249c34-5e8c-093a-c5df-3507cabc8872@broadcom.com> (sfid-20161122_210634_601031_8D67F631)
Sorry, forgot to reply to this until Luca's email bumped it up...
On Tue, 2016-11-22 at 21:06 +0100, Arend Van Spriel wrote:
> Are we? Currently, the minimum is not checked in nl80211, but that
> does not say anything about the driver which might validate the
> interval as well and return an error.
Well, since drivers currently don't return an error (even if they
ignore the value!) that *does* change the API.
> What made me start looking at this is that in brcmfmac the interval
> in the request was ignored and a fixed interval was provisioned in
> the device. I wanted to fix that but was not sure if I needed to
> check it against our firmware min..max range and what the appropriate
> error handling should be. If silently changing what user-space is
> requesting is fine for this, I am happy to make it so. Preferably in
> nl80211.
I think (agreeing with Luca) bumping it up is fine.
johannes
next prev parent reply other threads:[~2016-11-25 8:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-22 13:31 [PATCH] nl80211: provide minimum scheduled scan (plan) interval Arend van Spriel
2016-11-22 13:38 ` Johannes Berg
2016-11-22 20:06 ` Arend Van Spriel
2016-11-25 8:25 ` Johannes Berg [this message]
2016-11-25 10:06 ` Arend van Spriel
2016-11-25 10:30 ` Luca Coelho
2016-11-25 8:04 ` Luca Coelho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1480062330.4317.2.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=arend.vanspriel@broadcom.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.