From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-f198.google.com (mail-io0-f198.google.com [209.85.223.198]) by kanga.kvack.org (Postfix) with ESMTP id B737F6B0069 for ; Fri, 25 Nov 2016 14:36:07 -0500 (EST) Received: by mail-io0-f198.google.com with SMTP id m203so135314784iom.6 for ; Fri, 25 Nov 2016 11:36:07 -0800 (PST) Received: from smtprelay.hostedemail.com (smtprelay0094.hostedemail.com. [216.40.44.94]) by mx.google.com with ESMTPS id w200si12356655ita.30.2016.11.25.11.36.07 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 25 Nov 2016 11:36:07 -0800 (PST) Message-ID: <1480102557.19726.33.camel@perches.com> Subject: Re: [PATCH 1/2] stacktrace: fix print_stack_trace printing timestamp twice From: Joe Perches Date: Fri, 25 Nov 2016 11:35:57 -0800 In-Reply-To: References: <9df5bd889e1b980d84aa41e7010e622005fd0665.1478632698.git.andreyknvl@google.com> <2a6c133d-a42e-34ca-108c-b1399b939d65@virtuozzo.com> Content-Type: text/plain; charset="ISO-8859-1" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Dmitry Vyukov , Andrey Ryabinin Cc: Andrey Konovalov , Alexander Potapenko , kasan-dev , "linux-mm@kvack.org" , LKML , Ingo Molnar , Kostya Serebryany , Peter Zijlstra On Fri, 2016-11-25 at 18:40 +0100, Dmitry Vyukov wrote: > But should we add KERN_CONT to print_ip_sym instead of duplicating it > everywhere? Or add print_ip_sym_cont? There are only a couple dozen uses of print_ip_sym. It might be better to use "[<%p>] %pS" directly everywhere and remove print_ip_sym instead to avoid the KERN_CONT and avoid all possible interleaved output. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755786AbcKYTg3 (ORCPT ); Fri, 25 Nov 2016 14:36:29 -0500 Received: from smtprelay0045.hostedemail.com ([216.40.44.45]:51108 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755235AbcKYTgV (ORCPT ); Fri, 25 Nov 2016 14:36:21 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::::,RULES_HIT:41:355:379:541:599:960:968:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1537:1566:1593:1594:1711:1714:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3622:3865:3866:3867:3868:3872:4321:5007:10004:10400:10848:11026:11232:11658:11914:12296:12740:12760:13069:13161:13229:13311:13357:13439:14659:14721:21080:21220:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: anger31_51b67e2ed8856 X-Filterd-Recvd-Size: 1719 Message-ID: <1480102557.19726.33.camel@perches.com> Subject: Re: [PATCH 1/2] stacktrace: fix print_stack_trace printing timestamp twice From: Joe Perches To: Dmitry Vyukov , Andrey Ryabinin Cc: Andrey Konovalov , Alexander Potapenko , kasan-dev , "linux-mm@kvack.org" , LKML , Ingo Molnar , Kostya Serebryany , Peter Zijlstra Date: Fri, 25 Nov 2016 11:35:57 -0800 In-Reply-To: References: <9df5bd889e1b980d84aa41e7010e622005fd0665.1478632698.git.andreyknvl@google.com> <2a6c133d-a42e-34ca-108c-b1399b939d65@virtuozzo.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.1-0ubuntu2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2016-11-25 at 18:40 +0100, Dmitry Vyukov wrote: > But should we add KERN_CONT to print_ip_sym instead of duplicating it > everywhere? Or add print_ip_sym_cont? There are only a couple dozen uses of print_ip_sym. It might be better to use "[<%p>] %pS" directly everywhere and remove print_ip_sym instead to avoid the KERN_CONT and avoid all possible interleaved output.