From: Simon Glass <sjg@chromium.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 2/9] net: designware: Adjust dw_adjust_link() to return an error
Date: Sun, 27 Nov 2016 10:01:42 -0700 [thread overview]
Message-ID: <1480266109-7209-3-git-send-email-sjg@chromium.org> (raw)
In-Reply-To: <1480266109-7209-1-git-send-email-sjg@chromium.org>
This function can fail, so return the error if there is one.
Signed-off-by: Simon Glass <sjg@chromium.org>
---
Changes in v3:
- Add new patch to adjust dw_adjust_link() to return an error
Changes in v2: None
drivers/net/designware.c | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/net/designware.c b/drivers/net/designware.c
index 6ef36bc..ebcef8b 100644
--- a/drivers/net/designware.c
+++ b/drivers/net/designware.c
@@ -230,14 +230,14 @@ static int _dw_write_hwaddr(struct dw_eth_dev *priv, u8 *mac_id)
return 0;
}
-static void dw_adjust_link(struct eth_mac_regs *mac_p,
- struct phy_device *phydev)
+static int dw_adjust_link(struct dw_eth_dev *priv, struct eth_mac_regs *mac_p,
+ struct phy_device *phydev)
{
u32 conf = readl(&mac_p->conf) | FRAMEBURSTENABLE | DISABLERXOWN;
if (!phydev->link) {
printf("%s: No link.\n", phydev->dev->name);
- return;
+ return 0;
}
if (phydev->speed != 1000)
@@ -256,6 +256,8 @@ static void dw_adjust_link(struct eth_mac_regs *mac_p,
printf("Speed: %d, %s duplex%s\n", phydev->speed,
(phydev->duplex) ? "full" : "half",
(phydev->port == PORT_FIBRE) ? ", fiber mode" : "");
+
+ return 0;
}
static void _dw_eth_halt(struct dw_eth_dev *priv)
@@ -321,7 +323,9 @@ static int _dw_eth_init(struct dw_eth_dev *priv, u8 *enetaddr)
return ret;
}
- dw_adjust_link(mac_p, priv->phydev);
+ ret = dw_adjust_link(priv, mac_p, priv->phydev);
+ if (ret)
+ return ret;
if (!priv->phydev->link)
return -EIO;
--
2.8.0.rc3.226.g39d4020
next prev parent reply other threads:[~2016-11-27 17:01 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-27 17:01 [U-Boot] [PATCH v3 0/9] From Simon: Simon Glass
2016-11-27 17:01 ` [U-Boot] [PATCH v3 1/9] net: designware: Export various functions/struct to allow subclassing Simon Glass
2016-11-29 22:28 ` Joe Hershberger
2016-11-27 17:01 ` Simon Glass [this message]
2016-11-29 22:10 ` [U-Boot] [PATCH v3 2/9] net: designware: Adjust dw_adjust_link() to return an error Joe Hershberger
2016-11-27 17:01 ` [U-Boot] [PATCH v3 3/9] net: designware: Split the link init into a separate function Simon Glass
2016-11-29 22:28 ` Joe Hershberger
2016-11-27 17:01 ` [U-Boot] [PATCH v3 4/9] net: designware: Export the operation functions Simon Glass
2016-11-29 22:31 ` Joe Hershberger
2016-11-27 17:01 ` [U-Boot] [PATCH v3 5/9] net: gmac_rk3288: Add RK3288 GMAC driver Simon Glass
2016-11-29 22:34 ` Joe Hershberger
2016-11-27 17:01 ` [U-Boot] [PATCH v3 6/9] rockchip: Enable networking support on rock2 and firefly Simon Glass
2016-11-27 17:01 ` [U-Boot] [PATCH v3 7/9] rockchip: evb-rk3339: Enable DHCP Simon Glass
2016-11-29 10:22 ` Heiko Stübner
2016-11-27 17:01 ` [U-Boot] [PATCH v3 8/9] rockchip: Add PXE and DHCP to the default boot targets Simon Glass
2016-11-27 17:01 ` [U-Boot] [PATCH v3 9/9] rockchip: Drop Ethernet from the TODO Simon Glass
2016-11-29 23:45 ` [U-Boot] [PATCH v3 0/9] From Simon: Heiko Stübner
2016-11-30 2:47 ` Simon Glass
2016-11-30 11:52 ` Heiko Stübner
2016-11-30 19:50 ` Heiko Stübner
2016-12-01 2:20 ` Simon Glass
2016-12-01 15:30 ` Heiko Stübner
2016-12-26 5:23 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1480266109-7209-3-git-send-email-sjg@chromium.org \
--to=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.