All of lore.kernel.org
 help / color / mirror / Atom feed
From: See, Chin Liang <chin.liang.see@intel.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 8/8] spi: cadence_qspi: Support specifying the sample edge used
Date: Mon, 28 Nov 2016 13:37:01 +0000	[thread overview]
Message-ID: <1480340219.1847.1.camel@intel.com> (raw)
In-Reply-To: <1480084688-24677-9-git-send-email-phil.edworthy@renesas.com>

Hi Phil,

On Jum, 2016-11-25 at 14:38 +0000, Phil Edworthy wrote:
> Whilst at it, move the code to read the "sram-size" property
> into the other code that reads properties from the node, rather
> than the SF subnode.
> 
> Also change the code to use a bool for the bypass arg.
> 
> Signed-off-by: Phil Edworthy <phil.edworthy@renesas.com>
> 
> ---
> v2:
> ?Change name of DT prop and provide details of what it does.
> ?Whilst at it, move the code to read the "sram-size" property
> ?into the other code that reads properties from the node, rather
> ?than the SF subnode.
> 
> ?Also change the code to use a bool for the bypass arg.
> ---
> ?doc/device-tree-bindings/spi/spi-cadence.txt |??2 ++
> ?drivers/spi/cadence_qspi.c???????????????????| 13 +++++++++----
> ?drivers/spi/cadence_qspi.h???????????????????|??3 ++-
> ?drivers/spi/cadence_qspi_apb.c???????????????|??8 +++++++-
> ?4 files changed, 20 insertions(+), 6 deletions(-)
> 

[..]

> diff --git a/drivers/spi/cadence_qspi_apb.c
> b/drivers/spi/cadence_qspi_apb.c
> index 56ad952..e43973c 100644
> --- a/drivers/spi/cadence_qspi_apb.c
> +++ b/drivers/spi/cadence_qspi_apb.c
> @@ -98,6 +98,7 @@
> ?#define????????CQSPI_REG_RD_DATA_CAPTURE_BYPASS????????BIT(0)
> ?#define????????CQSPI_REG_RD_DATA_CAPTURE_DELAY_LSB?????1
> ?#define????????CQSPI_REG_RD_DATA_CAPTURE_DELAY_MASK????0xF
> +#define????????CQSPI_REG_RD_DATA_CAPTURE_EDGE??????????BIT(5)


Actually we don't have this edge bit at SOCFPGA.
But no harm as its unused bit at SOCFPGA today

Thanks
Chin Liang

  parent reply	other threads:[~2016-11-28 13:37 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-25 14:38 [U-Boot] [PATCH v2 0/8] SF: Cadence QSPI driver fixes and clean up Phil Edworthy
2016-11-25 14:38 ` [U-Boot] [PATCH v2 1/8] spi: cadence_qspi: Fix clearing of pol/pha bits Phil Edworthy
2016-11-25 14:56   ` Marek Vasut
2016-11-25 15:29   ` Jagan Teki
2016-11-25 15:34     ` Phil Edworthy
2016-11-25 14:38 ` [U-Boot] [PATCH v2 2/8] spi: cadence_qspi: Fix baud rate calculation Phil Edworthy
2016-11-25 14:57   ` Marek Vasut
2016-11-25 15:19     ` Phil Edworthy
2016-11-25 15:53       ` Marek Vasut
2016-11-25 16:07         ` Jagan Teki
2016-11-25 15:41   ` Jagan Teki
2016-11-25 16:05     ` Phil Edworthy
2016-11-25 14:38 ` [U-Boot] [PATCH v2 3/8] spi: cadence_qspi: Better debug information on the SPI clock rate Phil Edworthy
2016-11-25 14:58   ` Marek Vasut
2016-11-25 14:38 ` [U-Boot] [PATCH v2 4/8] spi: cadence_qspi: Use #define for bits instead of bit shifts Phil Edworthy
2016-11-25 14:59   ` Marek Vasut
2016-11-25 15:22     ` Phil Edworthy
2016-11-25 16:06   ` Jagan Teki
2016-11-25 14:38 ` [U-Boot] [PATCH v2 5/8] spi: cadence_qspi: Clean up the #define names Phil Edworthy
2016-11-25 15:01   ` Marek Vasut
2016-11-25 14:38 ` [U-Boot] [PATCH v2 6/8] spi: cadence_qspi: Remove returns from end of void functions Phil Edworthy
2016-11-25 15:01   ` Marek Vasut
2016-11-25 14:38 ` [U-Boot] [PATCH v2 7/8] spi: cadence_qspi: Fix CS timings Phil Edworthy
2016-11-25 15:04   ` Marek Vasut
2016-11-28 12:48   ` See, Chin Liang
2016-11-29 10:13     ` Phil Edworthy
2016-11-25 14:38 ` [U-Boot] [PATCH v2 8/8] spi: cadence_qspi: Support specifying the sample edge used Phil Edworthy
2016-11-25 15:05   ` Marek Vasut
2016-11-25 15:24     ` Phil Edworthy
2016-11-28 13:37   ` See, Chin Liang [this message]
2016-11-28  8:07 ` [U-Boot] [PATCH v2 0/8] SF: Cadence QSPI driver fixes and clean up Jagan Teki
2016-11-28 12:50   ` Marek Vasut
2016-11-28 13:32     ` Jagan Teki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1480340219.1847.1.camel@intel.com \
    --to=chin.liang.see@intel.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.