From: Patrick Ohly <patrick.ohly@intel.com>
To: Jose Lamego <jose.a.lamego@linux.intel.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH V2] scripts.send-pull-request: Avoid multiple chain headers
Date: Mon, 28 Nov 2016 22:34:03 +0100 [thread overview]
Message-ID: <1480368843.6873.215.camel@intel.com> (raw)
In-Reply-To: <967933e7-9f2e-a960-4699-e4e8f2d39e68@linux.intel.com>
On Mon, 2016-11-28 at 14:28 -0600, Jose Lamego wrote:
> Agree. Please provide feedback about below comments and I will submit a
> v3 patch.
>
> On 11/28/2016 01:47 PM, Patrick Ohly wrote:
> > On Mon, 2016-11-28 at 10:23 -0600, Jose Lamego wrote:
> More than 1 "In-Reply-To" and "References" message headers are in
> violation of rfc2822 [1] and may cause that some email-related
> applications do not point to the appropriate root message in a
> conversation/series.
Fixing that makes sense. Just add it as reason and the "why" part is
covered.
> > And I don't understand why this proposed change has the described
> > effect. Does changing the threading parameters change the output of "git
> > send-email" and thus indirectly the mail headers of the following
> > patches?
The "how" part still isn't clear to me. Perhaps I'm just dumb, but would
you bear with me and explain a bit more how changing the sending of the
cover letter affects sending of the patches?
As it isn't obvious, perhaps even add a comment to the script explaining
it.
--
Best Regards, Patrick Ohly
The content of this message is my personal opinion only and although
I am an employee of Intel, the statements I make here in no way
represent Intel's position on the issue, nor am I authorized to speak
on behalf of Intel on this matter.
next prev parent reply other threads:[~2016-11-28 21:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-25 20:30 [PATCH] scripts.send-pull-request: Avoid multiple chain headers Jose Lamego
2016-11-28 16:23 ` [PATCH V2] " Jose Lamego
2016-11-28 19:47 ` Patrick Ohly
2016-11-28 20:28 ` Jose Lamego
2016-11-28 21:34 ` Patrick Ohly [this message]
2016-11-28 22:35 ` Jose Lamego
2016-11-29 8:51 ` Patrick Ohly
2016-11-29 8:55 ` [PATCH V3] scripts/send-pull-request: " Patrick Ohly
2016-11-29 14:51 ` [PATCH V2] scripts.send-pull-request: " Jose Lamego
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1480368843.6873.215.camel@intel.com \
--to=patrick.ohly@intel.com \
--cc=jose.a.lamego@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.