From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Convert vm->dev backpointer to vm->i915
Date: Tue, 29 Nov 2016 12:54:12 +0200 [thread overview]
Message-ID: <1480416852.16566.0.camel@linux.intel.com> (raw)
In-Reply-To: <20161129095008.32622-1-chris@chris-wilson.co.uk>
On ti, 2016-11-29 at 09:50 +0000, Chris Wilson wrote:
> 99% of the time we access i915_address_space->dev we want the i915
> device and not the drm device, so let's store the drm_i915_private
> backpointer instead. The only real complication here are the inlines
> in i915_vma.h where drm_i915_private is not yet defined and so we have
> to choose an alternate path for our asserts.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Agreed. i915_vma.h can be untangled in the future.
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-11-29 10:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-29 9:50 [PATCH] drm/i915: Convert vm->dev backpointer to vm->i915 Chris Wilson
2016-11-29 10:54 ` Joonas Lahtinen [this message]
2016-11-29 11:46 ` Chris Wilson
2016-11-29 12:42 ` [PATCH] drm/i915: Fix tracepoint compilation Chris Wilson
2016-11-29 12:45 ` Michał Winiarski
2016-11-29 12:57 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1480416852.16566.0.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.