From: "Keller, Jacob E" <jacob.e.keller@intel.com>
To: "gitster@pobox.com" <gitster@pobox.com>,
"jacob.keller@gmail.com" <jacob.keller@gmail.com>
Cc: "git@vger.kernel.org" <git@vger.kernel.org>,
"jonathantanmy@google.com" <jonathantanmy@google.com>
Subject: Re: [PATCH 0/2] add format specifiers to display trailers
Date: Tue, 29 Nov 2016 18:43:15 +0000 [thread overview]
Message-ID: <1480444993.3154.3.camel@intel.com> (raw)
In-Reply-To: <xmqqwpfwkar2.fsf@gitster.mtv.corp.google.com>
On Mon, 2016-11-21 at 09:23 -0800, Junio C Hamano wrote:
> Jacob Keller <jacob.keller@gmail.com> writes:
>
> > > We have %s and %b so that we can reconstruct the whole thing by
> > > using both. It is unclear how %bT fits in this picture. I
> > > wonder
> > > if we also need another placeholder that expands to the body of
> > > the
> > > message without the trailer---otherwise the whole set would
> > > become
> > > incoherent, no?
> >
> > I'm not entirely sure what to do here. I just wanted a way to
> > easily
> > format "just the trailers" of a message. We could add something
> > that
> > formats just the non-trailers, that's not too difficult. Not really
> > sure what I'd call it though.
>
> I was wondering if %(log:<name of a part>) was a better way to go.
>
> %(log:title) and %(log:body) would be equivalents of traditional %s
> and %b, and %(log:body) in turn would be a shorter way to write
> %(log:description)%+(log:trailer), i.e. show the message body, and
> if there is a trailer block, add it after adding a blank line.
>
> Or something like that?
That would work for me.
Thanks,
Jake
next prev parent reply other threads:[~2016-11-29 18:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-18 23:08 [PATCH 0/2] add format specifiers to display trailers Jacob Keller
2016-11-18 23:08 ` [PATCH 1/2] pretty: add %bT format for displaying trailers of a commit message Jacob Keller
2016-11-18 23:08 ` [PATCH 2/2] ref-filter: add support to display trailers as part of contents Jacob Keller
2016-11-18 23:38 ` [PATCH 0/2] add format specifiers to display trailers Junio C Hamano
2016-11-18 23:42 ` Jacob Keller
2016-11-21 17:23 ` Junio C Hamano
2016-11-29 18:43 ` Keller, Jacob E [this message]
2016-11-21 20:47 ` [PATCH] doc: mention user-configured trailers Jonathan Tan
2016-11-21 21:22 ` Junio C Hamano
-- strict thread matches above, loose matches on Subject: below --
2016-11-19 0:58 [PATCH 0/2] add format specifiers to display trailers Jacob Keller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1480444993.3154.3.camel@intel.com \
--to=jacob.e.keller@intel.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jacob.keller@gmail.com \
--cc=jonathantanmy@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.