All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robert Foss <robert.foss@collabora.com>
To: Tomeu Vizoso <tomeu.vizoso@collabora.com>,
	Intel GFX discussion <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH i-g-t 0/2] Improve error report when there are less overlays than expected
Date: Tue, 29 Nov 2016 15:54:13 -0500	[thread overview]
Message-ID: <1480452853.29774.26.camel@collabora.com> (raw)
In-Reply-To: <1479906286-6223-1-git-send-email-tomeu.vizoso@collabora.com>

Hi tomeu,

This series looks good to me, feel free to add my r-b.


Rob.

> Hi,
> 
> kms_plane_scaling would happily try to use the cursor plane as if it
> was an
> overlay, and the first signal of it would be the kernel refusing the
> SetPlane
> call because of the pixel format not matching.
> 
> To improve this situation, we check the format of the framebuffer
> before
> calling SetPlane (printing the supported formats), and skip the test
> if there
> aren't enough overlay planes.
> 
> Thanks,
> 
> Tomeu
> 
> Tomeu Vizoso (2):
>   lib: Check format of framebuffer before SetPlane
>   kms_plane_scaling: Skip if we don't have enough overlays
> 
>  lib/igt_kms.c             | 35 +++++++++++++++++++++++++++++++++++
>  tests/kms_plane_scaling.c |  4 ++++
>  2 files changed, 39 insertions(+)
> 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

      parent reply	other threads:[~2016-11-29 20:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-23 13:04 [PATCH i-g-t 0/2] Improve error report when there are less overlays than expected Tomeu Vizoso
2016-11-23 13:04 ` [PATCH i-g-t 1/2] lib: Check format of framebuffer before SetPlane Tomeu Vizoso
2016-11-23 13:04 ` [PATCH i-g-t 2/2] kms_plane_scaling: Skip if we don't have enough overlays Tomeu Vizoso
2016-11-29 20:54 ` Robert Foss [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1480452853.29774.26.camel@collabora.com \
    --to=robert.foss@collabora.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=tomeu.vizoso@collabora.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.