All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Michael Ellerman <mpe@ellerman.id.au>,
	linuxppc dev list <linuxppc-dev@lists.ozlabs.org>,
	"stewart@linux.vnet.ibm.com" <stewart@linux.vnet.ibm.com>
Subject: Re: [PATCH] powerpc/opal-irqchip: Use interrupt names if present
Date: Wed, 30 Nov 2016 19:25:24 +1100	[thread overview]
Message-ID: <1480494324.3459.9.camel@kernel.crashing.org> (raw)
In-Reply-To: <1480494084.3459.7.camel@kernel.crashing.org>

On Wed, 2016-11-30 at 19:21 +1100, Benjamin Herrenschmidt wrote:
> 
> There isn't one. The existing "opal-interrupts" from day one was a
> bit
> weird anyway, it's not a proper "interrupts" property to begin with,
> but it's unfixable now. Also I don't think there's a generic way to
> name interrupts either.
> 
> So for this specific case, just adding a new prop with a string-list
> matching 1:1 the entries in "opal-interrupts" is the most logical
> choice.

I spoke too soon... people have come up with an "interrupt-names"
property that matches a corresponding standard "interrupts" property.

The format is the same, a string-list with an entry per entry in
"interrupts".

So we have choices here... we could use the standard for both, making
OPAL generate both the old property and the new property "pair", then
make the code in linux look for the new one(s) and fallback, or we can
just add opal-interrupt-names, which is less churn but keeps it non-
standard.

I do have a soft-spot for going down the standard path even if it means
effectively duplicating the information between two properties. We'll
probably never be able to get rid of the old one, unless we backport
enough to make the new one mandatory for P9 in which case skiboot can
drop the "legacy" one on P9 and later.

Cheers,
Ben

  reply	other threads:[~2016-11-30  8:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-29 23:56 [PATCH] powerpc/opal-irqchip: Use interrupt names if present Benjamin Herrenschmidt
2016-11-30  8:07 ` Michael Ellerman
2016-11-30  8:21   ` Benjamin Herrenschmidt
2016-11-30  8:25     ` Benjamin Herrenschmidt [this message]
  -- strict thread matches above, loose matches on Subject: below --
2017-02-06  5:07 Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1480494324.3459.9.camel@kernel.crashing.org \
    --to=benh@kernel.crashing.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mpe@ellerman.id.au \
    --cc=stewart@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.