From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Alexander Stein <alexander.stein@systec-electronic.com>,
Jarkko Nikula <jarkko.nikula@linux.intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Wolfram Sang <wsa@the-dreams.de>
Cc: linux-i2c@vger.kernel.org
Subject: Re: [PATCH 1/1] i2c: designware-pcidrv: Add 10bit address feature to medfield/merrifield
Date: Wed, 30 Nov 2016 18:11:45 +0200 [thread overview]
Message-ID: <1480522305.21899.54.camel@linux.intel.com> (raw)
In-Reply-To: <1480517310-28401-1-git-send-email-alexander.stein@systec-electronic.com>
On Wed, 2016-11-30 at 15:48 +0100, Alexander Stein wrote:
> Both Merrifield TRM and Medfiel TRM state:
Typo here, should be Medfield
> "Both 7-bit and 10-bit addressing modes are supported."
Other that that
Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Signed-off-by: Alexander Stein <alexander.stein@systec-electronic.com>
> ---
> drivers/i2c/busses/i2c-designware-pcidrv.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/i2c/busses/i2c-designware-pcidrv.c
> b/drivers/i2c/busses/i2c-designware-pcidrv.c
> index 300802e7..d6423cf 100644
> --- a/drivers/i2c/busses/i2c-designware-pcidrv.c
> +++ b/drivers/i2c/busses/i2c-designware-pcidrv.c
> @@ -141,6 +141,7 @@ static struct dw_pci_controller
> dw_pci_controllers[] = {
> .bus_cfg = INTEL_MID_STD_CFG |
> DW_IC_CON_SPEED_FAST,
> .tx_fifo_depth = 32,
> .rx_fifo_depth = 32,
> + .functionality = I2C_FUNC_10BIT_ADDR,
> .clk_khz = 25000,
> .setup = mfld_setup,
> },
> @@ -149,6 +150,7 @@ static struct dw_pci_controller
> dw_pci_controllers[] = {
> .bus_cfg = INTEL_MID_STD_CFG | DW_IC_CON_SPEED_FAST,
> .tx_fifo_depth = 64,
> .rx_fifo_depth = 64,
> + .functionality = I2C_FUNC_10BIT_ADDR,
> .scl_sda_cfg = &mrfld_config,
> .setup = mrfld_setup,
> },
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
prev parent reply other threads:[~2016-11-30 16:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-30 14:48 [PATCH 1/1] i2c: designware-pcidrv: Add 10bit address feature to medfield/merrifield Alexander Stein
2016-11-30 16:11 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1480522305.21899.54.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=alexander.stein@systec-electronic.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=linux-i2c@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.