All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mukesh Ojha <mukesh02@linux.vnet.ibm.com>
To: linuxppc-dev@lists.ozlabs.org
Cc: Mukesh Ojha <mukesh02@linux.vnet.ibm.com>
Subject: [PATCH 2/2] powerpc/powernv/opal-dump : Use IRQ_HANDLED instead of numbers in interrupt handler
Date: Thu,  1 Dec 2016 14:38:09 +0530	[thread overview]
Message-ID: <1480583289-6380-2-git-send-email-mukesh02@linux.vnet.ibm.com> (raw)
In-Reply-To: <1480583289-6380-1-git-send-email-mukesh02@linux.vnet.ibm.com>

Converts all the return explicit number to a more proper IRQ_HANDLED,
which looks proper incase of interrupt handler returning case.

Signed-off-by: Mukesh Ojha <mukesh02@linux.vnet.ibm.com>
Reviewed-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com>
---
 arch/powerpc/platforms/powernv/opal-dump.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/arch/powerpc/platforms/powernv/opal-dump.c b/arch/powerpc/platforms/powernv/opal-dump.c
index ae32212..71cf907 100644
--- a/arch/powerpc/platforms/powernv/opal-dump.c
+++ b/arch/powerpc/platforms/powernv/opal-dump.c
@@ -371,13 +371,12 @@ static irqreturn_t process_dump(int irq, void *data)
 {
 	int rc;
 	uint32_t dump_id, dump_size, dump_type;
-	struct dump_obj *dump;
 	char name[22];
 	struct kobject *kobj;
 
 	rc = dump_read_info(&dump_id, &dump_size, &dump_type);
 	if (rc != OPAL_SUCCESS)
-		return rc;
+		return IRQ_HANDLED;
 
 	sprintf(name, "0x%x-0x%x", dump_type, dump_id);
 
@@ -389,12 +388,10 @@ static irqreturn_t process_dump(int irq, void *data)
 	if (kobj) {
 		/* Drop reference added by kset_find_obj() */
 		kobject_put(kobj);
-		return 0;
+		return IRQ_HANDLED;
 	}
 
-	dump = create_dump_obj(dump_id, dump_size, dump_type);
-	if (!dump)
-		return -1;
+	create_dump_obj(dump_id, dump_size, dump_type);
 
 	return IRQ_HANDLED;
 }
-- 
2.7.4

  reply	other threads:[~2016-12-01  9:08 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-01  9:08 [PATCH 1/2] powerpc/powernv/opal-dump : Handles opal_dump_info properly Mukesh Ojha
2016-12-01  9:08 ` Mukesh Ojha [this message]
2017-02-15  3:18   ` [PATCH 2/2] powerpc/powernv/opal-dump : Use IRQ_HANDLED instead of numbers in interrupt handler Jeremy Kerr
2017-02-15 10:27     ` Mukesh Ojha
2017-02-16  2:40       ` Jeremy Kerr
2017-02-20 13:19         ` Mukesh Ojha
2017-02-27  0:16           ` Jeremy Kerr
2017-02-15  5:08   ` Stewart Smith
2017-02-15  6:18     ` Mukesh Ojha
2016-12-06  6:37 ` [PATCH 1/2] powerpc/powernv/opal-dump : Handles opal_dump_info properly Mukesh Ojha
2017-02-13  6:32   ` Mukesh Ojha
2017-02-15  3:18 ` Jeremy Kerr
2017-02-15  5:04 ` Stewart Smith

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1480583289-6380-2-git-send-email-mukesh02@linux.vnet.ibm.com \
    --to=mukesh02@linux.vnet.ibm.com \
    --cc=linuxppc-dev@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.