From: "Conselvan De Oliveira, Ander" <ander.conselvan.de.oliveira@intel.com>
To: "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>
Cc: "Vetter, Daniel" <daniel.vetter@intel.com>
Subject: Re: [PATCH] drm/i915: Fix intel_psr_init() kerneldoc
Date: Fri, 2 Dec 2016 07:57:15 +0000 [thread overview]
Message-ID: <1480665435.4361.1.camel@intel.com> (raw)
In-Reply-To: <1480420127-11382-1-git-send-email-ander.conselvan.de.oliveira@intel.com>
On Tue, 2016-11-29 at 13:48 +0200, Ander Conselvan de Oliveira wrote:
> In commit c39055b072f8 ("drm/i915: Pass dev_priv to
> intel_setup_outputs()"), I forgot to update the kerneldoc for
> intel_psr_init() init, leading to warnings when building the
> documentation:
>
> drivers/gpu/drm/i915/intel_psr.c:822: warning: No description found for parameter 'dev_priv'
> drivers/gpu/drm/i915/intel_psr.c:822: warning: Excess function parameter 'dev' description in 'intel_psr_init'
>
> Fixes: c39055b072f8 ("drm/i915: Pass dev_priv to intel_setup_outputs()")
> Cc: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: Daniel Vetter <daniel.vetter@intel.com>
> Cc: Jani Nikula <jani.nikula@linux.intel.com>
> Cc: intel-gfx@lists.freedesktop.org
> Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
Pushed with Daniel's irc r-b.
Ander
> ---
> drivers/gpu/drm/i915/intel_psr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_psr.c
> b/drivers/gpu/drm/i915/intel_psr.c
> index 5c3616e..d5f8d03 100644
> --- a/drivers/gpu/drm/i915/intel_psr.c
> +++ b/drivers/gpu/drm/i915/intel_psr.c
> @@ -813,7 +813,7 @@ void intel_psr_flush(struct drm_i915_private *dev_priv,
>
> /**
> * intel_psr_init - Init basic PSR work and mutex.
> - * @dev: DRM device
> + * @dev_priv: i915 device private
> *
> * This function is called only once at driver load to initialize basic
> * PSR stuff.
---------------------------------------------------------------------
Intel Finland Oy
Registered Address: PL 281, 00181 Helsinki
Business Identity Code: 0357606 - 4
Domiciled in Helsinki
This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-12-02 7:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-23 13:48 [PATCH] drm/i915: Pass dev_priv to intel_setup_outputs() Ander Conselvan de Oliveira
2016-11-23 13:59 ` Ville Syrjälä
2016-11-23 14:21 ` [PATCH v2] " Ander Conselvan de Oliveira
2016-11-24 3:44 ` kbuild test robot
2016-11-29 9:09 ` Daniel Vetter
2016-11-29 11:48 ` [PATCH] drm/i915: Fix intel_psr_init() kerneldoc Ander Conselvan de Oliveira
2016-11-30 1:29 ` kbuild test robot
2016-11-30 8:36 ` Ander Conselvan De Oliveira
2016-12-05 18:01 ` [lkp] " Ye Xiaolong
2016-12-08 11:15 ` Ander Conselvan De Oliveira
2016-12-02 7:57 ` Conselvan De Oliveira, Ander [this message]
2016-11-23 16:46 ` ✓ Fi.CI.BAT: success for drm/i915: Pass dev_priv to intel_setup_outputs() (rev2) Patchwork
2016-11-25 15:05 ` Ander Conselvan De Oliveira
2016-11-29 14:53 ` ✓ Fi.CI.BAT: success for drm/i915: Pass dev_priv to intel_setup_outputs() (rev3) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1480665435.4361.1.camel@intel.com \
--to=ander.conselvan.de.oliveira@intel.com \
--cc=daniel.vetter@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.