All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: Laszlo Ersek <lersek@redhat.com>
Cc: qemu devel list <qemu-devel@nongnu.org>,
	"Gabriel L. Somlo" <somlo@cmu.edu>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Igor Mammedov <imammedo@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v4 2/7] fw-cfg: turn FW_CFG_FILE_SLOTS into a device property
Date: Fri, 02 Dec 2016 12:10:38 +0100	[thread overview]
Message-ID: <1480677038.13905.9.camel@redhat.com> (raw)
In-Reply-To: <20161201170624.26496-3-lersek@redhat.com>

On Do, 2016-12-01 at 18:06 +0100, Laszlo Ersek wrote:
> We'd like to raise the value of FW_CFG_FILE_SLOTS. Doing it naively could
> lead to problems with backward migration: a more recent QEMU (running an
> older machine type) would allow the guest, in fw_cfg_select(), to select a
> high key value that is unavailable in the same machine type implemented by
> the older (target) QEMU.

I don't think we need this.  fw_cfg changes are guest-visible so they
must not happen for a given machine type.  So if current machine types
don't hit the limit that should continue to be the case even if we
simply raise FW_CFG_FILE_SLOTS.

But we have to take care that new files show up on new machine types
only.

cheers,
  Gerd

  reply	other threads:[~2016-12-02 11:10 UTC|newest]

Thread overview: 63+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-01 17:06 [Qemu-arm] [PATCH v4 0/7] q35: add negotiable broadcast SMI Laszlo Ersek
2016-12-01 17:06 ` [Qemu-devel] " Laszlo Ersek
2016-12-01 17:06 ` [Qemu-arm] [PATCH v4 1/7] fw-cfg: support writeable blobs Laszlo Ersek
2016-12-01 17:06   ` [Qemu-devel] " Laszlo Ersek
2016-12-20 15:58   ` [Qemu-arm] " Marcel Apfelbaum
2016-12-20 15:58     ` Marcel Apfelbaum
2017-01-10 13:33     ` [Qemu-arm] " Laszlo Ersek
2017-01-10 13:33       ` Laszlo Ersek
2016-12-01 17:06 ` [Qemu-devel] [PATCH v4 2/7] fw-cfg: turn FW_CFG_FILE_SLOTS into a device property Laszlo Ersek
2016-12-02 11:10   ` Gerd Hoffmann [this message]
2016-12-02 11:48     ` Laszlo Ersek
2016-12-02 12:47       ` Gerd Hoffmann
2016-12-06 10:50   ` Igor Mammedov
2016-12-06 11:43     ` Laszlo Ersek
2016-12-06 12:02       ` Igor Mammedov
2016-12-06 16:22         ` Laszlo Ersek
2017-01-10 15:02   ` Michael S. Tsirkin
2016-12-01 17:06 ` [Qemu-devel] [PATCH v4 3/7] fw-cfg: expose "file_slots" parameter in fw_cfg_init_io_dma() Laszlo Ersek
2016-12-06 11:49   ` Igor Mammedov
2016-12-06 16:46     ` Laszlo Ersek
2016-12-06 16:52       ` Laszlo Ersek
2016-12-06 23:21         ` David Gibson
2016-12-06 18:09       ` Igor Mammedov
2016-12-06 18:09         ` Igor Mammedov
2016-12-06 19:29         ` [Qemu-devel] " Stefano Stabellini
2016-12-06 19:29           ` Stefano Stabellini
2017-01-10 15:02   ` [Qemu-devel] " Michael S. Tsirkin
2016-12-01 17:06 ` [Qemu-devel] [PATCH v4 4/7] hw/i386/pc: introduce 2.9 machine types with 0x20 fw_cfg file slots Laszlo Ersek
2016-12-01 17:06 ` [Qemu-devel] [PATCH v4 5/7] hw/isa/lpc_ich9: add SMI feature negotiation via fw_cfg Laszlo Ersek
2016-12-02 11:54   ` Igor Mammedov
2016-12-02 12:00     ` Laszlo Ersek
2016-12-01 17:06 ` [Qemu-devel] [PATCH v4 6/7] hw/isa/lpc_ich9: add broadcast SMI feature Laszlo Ersek
2016-12-01 17:06 ` [Qemu-devel] [PATCH v4 7/7] hw/i386/pc_q35: advertise broadcast SMI if VCPU hotplug is turned off Laszlo Ersek
2016-12-01 19:13   ` Eduardo Habkost
2016-12-01 20:42     ` Laszlo Ersek
2016-12-01 20:53       ` Eduardo Habkost
2016-12-02 12:18       ` Igor Mammedov
2016-12-02 19:32         ` Laszlo Ersek
2016-12-20 23:01 ` [Qemu-arm] [Qemu-devel] [PATCH v4 0/7] q35: add negotiable broadcast SMI no-reply
2016-12-20 23:01   ` no-reply
2016-12-21 15:22   ` [Qemu-arm] checkpatch.pl false positive (was Re: [Qemu-devel] [PATCH v4 0/7] q35: add negotiable broadcast SMI) Eduardo Habkost
2016-12-21 15:22     ` [Qemu-devel] checkpatch.pl false positive (was " Eduardo Habkost
2016-12-21 15:22     ` Eduardo Habkost
2016-12-21 17:47     ` [Qemu-arm] " Paolo Bonzini
2016-12-21 17:47       ` [Qemu-devel] " Paolo Bonzini
2016-12-21 18:01       ` [Qemu-arm] " Eduardo Habkost
2016-12-21 18:01         ` [Qemu-devel] " Eduardo Habkost
2016-12-21 18:08         ` [Qemu-arm] " Paolo Bonzini
2016-12-21 18:08           ` [Qemu-devel] " Paolo Bonzini
2016-12-21 18:19           ` Eduardo Habkost
2016-12-21 18:19             ` Eduardo Habkost
2017-01-10 15:06 ` [Qemu-arm] [PATCH v4 0/7] q35: add negotiable broadcast SMI Michael S. Tsirkin
2017-01-10 15:06   ` [Qemu-devel] " Michael S. Tsirkin
2017-01-10 15:23   ` [Qemu-arm] " Laszlo Ersek
2017-01-10 15:23     ` [Qemu-devel] " Laszlo Ersek
2017-01-10 16:05     ` [Qemu-arm] " Michael S. Tsirkin
2017-01-10 16:05       ` [Qemu-devel] " Michael S. Tsirkin
2017-01-10 16:19       ` Laszlo Ersek
2017-01-10 16:19         ` Laszlo Ersek
2017-01-10 16:21     ` [Qemu-arm] " Igor Mammedov
2017-01-10 16:21       ` Igor Mammedov
2017-01-10 16:30       ` [Qemu-arm] " Laszlo Ersek
2017-01-10 16:30         ` Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1480677038.13905.9.camel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=lersek@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=somlo@cmu.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.